New issue
Advanced search Search tips

Issue 844402 link

Starred by 2 users

Issue metadata

Status: Assigned
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 3
Type: Bug

Blocking:
issue 843511
issue 844392



Sign in to add a comment

extension_browsertests 's SocketsUdpApiTest.SocketsUdpExtension fails on ToTMac, ToTMacASan

Project Member Reported by thakis@chromium.org, May 18 2018

Issue description

https://logs.chromium.org/v/?s=chromium%2Fbb%2Fchromium.clang%2FToTMacASan%2F1089%2F%2B%2Frecipes%2Fsteps%2Fextensions_browsertests%2F0%2Flogs%2FSocketsUdpApiTest.SocketsUdpExtension%2F0

Error
    at Object.handleRequest (extensions::binding:64:27)
    at Object.<anonymous> (extensions::binding:374:32)
    at waitForBlockingOperation (chrome-extension://mnmacdaelekljjophambdfgbccdabfgk/background.js:83:17)", source: chrome-extension://mnmacdaelekljjophambdfgbccdabfgk/_generated_background_page.html (0)
[12089:775:0516/172359.197063:1609435859114:INFO:CONSOLE(138)] "Uncaught chrome.test.failure", source: extensions::test (138)
../../extensions/browser/api/sockets_udp/sockets_udp_apitest.cc:98: Failure
Value of: catcher.GetNextResult()
  Actual: false
Expected: true
Failed 1 of 4 tests
Stack trace:
0   extensions_browsertests             0x000000010ccb80e2 testing::internal::UnitTestImpl::CurrentOsStackTraceExceptTop(int) + 242
1   extensions_browsertests             0x000000010ccb6cc7 testing::internal::AssertHelper::operator=(testing::Message const&) const + 359
2   extensions_browsertests             0x000000010931f6b3 extensions::SocketsUdpApiTest_SocketsUdpExtension_Test::RunTestOnMainThread() + 4595
3   extensions_browsertests             0x0000000113f638a3 content::BrowserTestBase::ProxyRunTestOnMainThreadLoop() + 1475
4   extensions_browsertests             0x000000010ebf9e5f extensions::ShellBrowserMainParts::PreMainMessageLoopRun() + 2735
5   extensions_browsertests             0x000000010b5a9044 content::BrowserMainLoop::PreMainMessageLoopRun() + 356
6   extensions_browsertests             0x000000010c26e094 content::StartupTaskRunner::RunAllTasksNow() + 132
7   extensions_browsertests             0x000000010b5a4bd6 content::BrowserMainLoop::CreateStartupTasks() + 1798
8   extensions_browsertests             0x000000010b5b0070 content::BrowserMainRunnerImpl::Initialize(content::MainFunctionParams const&) + 448
9   extensions_browsertests             0x000000010b59de9e content::BrowserMain(content::MainFunctionParams const&) + 574
10  extensions_browsertests             0x000000010eb551fe content::ContentMainRunnerImpl::Run() + 1006
11  extensions_browsertests             0x0000000112a2c434 service_manager::Main(service_manager::MainParams const&) + 4708
12  extensions_browsertests             0x000000010cd042c1 content::ContentMain(content::ContentMainParams const&) + 353
13  extensions_browsertests             0x0000000113f6258a content::BrowserTestBase::SetUp() + 5578
14  extensions_browsertests             0x00000001093c23cd extensions::AppShellTest::SetUp() + 797
[  FAILED  ] SocketsUdpApiTest.SocketsUdpExtension, where TypeParam =  and GetParam() =  (7452 ms)


This test too passes on the main waterfall asan bot but fails on the tot bot. extension_browsertests used to not run on the tot bots. Tentatively marking roll blocker as well.


(filed issue 844401 for the unrelated logspam)
 
Cc: r...@chromium.org
Owner: xiy...@chromium.org
Status: Assigned (was: Untriaged)
Assigning to xiyuan@ who owns extensions/browser/api/sockets_udp.

Comment 2 by thakis@chromium.org, May 22 2018

Cc: inglorion@chromium.org
xiyuan: What's the status here? If this takes a while to investigate, can you disable the test under asan for now?

Comment 3 by xiy...@chromium.org, May 22 2018

will create a CL to disable it on mac asan. rkc@ and I are really owners for ChromeOS and could use some help on other platforms.
Project Member

Comment 4 by bugdroid1@chromium.org, May 22 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1df94b66ea8073ef9062efe6adf8624401bfb6f3

commit 1df94b66ea8073ef9062efe6adf8624401bfb6f3
Author: Xiyuan Xia <xiyuan@chromium.org>
Date: Tue May 22 17:36:09 2018

Disable SocketsUdpExtension on Mac asan

The test consistently times out since ToTMacASan build 1089 and
needs investigation.

Bug: 844402
Change-Id: I30c6348f888b5c466fe693831530ec37cdee953c
Reviewed-on: https://chromium-review.googlesource.com/1069122
Reviewed-by: Lei Zhang <thestig@chromium.org>
Commit-Queue: Xiyuan Xia <xiyuan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#560682}
[modify] https://crrev.com/1df94b66ea8073ef9062efe6adf8624401bfb6f3/extensions/browser/api/sockets_udp/sockets_udp_apitest.cc

Turns out this test also fails on https://ci.chromium.org/buildbot/chromium.clang/ToTMac/1705 , same error. That bot does component builds in release, something we don't do on the main waterfall.

xiyuan, it looks like this test has general issues at least on Mac. Can you maybe take a real look at this? (If not, please disable this in mac component builds too I suppose.)
Blocking: 843511
Summary: extension_browsertests 's SocketsUdpApiTest.SocketsUdpExtension fails on ToTMac, ToTMacASan (was: extension_browsertests 's SocketsUdpApiTest.SocketsUdpExtension fails on ToTMacASan)
I'll disable it for mac. Neither rkc@ nor I worked on mac before.
Socket API is part of platform app and is deprecated on desktop chrome (i.e. on Windows, Mac, and Linux). It is only officially supported on ChromeOS.
Should all its code and test be compiled out on non-cros then?
Project Member

Comment 11 by bugdroid1@chromium.org, Jun 4 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5e451f43d25a0c694d28e8039ca4942a15b8cf1e

commit 5e451f43d25a0c694d28e8039ca4942a15b8cf1e
Author: Xiyuan Xia <xiyuan@chromium.org>
Date: Mon Jun 04 17:16:04 2018

Disable SocketsUdpExtension on Mac

Also fails on ToTMac. Disable it there too.

Bug: 844402
Change-Id: I6a069aae5f2d8b2c0a2357e01c025a2f025469e7
Reviewed-on: https://chromium-review.googlesource.com/1085491
Reviewed-by: Nico Weber <thakis@chromium.org>
Commit-Queue: Xiyuan Xia <xiyuan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#564129}
[modify] https://crrev.com/5e451f43d25a0c694d28e8039ca4942a15b8cf1e/extensions/browser/api/sockets_udp/sockets_udp_apitest.cc

Sign in to add a comment