New issue
Advanced search Search tips

Issue 844396 link

Starred by 2 users

Issue metadata

Status: Assigned
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 3
Type: Bug



Sign in to add a comment

crashpad_test 's MachOImageAnnotationsReader.CrashModuleInitialization fails on ToTMacASan

Project Member Reported by thakis@chromium.org, May 18 2018

Issue description

I'm adding more tests to various bots. I added crashpad_test to ToTMacASan (but not yet to the main waterfall mac asan bot).

One test fails:

https://logs.chromium.org/v/?s=chromium%2Fbb%2Fchromium.clang%2FToTMacASan%2F1089%2F%2B%2Frecipes%2Fsteps%2Fcrashpad_tests%2F0%2Flogs%2FMachOImageAnnotationsReader.CrashModuleInitialization%2F0

https://ci.chromium.org/buildbot/chromium.clang/ToTMacASan/1089

../../third_party/crashpad/crashpad/snapshot/mac/mach_o_image_annotations_reader_test.cc:241: Failure
Value of: found
  Actual: false
Expected: true
/b/s/w/ir/out/Release/./crashpad_snapshot_test_module_crashy_initializer.so
Stack trace:
0   crashpad_tests                      0x00000001085e9c62 testing::internal::UnitTestImpl::CurrentOsStackTraceExceptTop(int) + 242
1   crashpad_tests                      0x00000001085e8847 testing::internal::AssertHelper::operator=(testing::Message const&) const + 359
2   crashpad_tests                      0x00000001080d47da crashpad::test::(anonymous namespace)::TestMachOImageAnnotationsReader::CatchMachException(int, unsigned int, unsigned int, unsigned int, int, long long const*, unsigned int, int*, unsigned int const*, unsigned int, unsigned int*, unsigned int*, mach_msg_trailer_t const*, bool*) + 7610
3   crashpad_tests                      0x000000010879f104 crashpad::internal::UniversalMachExcServerImpl::CatchException(int, unsigned int, unsigned int, unsigned int, int, int const*, unsigned int, int*, unsigned int const*, unsigned int, unsigned int*, unsigned int*, mach_msg_trailer_t const*, bool*) + 868
4   crashpad_tests                      0x00000001087a0a53 non-virtual thunk to crashpad::(anonymous namespace)::SimplifiedExcServer<crashpad::(anonymous namespace)::ExcTraits>::CatchExceptionRaise(unsigned int, unsigned int, unsigned int, int, int const*, unsigned int, mach_msg_trailer_t const*, bool*) + 371
5   crashpad_tests                      0x000000010879fb08 crashpad::(anonymous namespace)::ExcServer<crashpad::(anonymous namespace)::ExcTraits>::MachMessageServerFunction(mach_msg_header_t const*, mach_msg_header_t*, bool*) + 1800
6   crashpad_tests                      0x00000001087a75c2 crashpad::MachMessageServer::Run(crashpad::MachMessageServer::Interface*, unsigned int, int, crashpad::MachMessageServer::Persistent, crashpad::MachMessageServer::ReceiveLarge, unsigned int) + 1986
7   crashpad_tests                      0x00000001080cf26c crashpad::test::(anonymous namespace)::TestMachOImageAnnotationsReader::MachMultiprocessParent() + 16172
8   crashpad_tests                      0x000000010882f28e crashpad::test::MachMultiprocess::MultiprocessParent() + 18366
9   crashpad_tests                      0x000000010882320f crashpad::test::Multiprocess::RunParent() + 287
10  crashpad_tests                      0x00000001088211df crashpad::test::Multiprocess::Run() + 2959
11  crashpad_tests                      0x0000000108828b2f crashpad::test::MachMultiprocess::Run() + 815
12  crashpad_tests                      0x00000001080d9551 crashpad::test::(anonymous namespace)::MachOImageAnnotationsReader_CrashModuleInitialization_Test::TestBody() + 305
[  FAILED  ] MachOImageAnnotationsReader.CrashModuleInitialization (1996 ms)
 
Project Member

Comment 1 by bugdroid1@chromium.org, May 18 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f11ad6a3e4af5133c6aa410889d197cad912f738

commit f11ad6a3e4af5133c6aa410889d197cad912f738
Author: Nico Weber <thakis@chromium.org>
Date: Fri May 18 15:58:56 2018

Disable MachOImageAnnotationsReader.CrashModuleInitialization under ASan.

Bug: 844396
Change-Id: I830b2f7696ea3f388d77e8b53debe2635ebb7232
Reviewed-on: https://chromium-review.googlesource.com/1065459
Reviewed-by: Robert Sesek <rsesek@chromium.org>
Commit-Queue: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#559909}
[modify] https://crrev.com/f11ad6a3e4af5133c6aa410889d197cad912f738/third_party/crashpad/crashpad/snapshot/mac/mach_o_image_annotations_reader_test.cc

Cc: -mark@chromium.org
Owner: mark@chromium.org
Status: Assigned (was: Untriaged)
Triage: Assigning to mark@ as its P3. If it's more important to fix this sooner, we can reassign.

Sign in to add a comment