Issue metadata
Sign in to add a comment
|
Regression : Separation line is seen missing between 'Select one or more files' text and header part in Files App |
||||||||||||||||||||||
Issue description
Chrome Version: 68.0.3433.0/10689.0.0 dev-channel Daisy,Reks and Candy
OS: Chrome
What steps will reproduce the problem?
(1)Sign into User -> open Gmail -> now click on 'COMPOSE' option to send a Mail
(2)In draft mail click on 'Attach files' option -> 'Select one or more files' window is seen
(3)Now try to select 2 or 3 files('Cancel selection',Files selected header is seen ) -> observe separation line is seen missing between 'Select one or more files' text and header part
(Please refer Video and Screenshot)
Expected: Separation line should be seen between 'Select one or more files' text and header part
Actual: Instead separation line is seen missing between 'Select one or more files' text and header part
This is Regression Issue as same is working fine in M-67
@fukino : Please confirm the Issue
,
May 21 2018
P-1 since its a regression. It looks like this is caused from a system-wide colour scheme change to dialogs (we don't control the formatting for the border). It was changed to white as part of a style change. I'll TAL at this. Weifang - would you like me to add a grey border to the top of the Files app? That would make it appear a little more consistent. I'll try it and send you a screenshot.
,
May 23 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f59211e538d6d3e12a43c0f34b84384136c01de3 commit f59211e538d6d3e12a43c0f34b84384136c01de3 Author: Sasha Morrissey <sashab@chromium.org> Date: Wed May 23 06:23:46 2018 Add border to top of File Manager file picker in check-select mode Bug: 844391 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I37f651e972e290447e1de0312b62c647bc6835e5 Reviewed-on: https://chromium-review.googlesource.com/1068585 Reviewed-by: Joel Hockey <joelhockey@chromium.org> Commit-Queue: Sasha Morrissey <sashab@chromium.org> Cr-Commit-Position: refs/heads/master@{#560964} [modify] https://crrev.com/f59211e538d6d3e12a43c0f34b84384136c01de3/ui/file_manager/file_manager/foreground/css/file_manager.css
,
May 24 2018
|
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by weifangsun@chromium.org
, May 18 2018Labels: -Pri-1 Pri-2
Owner: sashab@chromium.org