New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 844374 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: May 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Regression:Overlapping of text is seen with Cancel button on audit overlay

Reported by vineetha...@etouch.net, May 18 2018

Issue description

Chrome Version : 68.0.3434.0 (Official Build) Revision 9de3f10c48c97d2fdb34fa795b7b918f010fc229-refs/branch-heads/3434@{#1}(32/64-bit)
OS : Windows(7,8,8.1,10)

What steps will reproduce the problem?
1. Launch chrome, navigate to NTP.
2. Now open devtools, go to 'Audit' section and run 'Audit'.
3. At the same time open another NTP ,perform step 2 again on it and observe the audit overlay(refer screen cast). 

Actual Result : Text overlaps with Cancel button on audit overlay.
Expected Result : Text should not overlap with Cancel button on audit overlay.

This is regression issue broken in ‘M-68’ and providing the bisect info below,
(Unable to provide bisect using per-revision script,Hence providing bisect with old script):
Good Build : 68.0.3433.0 (Revision : 559328)
Bad Build  : 68.0.3434.0 (Revision : 559775)

Narrow bisect info:

https://chromium.googlesource.com/chromium/src/+log/92310cbab544a1a3ed2b1b0623155e2fe8c2c859..3f2dc028ad0011e5d68b17bf41870a9296181f28?pretty=fuller&n=50

Suspecting: r559754?

From the CL above, assigning the issue to the concern owner 

@phulce- Could you please check whether this is caused with respect to your change, if not please help us in assigning it to the right owner.

Note: The issue is not seen on Mac(10.12.6, 10.13.1, 10.13.5) and Linux(14.04) OS.

 
Actual_video.mp4
660 KB View Download
Expected_video.mp4
542 KB View Download
Actual_screenshot.png
121 KB View Download
Expected_screenshot.png
107 KB View Download
Project Member

Comment 1 by bugdroid1@chromium.org, May 24 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d59f3187f7909c54af5b971d92415461a24faeb5

commit d59f3187f7909c54af5b971d92415461a24faeb5
Author: Patrick Hulce <phulce@chromium.org>
Date: Thu May 24 00:34:56 2018

DevTools: Audits2 UI Polish

- Convert dropdowns to radio/checkbox inputs
- Resize icons/line height/padding
- Overlay size fix
- Minor typographic adjustments
- Disable start audit button when on active view

BUG= 844331 , 844334 , 844374 , 844352 , 844324 , 844318 

Change-Id: Ieb87ce0994031c69a260bddf83f8ad995c8ea70c
Reviewed-on: https://chromium-review.googlesource.com/1066302
Commit-Queue: Patrick Hulce <phulce@chromium.org>
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#561332}
[modify] https://crrev.com/d59f3187f7909c54af5b971d92415461a24faeb5/third_party/WebKit/LayoutTests/http/tests/devtools/audits2/audits2-limited-run-expected.txt
[modify] https://crrev.com/d59f3187f7909c54af5b971d92415461a24faeb5/third_party/WebKit/LayoutTests/http/tests/devtools/audits2/audits2-limited-run.js
[modify] https://crrev.com/d59f3187f7909c54af5b971d92415461a24faeb5/third_party/WebKit/LayoutTests/http/tests/devtools/audits2/audits2-prevent-run-expected.txt
[modify] https://crrev.com/d59f3187f7909c54af5b971d92415461a24faeb5/third_party/WebKit/LayoutTests/http/tests/devtools/audits2/audits2-successful-run-expected.txt
[modify] https://crrev.com/d59f3187f7909c54af5b971d92415461a24faeb5/third_party/blink/renderer/devtools/BUILD.gn
[modify] https://crrev.com/d59f3187f7909c54af5b971d92415461a24faeb5/third_party/blink/renderer/devtools/front_end/audits2/Audits2Controller.js
[modify] https://crrev.com/d59f3187f7909c54af5b971d92415461a24faeb5/third_party/blink/renderer/devtools/front_end/audits2/Audits2Panel.js
[modify] https://crrev.com/d59f3187f7909c54af5b971d92415461a24faeb5/third_party/blink/renderer/devtools/front_end/audits2/Audits2StartView.js
[add] https://crrev.com/d59f3187f7909c54af5b971d92415461a24faeb5/third_party/blink/renderer/devtools/front_end/audits2/RadioSetting.js
[modify] https://crrev.com/d59f3187f7909c54af5b971d92415461a24faeb5/third_party/blink/renderer/devtools/front_end/audits2/audits2Dialog.css
[modify] https://crrev.com/d59f3187f7909c54af5b971d92415461a24faeb5/third_party/blink/renderer/devtools/front_end/audits2/audits2StartView.css
[modify] https://crrev.com/d59f3187f7909c54af5b971d92415461a24faeb5/third_party/blink/renderer/devtools/front_end/audits2/module.json

Comment 2 by phulce@chromium.org, May 25 2018

Status: Fixed (was: Assigned)
This should be fixed for reasonably sized viewports. The behavior is intentional once the DevTools become short enough as we'd prefer the text to be visible but overlapping to scrollable/invisible.
Labels: TE-Verified-69.0.3443.0 TE-Verified-M69
Update :
Rechecked the above issue on Windows(7,8,8.1,10) OS with latest Canary Chrome version #69.0.3443.0 and the issue is fixed.

Kindly refer the attached screen cast.
FixedVideo.mp4
1.2 MB View Download

Sign in to add a comment