New issue
Advanced search Search tips

Issue 844366 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: May 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 1
Type: Bug-Security



Sign in to add a comment

Bad-cast to SkPixelRef from invalid vptr in SkBitmap::getGenerationID

Project Member Reported by ClusterFuzz, May 18 2018

Issue description

Detailed report: https://clusterfuzz.com/testcase?key=5547723361878016

Fuzzer: libFuzzer_skia_image_filter_proto_fuzzer
Job Type: libfuzzer_chrome_ubsan
Platform Id: linux

Crash Type: Bad-cast
Crash Address: 0x34a320cfcd80
Crash State:
  Bad-cast to SkPixelRef from invalid vptr
  SkBitmap::getGenerationID
  SkSpecialImage_Raster::SkSpecialImage_Raster
  
Sanitizer: undefined (UBSAN)

Recommended Security Severity: High

Regressed: https://clusterfuzz.com/revisions?job=libfuzzer_chrome_ubsan&range=559654:559659

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=5547723361878016

Issue filed automatically.

See https://chromium.googlesource.com/chromium/src/+/master/testing/libfuzzer/reference.md for more information.
 
Project Member

Comment 1 by ClusterFuzz, May 18 2018

Components: Internals>Skia
Labels: Test-Predator-Auto-Components
Automatically applying components based on crash stacktrace and information from OWNERS files.

If this is incorrect, please apply the Test-Predator-Wrong-Components label.
Project Member

Comment 2 by ClusterFuzz, May 18 2018

Cc: metzman@chromium.org
Labels: ClusterFuzz-Auto-CC
Automatically adding ccs based on OWNERS file / target commit history.

If this is incorrect, please add ClusterFuzz-Wrong label.
Project Member

Comment 3 by ClusterFuzz, May 18 2018

Cc: robertph...@google.com
Labels: Test-Predator-Auto-CC
Automatically adding ccs based on suspected regression changelists:

Fix srcBounds computation in SkMatrixConvolutionImageFilter by robertphillips@google.com - https://skia.googlesource.com/skia/+/120784394c160d009bc3aa88dd217c13c105a6ca

If this is incorrect, please let us know why and apply the Test-Predator-Wrong-CLs label.
Project Member

Comment 4 by sheriffbot@chromium.org, May 18 2018

Labels: M-68
Project Member

Comment 5 by sheriffbot@chromium.org, May 18 2018

Labels: ReleaseBlock-Stable
This is a serious security regression. If you are not able to fix this quickly, please revert the change that introduced it.

If this doesn't affect a release branch, or has not been properly classified for severity, please update the Security_Impact or Security_Severity labels, and remove the ReleaseBlock label. To disable this altogether, apply ReleaseBlock-NA.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 6 by sheriffbot@chromium.org, May 18 2018

Labels: Pri-1
Cc: -robertph...@google.com
Owner: robertphillips@chromium.org
Status: Assigned (was: Untriaged)
Project Member

Comment 8 by ClusterFuzz, May 19 2018

ClusterFuzz has detected this issue as fixed in range 559906:559949.

Detailed report: https://clusterfuzz.com/testcase?key=5547723361878016

Fuzzer: libFuzzer_skia_image_filter_proto_fuzzer
Job Type: libfuzzer_chrome_ubsan
Platform Id: linux

Crash Type: Bad-cast
Crash Address: 0x34a320cfcd80
Crash State:
  Bad-cast to SkPixelRef from invalid vptr
  SkBitmap::getGenerationID
  SkSpecialImage_Raster::SkSpecialImage_Raster
  
Sanitizer: undefined (UBSAN)

Recommended Security Severity: High

Regressed: https://clusterfuzz.com/revisions?job=libfuzzer_chrome_ubsan&range=559654:559659
Fixed: https://clusterfuzz.com/revisions?job=libfuzzer_chrome_ubsan&range=559906:559949

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=5547723361878016

See https://chromium.googlesource.com/chromium/src/+/master/testing/libfuzzer/reference.md for more information.

If you suspect that the result above is incorrect, try re-doing that job on the test case report page.
Project Member

Comment 9 by ClusterFuzz, May 19 2018

Labels: ClusterFuzz-Verified
Status: Verified (was: Assigned)
ClusterFuzz testcase 5547723361878016 is verified as fixed, so closing issue as verified.

If this is incorrect, please add ClusterFuzz-Wrong label and re-open the issue.
Project Member

Comment 10 by sheriffbot@chromium.org, May 19 2018

Labels: -Restrict-View-SecurityTeam Restrict-View-SecurityNotify
Most likely this was fixed by:

https://skia-review.googlesource.com/c/skia/+/129165 (Fix bugs related to SkMatrixConvolutionImageFilter in repeat mode)

and

https://skia-review.googlesource.com/c/skia/+/129184 (Fix fuzzer bug i.e., compute the correct repeated dst domain)
Labels: -ReleaseBlock-Stable
Project Member

Comment 13 by sheriffbot@chromium.org, Aug 25

Labels: -Restrict-View-SecurityNotify allpublic
This bug has been closed for more than 14 weeks. Removing security view restrictions.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Sign in to add a comment