Regression: Unnecessary header text (Website, Username, Password) is seen even when no password is saved under "Saved Passwords" section in chrome://settings/passwords page
Reported by
khushal....@etouch.net,
May 18 2018
|
||
Issue descriptionChrome Version : 68.0.3434.0 (Official Build) Revision 9de3f10c48c97d2fdb34fa795b7b918f010fc229-refs/branch-heads/3434@{#1} (32/64-bit) OS: Win (7, 8, 8.1, 10), Mac (10.12.6, 10.13.1, 10.13.5), Linux (14.04 LTS) Steps to reproduce: 1. Launch chrome, navigate to chrome://settings/passwords page and observe "Saved Passwords" section. Actual Result: Unnecessary header text (Website, Username, Password) is seen even when no password is saved under "Saved Passwords" section. Expected Result: No header text (Website, Username, Password) should be seen when no password is saved. This is Regression issue broken in 'M-68’ and will provide the bisect info soon: Good Build: 68.0.3425.0 (Revision: 557063) Bad Build: 68.0.3427.0 (Revision: 557758) You are probably looking for a change made after 557336 (known good), but no later than 557337 (first known bad). CHANGE-LOG URL: The script might not always return single CL as suspect as some perf builds might get missing due to failure. https://chromium.googlesource.com/chromium/src/+log/1ed851337f4781d2504bdcc03f11d1ffb5526a3a..79911889545c81db13572295c2dff37120c7da1d Suspect: https://chromium.googlesource.com/chromium/src/+/79911889545c81db13572295c2dff37120c7da1d @aee: Could you please check whether this is caused with respect to your change, if not please help us in assigning it to the right owner. Note: Issue is also seen on M-68 Dev (build #68.0.3432.3). Kindly refer attached screen cast. Thank You..!!
,
May 18 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/1a9ca2450be18e04819f358542e19610a2c342ea commit 1a9ca2450be18e04819f358542e19610a2c342ea Author: Esmael El-Moslimany <aee@chromium.org> Date: Fri May 18 22:34:41 2018 Settings: password section, notify once for |savedPasswords| for initial render Bug: 844363 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I422b5650715031eff628ff5d66a6112c60b9269a Reviewed-on: https://chromium-review.googlesource.com/1066465 Commit-Queue: Esmael El-Moslimany <aee@chromium.org> Reviewed-by: Hector Carmona <hcarmona@chromium.org> Cr-Commit-Position: refs/heads/master@{#560075} [modify] https://crrev.com/1a9ca2450be18e04819f358542e19610a2c342ea/chrome/browser/resources/settings/passwords_and_forms_page/passwords_section.html [modify] https://crrev.com/1a9ca2450be18e04819f358542e19610a2c342ea/chrome/browser/resources/settings/passwords_and_forms_page/passwords_section.js [modify] https://crrev.com/1a9ca2450be18e04819f358542e19610a2c342ea/chrome/test/data/webui/settings/settings_passwords_section_browsertest.js
,
May 18 2018
|
||
►
Sign in to add a comment |
||
Comment 1 by aee@chromium.org
, May 18 2018