Confusing browser selection logic and error reporting in Telemetry |
||||
Issue descriptionIn the context of issue 844230, I was trying some tests and ran (with *no* devices attached): $ ./tools/perf/run_benchmark memory.top_10_mobile --browser android-chrome memory.top_10_mobile is disabled on the selected browser This platform is not supported for this benchmark. If this is in error please add it to the benchmark's supported platforms. When I re-attach a device the benchmark works fine. This is clearly wrong. The error should have said something like "there are no devices attached" or "coudn't find this browser" or something like that. Not sure why we end up with this "Benchmark disabled on selected browser"? Part of the solution, I think, would be to make it really explicit, after falling FindBrowser to indicate in the output *which* browser was selected.
,
Jan 16
(6 days ago)
,
Jan 16
(6 days ago)
,
Jan 17
(5 days ago)
,
Jan 17
(5 days ago)
|
||||
►
Sign in to add a comment |
||||
Comment 1 by perezju@chromium.org
, Jun 21 2018