New issue
Advanced search Search tips

Issue 844360 link

Starred by 3 users

Issue metadata

Status: Available
Owner: ----
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocked on:
issue 799950



Sign in to add a comment

Confusing browser selection logic and error reporting in Telemetry

Project Member Reported by perezju@chromium.org, May 18 2018

Issue description

In the context of issue 844230, I was trying some tests and ran (with *no* devices attached):


$ ./tools/perf/run_benchmark memory.top_10_mobile --browser android-chrome
memory.top_10_mobile is disabled on the selected browser
This platform is not supported for this benchmark. If this is in error please add it to the benchmark's supported platforms.


When I re-attach a device the benchmark works fine. This is clearly wrong. The error should have said something like "there are no devices attached" or "coudn't find this browser" or something like that. Not sure why we end up with this "Benchmark disabled on selected browser"?

Part of the solution, I think, would be to make it really explicit, after falling FindBrowser to indicate in the output *which* browser was selected.
 
Blockedon: 799950

Comment 2 by benhenry@google.com, Jan 16 (6 days ago)

Components: Test>Telemetry

Comment 3 by benhenry@google.com, Jan 16 (6 days ago)

Components: -Speed>Telemetry

Comment 4 by crouleau@chromium.org, Jan 17 (5 days ago)

Cc: crouleau@chromium.org
 Issue 922734  has been merged into this issue.

Comment 5 by nedngu...@google.com, Jan 17 (5 days ago)

Cc: -nednguyen@chromium.org

Sign in to add a comment