Mac triage: directly to apacible@ - I did not try reproing this yet.

amyroberts@ -- thoughts on how to handle controls visibility when in Picture-in-Picture mode? The button in the center currently appears when in Picture-in-Picture mode. If I understand correctly, this is the only place the play/pause button appears for the new media controls.

Deleted: Screen Shot 2018-05-18 at 23.39.50.png 94.0 KB

	Screen Shot 2018-05-18 at 23.39.50.png 94.0 KB View Download

That's right, the controls will stay where they are and the string will move to the top left. The type styling should match the time stamp.


Mock: https://docs.google.com/presentation/d/1crVckjRA7LZ2S-SPuO8zXMQPw_uZwC0-eBhZ5EEumCw/edit#slide=id.g3b41ba5fc1_0_0

Pattern reference: https://docs.google.com/presentation/d/1crVckjRA7LZ2S-SPuO8zXMQPw_uZwC0-eBhZ5EEumCw/edit#slide=id.g3ab577e518_0_172

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/adb006d21f4ffc92747c083ee3be5113b8fec33a

commit adb006d21f4ffc92747c083ee3be5113b8fec33a
Author: Jennifer Apacible <apacible@chromium.org>
Date: Fri May 25 15:34:47 2018

[Picture in Picture] Update interstitial style.

This change removes the icon from the Picture-in-Picture interstitial.
The text is also moved to the top left of the interstitial and styled
to play well with the modern media controls, e.g. Play/Pause button
will no longer cover the interstitial content.

BUG:  844357 
Change-Id: I3eed46bece9f9b26257a4d2ed4b7a0b6cb3818b8
Reviewed-on: https://chromium-review.googlesource.com/1071231
Commit-Queue: Mounir Lamouri <mlamouri@chromium.org>
Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
Cr-Commit-Position: refs/heads/master@{#561889}
[modify] https://crrev.com/adb006d21f4ffc92747c083ee3be5113b8fec33a/third_party/WebKit/LayoutTests/media/media-controls.js
[modify] https://crrev.com/adb006d21f4ffc92747c083ee3be5113b8fec33a/third_party/WebKit/LayoutTests/media/picture-in-picture/utils.js
[modify] https://crrev.com/adb006d21f4ffc92747c083ee3be5113b8fec33a/third_party/blink/renderer/core/html/media/picture_in_picture_interstitial.cc
[modify] https://crrev.com/adb006d21f4ffc92747c083ee3be5113b8fec33a/third_party/blink/renderer/core/html/media/picture_in_picture_interstitial.h
[modify] https://crrev.com/adb006d21f4ffc92747c083ee3be5113b8fec33a/third_party/blink/renderer/modules/media_controls/resources/mediaInterstitials.css

Your change meets the bar and is auto-approved for M68. Please go ahead and merge the CL to branch 3440 manually. Please contact milestone owner if you have questions.
Owners: cmasso@(Android), kariahda@(iOS), bhthompson@(ChromeOS), abdulsyed@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible!

If all merges have been completed, please remove any remaining Merge-Approved labels from this issue.

Thanks for your time! To disable nags, add the Disable-Nags label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible!

If all merges have been completed, please remove any remaining Merge-Approved labels from this issue.

Thanks for your time! To disable nags, add the Disable-Nags label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot