New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 844352 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: May 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Regression : Default text on dropdown in audit section is seen faint on applying dark theme.

Reported by pranjali...@etouch.net, May 18 2018

Issue description

Chrome version : 68.0.3434.0 (Official Build) 9de3f10c48c97d2fdb34fa795b7b918f010fc229-refs/branch-heads/3434@{#1} (32/64 bit)

OS : Mac(10.12.6 , 10.13.1 , 10.13.5) , Windows(7,8,8.1,10) and and Linux(14.04 LTS) OS. 

Steps to reproduce:
1. Launch chrome, open devtools on NTP, hit F1 and set 'Dark' theme as default.
2. Now go to 'Audit' section and observe.
	
Actual Result: Default text on dropdown in audit section is seen faint on applying dark theme.
Expected Result: Default text on dropdown in audit section should be seen little darker on applying dark theme.

This is a regression issue broken in ‘M-68’ and will soon update other bisect info.
Good Build : 68.0.3433.0 (Revision : 559328)
Bad Build : 68.0.3434.0 (Revision : 559775)

You are probably looking for a change made after 559753(known good), but no later than 559754(first known bad).

CHANGELOG URL:

The script might not always return single CL as suspect as some perf builds might get missing due to failure.

https://chromium.googlesource.com/chromium/src/+log/f536a88e25b936a34db5800f4412603de7746404..3f2dc028ad0011e5d68b17bf41870a9296181f28

Suspect : https://chromium.googlesource.com/chromium/src/+/3f2dc028ad0011e5d68b17bf41870a9296181f28

@phulce: Could you please check whether this is caused with respect to your change, if not please help us in assigning it to the right owner.

Thank You..
 
Actual_screenshot.png
127 KB View Download
Expected_screenshot.png
137 KB View Download
Project Member

Comment 1 by bugdroid1@chromium.org, May 24 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d59f3187f7909c54af5b971d92415461a24faeb5

commit d59f3187f7909c54af5b971d92415461a24faeb5
Author: Patrick Hulce <phulce@chromium.org>
Date: Thu May 24 00:34:56 2018

DevTools: Audits2 UI Polish

- Convert dropdowns to radio/checkbox inputs
- Resize icons/line height/padding
- Overlay size fix
- Minor typographic adjustments
- Disable start audit button when on active view

BUG= 844331 , 844334 , 844374 , 844352 , 844324 , 844318 

Change-Id: Ieb87ce0994031c69a260bddf83f8ad995c8ea70c
Reviewed-on: https://chromium-review.googlesource.com/1066302
Commit-Queue: Patrick Hulce <phulce@chromium.org>
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#561332}
[modify] https://crrev.com/d59f3187f7909c54af5b971d92415461a24faeb5/third_party/WebKit/LayoutTests/http/tests/devtools/audits2/audits2-limited-run-expected.txt
[modify] https://crrev.com/d59f3187f7909c54af5b971d92415461a24faeb5/third_party/WebKit/LayoutTests/http/tests/devtools/audits2/audits2-limited-run.js
[modify] https://crrev.com/d59f3187f7909c54af5b971d92415461a24faeb5/third_party/WebKit/LayoutTests/http/tests/devtools/audits2/audits2-prevent-run-expected.txt
[modify] https://crrev.com/d59f3187f7909c54af5b971d92415461a24faeb5/third_party/WebKit/LayoutTests/http/tests/devtools/audits2/audits2-successful-run-expected.txt
[modify] https://crrev.com/d59f3187f7909c54af5b971d92415461a24faeb5/third_party/blink/renderer/devtools/BUILD.gn
[modify] https://crrev.com/d59f3187f7909c54af5b971d92415461a24faeb5/third_party/blink/renderer/devtools/front_end/audits2/Audits2Controller.js
[modify] https://crrev.com/d59f3187f7909c54af5b971d92415461a24faeb5/third_party/blink/renderer/devtools/front_end/audits2/Audits2Panel.js
[modify] https://crrev.com/d59f3187f7909c54af5b971d92415461a24faeb5/third_party/blink/renderer/devtools/front_end/audits2/Audits2StartView.js
[add] https://crrev.com/d59f3187f7909c54af5b971d92415461a24faeb5/third_party/blink/renderer/devtools/front_end/audits2/RadioSetting.js
[modify] https://crrev.com/d59f3187f7909c54af5b971d92415461a24faeb5/third_party/blink/renderer/devtools/front_end/audits2/audits2Dialog.css
[modify] https://crrev.com/d59f3187f7909c54af5b971d92415461a24faeb5/third_party/blink/renderer/devtools/front_end/audits2/audits2StartView.css
[modify] https://crrev.com/d59f3187f7909c54af5b971d92415461a24faeb5/third_party/blink/renderer/devtools/front_end/audits2/module.json

Comment 2 by phulce@chromium.org, May 25 2018

Status: Fixed (was: Assigned)
Labels: TE-Verified-69.0.3443.0 TE-Verified-M69
Update :
Rechecked the above issue on  Mac(10.12.6 , 10.13.1 , 10.13.5) , Windows(7,8,8.1,10) and and Linux(14.04 LTS) OS with latest Canary Chrome version #69.0.3443.0 and the issue is fixed.

Kindly refer the attached screen cast.
Canary_behaviour.mp4
560 KB View Download

Sign in to add a comment