New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 844332 link

Starred by 2 users
Status: Verified
Owner:
justincohen@chromium.org
Closed: Jun 2018
Cc:
ios-bugs-priority@chromium.org
ios-bugs@chromium.org
█ ramyan@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 1
Type: Bug
Q2



Sign in to add a comment

New Tab Page: "Learn More" is displayed behind bottom toolbar

Project Member Reported by gambard@chromium.org, May 18 2018 
With UI refresh flag enabled

What steps will reproduce the problem?
(1) Open NTP
(2) Scroll up

What is the expected result?
The "Learn More about suggested content" item should be visible.

What happens instead?
It is hidden by the bottom toolbar.

Comment 1 by justincohen@chromium.org, May 18 2018 

(1) Open NTP
(2) *** trigger an overscroll.  any size overscroll will do **
(3) Scroll up

Comment 2 by twelling...@chromium.org, May 22 2018

Labels: -OS-iOS zine-triaged

Comment 3 by justincohen@chromium.org, May 23 2018

Components: UI>Browser>PullToAction

Comment 4 by ramyan@chromium.org, May 30 2018

Labels: OS-iOS

Comment 5 by justincohen@chromium.org, Jun 27 2018

Status: Started (was: Assigned)
Project Member

Comment 6 by bugdroid1@chromium.org, Jun 27 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b4624cd33f24794a1533851e3b689171652ec3ba

commit b4624cd33f24794a1533851e3b689171652ec3ba
Author: Justin Cohen <justincohen@google.com>
Date: Wed Jun 27 23:47:54 2018

[ios] Fix overscroll stomping on scrollView content offset.

Bug:  844332 
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: I10b4797e9e189dd03d783642b20352a546a449c2
Reviewed-on: https://chromium-review.googlesource.com/1070515
Commit-Queue: Kurt Horimoto <kkhorimoto@chromium.org>
Reviewed-by: Kurt Horimoto <kkhorimoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#570933}
[modify] https://crrev.com/b4624cd33f24794a1533851e3b689171652ec3ba/ios/chrome/browser/ui/overscroll_actions/overscroll_actions_controller.mm

Comment 7 by justincohen@chromium.org, Jun 28 2018

Status: Fixed (was: Started)

Comment 8 by subhashi...@chromium.org, Jul 3

Status: Verified (was: Fixed)
Verified in:

App Version: 69.0.3480.0 canary
Devices: iPhone 7 Plus, iPhone X
iOS Versions: 10.3.3, 11.4.1 beta 5

'Learn more about suggested content' is visible even after triggering over scroll.
►

Sign in to add a comment