New issue
Advanced search Search tips

Issue 844329 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner:
Closed: May 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 1
Type: Bug-Regression

Blocking:
issue 831852



Sign in to add a comment

Regression: No space is observed between separator line and Add/Cancel Buttons.

Reported by aiman.an...@etouch.net, May 18 2018

Issue description

Chrome Version: 68.0.3434.0 (Official Build) Revision 9de3f10c48c97d2fdb34fa795b7b918f010fc229-refs/branch-heads/3434@{#1}  (32/64-bit)

OS: Win(7,8,8.1,10), and Linux(14.04 LTS).

What steps will reproduce the problem?
1. Launch chrome, navigate to chrome://settings/languages 
2. Click on Add Languages and Observe 'Add' and 'Cancel' Button.

Actual Result: No space is observed between separator line and Add/Cancel Buttons. 
Expected Result: Space should be seen between separator line and Add/Cancel buttons

This is a regression issue, broken in M-68  series, and will soon update other info.
Good Build: 68.0.3433.0 
Bad Build: 68.0.3434.0

 
Actual Result.mp4
191 KB View Download
Expected Result.mp4
284 KB View Download
Actual Result.png
17.7 KB View Download
Expected Result.png
18.0 KB View Download
Labels: hasbisect-per-revision OS-Mac
Owner: aee@chromium.org
Status: Assigned (was: Unconfirmed)
This is a regression issue, broken in M-68  series, and will soon update other info.
Good Build: 68.0.3433.0 (Revision:559328)
Bad Build: 68.0.3434.0 (Revision:559775)

You are probably looking for a change made after 559737 (known good), but no later than 559738 (first known bad).

CHANGE-LOG URL:

The script might not always return single CL as suspect as some perf builds might get missing due to failure.

https://chromium.googlesource.com/chromium/src/+log/f9535bd6d61d7e0b2cb452e6976a914d4ee62a2b..607e9a387d3b444550e8b107a15b40c62121f424

Suspect: https://chromium.googlesource.com/chromium/src/+/607e9a387d3b444550e8b107a15b40c62121f424

@aee: Could you please check whether this is caused with respect to your change, if not please help us in assigning it to the right owner

Note: Issue is also seen on Mac(10.12.6, 10.13.1, 10.13.5 ) OS

Thank You!


Labels: RegressedIn-68

Comment 3 by dpa...@chromium.org, May 18 2018

Blocking: 831852

Comment 4 by aee@chromium.org, May 18 2018

Status: Started (was: Assigned)

Comment 5 by dpa...@chromium.org, May 23 2018

Labels: Proj-MaterialDesign-Refresh-WebUI
Let's prioritize this fix, since branch cut is coming up pretty soon.

Comment 6 by dpa...@chromium.org, May 23 2018

 Issue 845978  has been merged into this issue.

Comment 8 by aee@chromium.org, May 24 2018

Status: Fixed (was: Started)
Labels: TE-Verified-68.0.3439.0 TE-Verified-M68
Update : 

Retested above issue in latest Canary build # 68.0.3439.0 on Win(7,8,8.1,10), Linux(14.04 LTS) and Mac(10.12.6, 10.13.1, 10.13.5) and the issue is fixed. Now, proper space is seen between separator line and Add/Cancel buttons

Kindly review an attached screen-cast.

Thank you..!
Current Behaviour.mp4
231 KB View Download

Sign in to add a comment