Regression: No space is observed between separator line and Add/Cancel Buttons.
Reported by
aiman.an...@etouch.net,
May 18 2018
|
|||||||
Issue descriptionChrome Version: 68.0.3434.0 (Official Build) Revision 9de3f10c48c97d2fdb34fa795b7b918f010fc229-refs/branch-heads/3434@{#1} (32/64-bit) OS: Win(7,8,8.1,10), and Linux(14.04 LTS). What steps will reproduce the problem? 1. Launch chrome, navigate to chrome://settings/languages 2. Click on Add Languages and Observe 'Add' and 'Cancel' Button. Actual Result: No space is observed between separator line and Add/Cancel Buttons. Expected Result: Space should be seen between separator line and Add/Cancel buttons This is a regression issue, broken in M-68 series, and will soon update other info. Good Build: 68.0.3433.0 Bad Build: 68.0.3434.0
,
May 18 2018
,
May 18 2018
,
May 18 2018
,
May 23 2018
Let's prioritize this fix, since branch cut is coming up pretty soon.
,
May 23 2018
Issue 845978 has been merged into this issue.
,
May 24 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/29bc0a300e670bb159425a47a5ad7bade2cdf386 commit 29bc0a300e670bb159425a47a5ad7bade2cdf386 Author: Esmael El-Moslimany <aee@chromium.org> Date: Thu May 24 02:46:30 2018 WebUI: ensure padding between title and buttons when body is scrollable Bug: 844329 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: Id9b00c368e32c9cea170af7c6dfaf9a5272e1301 Reviewed-on: https://chromium-review.googlesource.com/1066326 Reviewed-by: Scott Chen <scottchen@chromium.org> Reviewed-by: Rebekah Potter <rbpotter@chromium.org> Commit-Queue: Esmael El-Moslimany <aee@chromium.org> Cr-Commit-Position: refs/heads/master@{#561365} [modify] https://crrev.com/29bc0a300e670bb159425a47a5ad7bade2cdf386/chrome/browser/resources/print_preview/new/destination_dialog.html [modify] https://crrev.com/29bc0a300e670bb159425a47a5ad7bade2cdf386/chrome/browser/resources/print_preview/new/destination_list.html [modify] https://crrev.com/29bc0a300e670bb159425a47a5ad7bade2cdf386/chrome/browser/resources/print_preview/new/search_dialog_css.html [modify] https://crrev.com/29bc0a300e670bb159425a47a5ad7bade2cdf386/chrome/browser/resources/settings/search_engines_page/search_engine_dialog.html [modify] https://crrev.com/29bc0a300e670bb159425a47a5ad7bade2cdf386/ui/webui/resources/cr_elements/cr_dialog/cr_dialog.html
,
May 24 2018
,
May 24 2018
Update : Retested above issue in latest Canary build # 68.0.3439.0 on Win(7,8,8.1,10), Linux(14.04 LTS) and Mac(10.12.6, 10.13.1, 10.13.5) and the issue is fixed. Now, proper space is seen between separator line and Add/Cancel buttons Kindly review an attached screen-cast. Thank you..! |
|||||||
►
Sign in to add a comment |
|||||||
Comment 1 by aiman.an...@etouch.net
, May 18 2018Owner: aee@chromium.org
Status: Assigned (was: Unconfirmed)