New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 844318 link

Starred by 2 users
Status: Fixed
Owner:
█ phulce@chromium.org
Last visit > 30 days ago
Closed: May 2018
Cc:
nyerramilli@chromium.org
rbasuvula@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 2
Type: Bug



Sign in to add a comment

Focus is not seen on dropdown in audit section.

Reported by pranjali...@etouch.net, May 18 2018 
Chrome Version: 68.0.3434.0 (Official Build) 9de3f10c48c97d2fdb34fa795b7b918f010fc229-refs/branch-heads/3434@{#1} (32/64 bit)

OS: Windows(7,8,8.1,10) and and Linux(14.04 LTS) OS.

Steps to reproduce:
1. Launch chrome ,open devtools on NTP and go to 'Audit' section.
2. Now press tab key until focus reaches to 'device' drop down and observe.

Actual Result: Focus is not seen on dropdown in audit section.
Expected Result: Focus should be seen on dropdown in audit section.
 
This is a Non-regression issue seen from 'M68' series i.e 68.0.3434.0

Note: Focus issue is observe for all dropdown in audit section.
Actual_result.mp4
436 KB View Download

Comment 1 by pranjali...@etouch.net, May 18 2018

Labels: OS-Mac

Comment 2 by rbasuvula@chromium.org, May 18 2018

Status: Untriaged (was: Unconfirmed)
As this being a Non-Regression issue, changing the status to Untriaged so that the issue would get addressed.

Thank You!

Comment 3 by dgozman@chromium.org, May 21 2018

Owner: phulce@chromium.org
Status: Assigned (was: Untriaged)
Project Member

Comment 4 by bugdroid1@chromium.org, May 24 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d59f3187f7909c54af5b971d92415461a24faeb5

commit d59f3187f7909c54af5b971d92415461a24faeb5
Author: Patrick Hulce <phulce@chromium.org>
Date: Thu May 24 00:34:56 2018

DevTools: Audits2 UI Polish

- Convert dropdowns to radio/checkbox inputs
- Resize icons/line height/padding
- Overlay size fix
- Minor typographic adjustments
- Disable start audit button when on active view

BUG= 844331 , 844334 , 844374 , 844352 , 844324 , 844318 

Change-Id: Ieb87ce0994031c69a260bddf83f8ad995c8ea70c
Reviewed-on: https://chromium-review.googlesource.com/1066302
Commit-Queue: Patrick Hulce <phulce@chromium.org>
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#561332}
[modify] https://crrev.com/d59f3187f7909c54af5b971d92415461a24faeb5/third_party/WebKit/LayoutTests/http/tests/devtools/audits2/audits2-limited-run-expected.txt
[modify] https://crrev.com/d59f3187f7909c54af5b971d92415461a24faeb5/third_party/WebKit/LayoutTests/http/tests/devtools/audits2/audits2-limited-run.js
[modify] https://crrev.com/d59f3187f7909c54af5b971d92415461a24faeb5/third_party/WebKit/LayoutTests/http/tests/devtools/audits2/audits2-prevent-run-expected.txt
[modify] https://crrev.com/d59f3187f7909c54af5b971d92415461a24faeb5/third_party/WebKit/LayoutTests/http/tests/devtools/audits2/audits2-successful-run-expected.txt
[modify] https://crrev.com/d59f3187f7909c54af5b971d92415461a24faeb5/third_party/blink/renderer/devtools/BUILD.gn
[modify] https://crrev.com/d59f3187f7909c54af5b971d92415461a24faeb5/third_party/blink/renderer/devtools/front_end/audits2/Audits2Controller.js
[modify] https://crrev.com/d59f3187f7909c54af5b971d92415461a24faeb5/third_party/blink/renderer/devtools/front_end/audits2/Audits2Panel.js
[modify] https://crrev.com/d59f3187f7909c54af5b971d92415461a24faeb5/third_party/blink/renderer/devtools/front_end/audits2/Audits2StartView.js
[add] https://crrev.com/d59f3187f7909c54af5b971d92415461a24faeb5/third_party/blink/renderer/devtools/front_end/audits2/RadioSetting.js
[modify] https://crrev.com/d59f3187f7909c54af5b971d92415461a24faeb5/third_party/blink/renderer/devtools/front_end/audits2/audits2Dialog.css
[modify] https://crrev.com/d59f3187f7909c54af5b971d92415461a24faeb5/third_party/blink/renderer/devtools/front_end/audits2/audits2StartView.css
[modify] https://crrev.com/d59f3187f7909c54af5b971d92415461a24faeb5/third_party/blink/renderer/devtools/front_end/audits2/module.json

Comment 5 by phulce@chromium.org, May 25 2018

Status: Fixed (was: Assigned)

Comment 6 by pranjali...@etouch.net, May 28 2018

Labels: TE-Verified-69.0.3443.0 TE-Verified-M69
Update :
Rechecked the above issue on  Mac(10.12.6 , 10.13.1 , 10.13.5) , Windows(7,8,8.1,10) and and Linux(14.04 LTS) OS with latest Canary Chrome version #69.0.3443.0 and the issue is fixed.

Kindly refer the attached screen cast.
Canary_behaviour.mp4
485 KB View Download
►

Sign in to add a comment