New issue
Advanced search Search tips

Issue 844305 link

Starred by 2 users
Status: Fixed
Owner:
robliao@chromium.org
Closed: May 2018
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

Migrate Cocoa's Find Bar Clear Results Behavior to Views

Project Member Reported by robliao@chromium.org, May 18 2018 
Views clears the find bar text field upon navigation. Views with a global pasteboard is not expected to do this as there's no way to prepopulate the text when the find bar is shown again.

This breaks browser_tests FindInPageControllerTest.NavigateClearsOrdinal.
Project Member

Comment 1 by bugdroid1@chromium.org, May 21 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/93d79fe69683fe6a178e8d7c4e703d7f67328f8a

commit 93d79fe69683fe6a178e8d7c4e703d7f67328f8a
Author: Robert Liao <robliao@chromium.org>
Date: Mon May 21 17:46:19 2018

Migrate Cocoa's Find Bar Clear Results Behavior to Views

The Cocoa global pasteboard behavior only updated the find bar if the
find bar was empty and there was new find text. This change copies the
similar behavior to the views find bar by ignoring empty find text.

This fixes browser_tests
FindInPageControllerTest.NavigateClearsOrdinal
FindInPageControllerTest.IncognitoFindNextShared

BUG= 844305 

Change-Id: Idd50476a7368079ec54221513a76bdfa0a272559
Reviewed-on: https://chromium-review.googlesource.com/1065500
Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
Commit-Queue: Robert Liao <robliao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#560293}
[modify] https://crrev.com/93d79fe69683fe6a178e8d7c4e703d7f67328f8a/chrome/browser/ui/views/find_bar_view.cc

Comment 2 by robliao@chromium.org, May 22 2018

Status: Fixed (was: Started)
►

Sign in to add a comment