New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 844301 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: May 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 1
Type: Bug-Security

Blocking:
issue 776656



Sign in to add a comment

Heap-use-after-free in PreviousSibling

Project Member Reported by ClusterFuzz, May 18 2018

Issue description

Detailed report: https://clusterfuzz.com/testcase?key=6072012972490752

Fuzzer: bj_broddelwerk
Job Type: linux_lsan_chrome_mp
Platform Id: linux

Crash Type: Heap-use-after-free READ 8
Crash Address: 0x612000053a70
Crash State:
  PreviousSibling
  blink::LayoutObjectChildList::RemoveChildNode
  blink::LayoutBlockFlow::RemoveChild
  
Sanitizer: address (ASAN)

Recommended Security Severity: High

Regressed: https://clusterfuzz.com/revisions?job=linux_lsan_chrome_mp&range=559423:559424

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=6072012972490752

Issue filed automatically.

See https://github.com/google/clusterfuzz-tools for more information.
 
Project Member

Comment 1 by ClusterFuzz, May 18 2018

Components: Blink>Layout
Labels: Test-Predator-Auto-Components
Automatically applying components based on crash stacktrace and information from OWNERS files.

If this is incorrect, please apply the Test-Predator-Wrong-Components label.
Project Member

Comment 2 by ClusterFuzz, May 18 2018

Labels: Test-Predator-Auto-Owner
Owner: hayato@chromium.org
Status: Assigned (was: Untriaged)
Automatically assigning owner based on suspected regression changelist https://chromium.googlesource.com/chromium/src/+/b6ec484f7d3153135b9640117a89252ff45829b8 (Launch Incremental Shadow DOM).

If this is incorrect, please let us know why and apply the Test-Predator-Wrong-CLs label. If you aren't the correct owner for this issue, please unassign yourself as soon as possible so it can be re-triaged.
Project Member

Comment 3 by sheriffbot@chromium.org, May 18 2018

Labels: M-68

Comment 4 by hayato@chromium.org, May 18 2018

Status: Started (was: Assigned)
Project Member

Comment 6 by sheriffbot@chromium.org, May 18 2018

Labels: ReleaseBlock-Stable
This is a serious security regression. If you are not able to fix this quickly, please revert the change that introduced it.

If this doesn't affect a release branch, or has not been properly classified for severity, please update the Security_Impact or Security_Severity labels, and remove the ReleaseBlock label. To disable this altogether, apply ReleaseBlock-NA.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 7 by sheriffbot@chromium.org, May 18 2018

Labels: Pri-1

Comment 8 by hayato@chromium.org, May 21 2018

Cc: rakina@chromium.org kochi@chromium.org

Comment 9 by hayato@chromium.org, May 21 2018

Cc: yosin@chromium.org
Project Member

Comment 10 by bugdroid1@chromium.org, May 21 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/86ecfe93212a03aa5caf02319acc8a893ce8f8b7

commit 86ecfe93212a03aa5caf02319acc8a893ce8f8b7
Author: Hayato Ito <hayato@chromium.org>
Date: Mon May 21 03:28:45 2018

[IncrementalShadowDOM] Recalc slot assignments before checking NeedsLayoutTreeUpdate()

In Document::UpdateStyleAndLayoutTree(), recalc slot assignments should be done
before checking NeedsLayoutTreeUpdate() to detect the need of layout tree update
surely. Without that, there is an edge case which causes a crash.

Bug:  776656 , 844301 
Change-Id: I1ef7719216649019e07f2799ecd4f1fcb3d961a6
Reviewed-on: https://chromium-review.googlesource.com/1066030
Commit-Queue: Hayato Ito <hayato@chromium.org>
Reviewed-by: Takayoshi Kochi <kochi@chromium.org>
Reviewed-by: Rakina Zata Amni <rakina@chromium.org>
Cr-Commit-Position: refs/heads/master@{#560221}
[add] https://crrev.com/86ecfe93212a03aa5caf02319acc8a893ce8f8b7/third_party/WebKit/LayoutTests/shadow-dom/crashes/selection-delete-crash.html
[modify] https://crrev.com/86ecfe93212a03aa5caf02319acc8a893ce8f8b7/third_party/blink/renderer/core/dom/document.cc

Status: Fixed (was: Started)
Project Member

Comment 12 by ClusterFuzz, May 21 2018

Labels: ClusterFuzz-Verified
Status: Verified (was: Fixed)
ClusterFuzz testcase 5508919674535936 is verified as fixed, so closing issue as verified.

If this is incorrect, please add ClusterFuzz-Wrong label and re-open the issue.
Project Member

Comment 13 by sheriffbot@chromium.org, May 21 2018

Labels: -Restrict-View-SecurityTeam Restrict-View-SecurityNotify
Project Member

Comment 14 by ClusterFuzz, May 23 2018

ClusterFuzz has detected this issue as fixed in range 560949:560951.

Detailed report: https://clusterfuzz.com/testcase?key=6072012972490752

Fuzzer: bj_broddelwerk
Job Type: linux_lsan_chrome_mp
Platform Id: linux

Crash Type: Heap-use-after-free READ 8
Crash Address: 0x612000053a70
Crash State:
  PreviousSibling
  blink::LayoutObjectChildList::RemoveChildNode
  blink::LayoutBlockFlow::RemoveChild
  
Sanitizer: address (ASAN)

Recommended Security Severity: High

Regressed: https://clusterfuzz.com/revisions?job=linux_lsan_chrome_mp&range=559423:559424
Fixed: https://clusterfuzz.com/revisions?job=linux_lsan_chrome_mp&range=560949:560951

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=6072012972490752

See https://github.com/google/clusterfuzz-tools for more information.

If you suspect that the result above is incorrect, try re-doing that job on the test case report page.
Blocking: 776656
Labels: -ReleaseBlock-Stable
Project Member

Comment 17 by sheriffbot@chromium.org, Aug 27

Labels: -Restrict-View-SecurityNotify allpublic
This bug has been closed for more than 14 weeks. Removing security view restrictions.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Sign in to add a comment