New issue
Advanced search Search tips

Issue 844300 link

Starred by 1 user

Issue metadata

Status: Verified
Owner: ----
Closed: May 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 1
Type: Bug



Sign in to add a comment

Null-dereference READ in CacheImpl::removeInternal

Project Member Reported by ClusterFuzz, May 18 2018

Issue description

Detailed report: https://clusterfuzz.com/testcase?key=6037917240393728

Fuzzer: libFuzzer_skia_image_filter_proto_fuzzer
Job Type: libfuzzer_chrome_msan
Platform Id: linux

Crash Type: Null-dereference READ
Crash Address: 0x000000000020
Crash State:
  CacheImpl::removeInternal
  CacheImpl::purgeByImageFilter
  SkImageFilter::~SkImageFilter
  
Sanitizer: memory (MSAN)

Regressed: https://clusterfuzz.com/revisions?job=libfuzzer_chrome_msan&range=559651:559657

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=6037917240393728

Issue filed automatically.

See https://chromium.googlesource.com/chromium/src/+/master/testing/libfuzzer/reference.md for more information.
 
Project Member

Comment 1 by ClusterFuzz, May 18 2018

Components: Internals>Skia
Labels: Test-Predator-Auto-Components
Automatically applying components based on crash stacktrace and information from OWNERS files.

If this is incorrect, please apply the Test-Predator-Wrong-Components label.
Project Member

Comment 2 by ClusterFuzz, May 18 2018

Cc: metzman@chromium.org
Labels: ClusterFuzz-Auto-CC
Automatically adding ccs based on OWNERS file / target commit history.

If this is incorrect, please add ClusterFuzz-Wrong label.
Project Member

Comment 3 by ClusterFuzz, May 18 2018

Cc: robertph...@google.com
Labels: Test-Predator-Auto-CC
Automatically adding ccs based on suspected regression changelists:

Fix srcBounds computation in SkMatrixConvolutionImageFilter by robertphillips@google.com - https://skia.googlesource.com/skia/+/120784394c160d009bc3aa88dd217c13c105a6ca

If this is incorrect, please let us know why and apply the Test-Predator-Wrong-CLs label.
Project Member

Comment 4 by ClusterFuzz, May 19 2018

ClusterFuzz has detected this issue as fixed in range 559927:559991.

Detailed report: https://clusterfuzz.com/testcase?key=6037917240393728

Fuzzer: libFuzzer_skia_image_filter_proto_fuzzer
Job Type: libfuzzer_chrome_msan
Platform Id: linux

Crash Type: Null-dereference READ
Crash Address: 0x000000000020
Crash State:
  CacheImpl::removeInternal
  CacheImpl::purgeByImageFilter
  SkImageFilter::~SkImageFilter
  
Sanitizer: memory (MSAN)

Regressed: https://clusterfuzz.com/revisions?job=libfuzzer_chrome_msan&range=559651:559657
Fixed: https://clusterfuzz.com/revisions?job=libfuzzer_chrome_msan&range=559927:559991

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=6037917240393728

See https://chromium.googlesource.com/chromium/src/+/master/testing/libfuzzer/reference.md for more information.

If you suspect that the result above is incorrect, try re-doing that job on the test case report page.
Project Member

Comment 5 by ClusterFuzz, May 19 2018

Labels: ClusterFuzz-Verified
Status: Verified (was: Untriaged)
ClusterFuzz testcase 6037917240393728 is verified as fixed, so closing issue as verified.

If this is incorrect, please add ClusterFuzz-Wrong label and re-open the issue.
Most likely this was fixed by:

https://skia-review.googlesource.com/c/skia/+/129165 (Fix bugs related to SkMatrixConvolutionImageFilter in repeat mode)

and

https://skia-review.googlesource.com/c/skia/+/129184 (
Fix fuzzer bug i.e., compute the correct repeated dst domain)

Sign in to add a comment