New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 844299 link

Starred by 3 users
Status: Fixed
Owner:
bajones@chromium.org
Closed: Jul 2
Cc:
█ offenwanger@chromium.org
btebbs@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Android , Windows
Pri: 2
Type: Feature
Proj-XR

Blocking:
issue 864810



Sign in to add a comment

Update WebXR's framebufferScaleFactor to match new definition

Project Member Reported by bajones@chromium.org, May 18 2018 
The meaning of framebufferScaleFactor was just updated in the WebXR explainer (https://github.com/immersive-web/webxr/pull/353) and will soon be reflected in the spec. Chrome needs to update it's implementation to match the new definition, as well as expose the new XRWebGLLayer.getNativeFramebufferScaleFactor function.

Comment 1 by ddorwin@chromium.org, May 18 2018

Labels: -Pri-3 WebXR-69 M-69 Pri-2

Comment 2 Deleted

Project Member

Comment 3 by bugdroid1@chromium.org, Jun 26 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a7f7ecaa558a00c82f741e15c218703d8c320311

commit a7f7ecaa558a00c82f741e15c218703d8c320311
Author: Brandon Jones <bajones@chromium.org>
Date: Tue Jun 26 00:12:45 2018

Updated XRWebGLLayer framebuffer scaling to match latest spec

Bug:  844299 
Change-Id: I73aa4e92c0f56377a2f012f5a6224cb5335d495c
Reviewed-on: https://chromium-review.googlesource.com/1112735
Commit-Queue: Brandon Jones <bajones@chromium.org>
Reviewed-by: Brian Sheedy <bsheedy@chromium.org>
Reviewed-by: Klaus Weidner <klausw@chromium.org>
Cr-Commit-Position: refs/heads/master@{#570254}
[modify] https://crrev.com/a7f7ecaa558a00c82f741e15c218703d8c320311/third_party/WebKit/LayoutTests/webexposed/global-interface-listing-expected.txt
[add] https://crrev.com/a7f7ecaa558a00c82f741e15c218703d8c320311/third_party/WebKit/LayoutTests/xr/xrWebGLLayer_framebuffer_scale.html
[modify] https://crrev.com/a7f7ecaa558a00c82f741e15c218703d8c320311/third_party/blink/renderer/modules/xr/xr_session.cc
[modify] https://crrev.com/a7f7ecaa558a00c82f741e15c218703d8c320311/third_party/blink/renderer/modules/xr/xr_session.h
[modify] https://crrev.com/a7f7ecaa558a00c82f741e15c218703d8c320311/third_party/blink/renderer/modules/xr/xr_webgl_layer.cc
[modify] https://crrev.com/a7f7ecaa558a00c82f741e15c218703d8c320311/third_party/blink/renderer/modules/xr/xr_webgl_layer.h
[modify] https://crrev.com/a7f7ecaa558a00c82f741e15c218703d8c320311/third_party/blink/renderer/modules/xr/xr_webgl_layer.idl
[modify] https://crrev.com/a7f7ecaa558a00c82f741e15c218703d8c320311/third_party/blink/renderer/modules/xr/xr_webgl_layer_init.idl

Comment 4 by ddorwin@chromium.org, Jun 28 2018

Owner: bajones@chromium.org
Status: Started (was: Available)
Fixed?

Comment 5 by bajones@chromium.org, Jul 2

Status: Fixed (was: Started)

Comment 6 by btebbs@chromium.org, Jul 4

Components: Blink>WebXR

Comment 7 by ddorwin@chromium.org, Jul 17

Blocking: 864810
►

Sign in to add a comment