New issue
Advanced search Search tips

Issue 844284 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Jun 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 1
Type: Task



Sign in to add a comment

UX Request: Visual Effects for TableViews.

Project Member Reported by sczs@chromium.org, May 18 2018

Issue description

We've previously had some discussion about VisualEffects and how to use them in the new Tables, Navigation Controllers (Top bar) and Toolbar (bottom bar). I'm creating this bug so we can continue the discussion here.

I've updated the POC CL to match the tableView background visual effect to the one on ToolsMenu, which uses UIBlurEffectStyleExtraLight and a white background with 0.65 opacity. 
Also, the History NavController, Toolbar and TableHeaders are all using the same Visual effect with UIBlurEffectStyleExtraLight

Please use the latest patchset (4) from https://chromium-review.googlesource.com/c/chromium/src/+/1044760 and let me know how it feels/looks.

 
Thanks Sergio! 

I think the VisualEffects matching the ToolsMenu is the right way to go.

I'm seeing some subtle color flickering behind the navbar when I scroll. I'm not sure if this is my simulator, or due to a double VisualEffects performance issue. 

@Pete, you've ran into this before as well right?


To follow up on yesterday's discussion about the VisualEffect on the bottom bar. I'm happy how this looks, even when there is no content scrolling behind. You can enable the Visual Effect for all bottom toolbars, regardless of the number of cells. 

I wont be able to patch and test until Monday.
Cc: pschaffner@chromium.org
Owner: martijnb@chromium.org
Status: Assigned (was: Untriaged)

Comment 5 by sczs@chromium.org, May 18 2018

I think we should definitely try on device first since the simulator its not usually good at these kind of things.

You can also try playing with  Debug>Graphics Quality Override on the simulator to see if that helps. We shouldn't make any assumptions based on how it looks in simulator.

Great to hear that about the Toolbar, will make a lot of things much easier :) Looking forward on hearing the rest of your feedback!

Comment 6 by sczs@chromium.org, May 23 2018

I will start working on this soon, so I wanted to check if you had time to give it a look on device :)

Also, adding an image of how the last POC looks like:
https://drive.google.com/open?id=1WcOFRQVIJnumY1PD3OUPU3725565uT2f
Hey Sergio, 

I just had a chance to check it on a device. 

On a device I think the tableView background visualEffect, especially combined with the section headers looking different, it gets too noisy.

So with Pete I decided to disable the visualEffect on the tableView background on all collections. We will go for opaque #fafafa instead. 

We will keep the visualEffects on the toolbars and section headers, but could you make sure their background color is #fafafa as well?

I know that the padding tweaks are on your planning (e.g. last cell gets extra padding), but it is related to the visualEffect changes, because seeing this in action will help me to see if the Recent Tabs will be easier to process. Now it feels a bit too tight. 

Let me know if this works for you. :) 

Comment 8 by sczs@chromium.org, May 23 2018

Thanks for the feedback Martijn!

I'll start working on those 2 things soon so you can take a look!
Owner: sczs@chromium.org
Any updates on this? 

Assigning this to sczs

Comment 10 by sczs@chromium.org, Jun 26 2018

Status: Fixed (was: Assigned)
These have been added already. Closing the bug

Sign in to add a comment