Remove Analytics from Files App |
|||
Issue descriptionUsing Google Analytics is causing problems when connectivity is poor (e.g. issue 842880 ). Since we don't even look at the results, let's remove it from the code.
,
May 18 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/25af83ddf8c991a6adeee3d05dfb0c06a1cd6d64 commit 25af83ddf8c991a6adeee3d05dfb0c06a1cd6d64 Author: Sasha Morrissey <sashab@chromium.org> Date: Fri May 18 06:56:00 2018 Disable Google Analytics in the File Manager This is a small fix that disables Google Analytics in the File Manager by removing the call to resolve the callback. Calling the Deferred object in any way causes an XHR request that causes the file picker to turn white, so not calling it leaves the Filter unresolved which means the Analytics server is never contacted (and hence the bug doesn't happen). Bug: 842880 , 844280 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: Ie525a88689985d2df1028fc1ba87f954fe158caf Reviewed-on: https://chromium-review.googlesource.com/1065530 Commit-Queue: Sasha Morrissey <sashab@chromium.org> Reviewed-by: Joel Hockey <joelhockey@chromium.org> Cr-Commit-Position: refs/heads/master@{#559818} [modify] https://crrev.com/25af83ddf8c991a6adeee3d05dfb0c06a1cd6d64/chrome/browser/chromeos/file_manager/file_manager_jstest.cc [modify] https://crrev.com/25af83ddf8c991a6adeee3d05dfb0c06a1cd6d64/ui/file_manager/file_manager/common/js/metrics.js
,
May 18 2018
Confirmed that it makes sense to disable Google Analytics. Should we create a bug to track replacement UMAs for Cloud Import? Thanks Sasha!!
,
May 19 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ebe9aac2c553a0e21ad584fcc8217d0524967884 commit ebe9aac2c553a0e21ad584fcc8217d0524967884 Author: Sasha Morrissey <sashab@chromium.org> Date: Sat May 19 02:09:09 2018 Disable Google Analytics in the File Manager This is a small fix that disables Google Analytics in the File Manager by removing the call to resolve the callback. Calling the Deferred object in any way causes an XHR request that causes the file picker to turn white, so not calling it leaves the Filter unresolved which means the Analytics server is never contacted (and hence the bug doesn't happen). Tbr: joelhockey@chromium.org Bug: 842880 , 844280 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: Ie525a88689985d2df1028fc1ba87f954fe158caf Reviewed-on: https://chromium-review.googlesource.com/1065530 Commit-Queue: Sasha Morrissey <sashab@chromium.org> Reviewed-by: Joel Hockey <joelhockey@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#559818}(cherry picked from commit 25af83ddf8c991a6adeee3d05dfb0c06a1cd6d64) Reviewed-on: https://chromium-review.googlesource.com/1065692 Reviewed-by: Sasha Morrissey <sashab@chromium.org> Cr-Commit-Position: refs/branch-heads/3396@{#652} Cr-Branched-From: 9ef2aa869bc7bc0c089e255d698cca6e47d6b038-refs/heads/master@{#550428} [modify] https://crrev.com/ebe9aac2c553a0e21ad584fcc8217d0524967884/chrome/browser/chromeos/file_manager/file_manager_jstest.cc [modify] https://crrev.com/ebe9aac2c553a0e21ad584fcc8217d0524967884/ui/file_manager/file_manager/common/js/metrics.js
,
May 21 2018
Yup; removing analytics properly & replacing the UMAs it measured is being tracked in issue 646705 . |
|||
►
Sign in to add a comment |
|||
Comment 1 by sashab@chromium.org
, May 18 2018