Hi kylixrd, can you help triage this?

Thanks!

 Issue 844551  has been merged into this issue.

This change was made intentionally in https://crrev.com/c/1062810.

I think this is an interim state. Per the following spec, the background being white is correct, but it's also supposed to have a blue border.

https://gallery.googleplex.com/projects/MCHbtQVoQ2HCZbNPZ-X7_AcC/files/MCHtA7U1iMGr64M5oxfYF1G5r0OkZqC0_MY

Assigning to tommycli to confirm.

Indeed this is an intentional change. 

pkasting@ and I determined that this was a safe change that this can apply to Touchable flag as well.

We will be sure to also add the Blue Border.

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/be652b796af75662f2d0dc64e152d8c90b14f271

commit be652b796af75662f2d0dc64e152d8c90b14f271
Author: Tommy C. Li <tommycli@chromium.org>
Date: Wed May 30 20:30:01 2018

Omnibox UI Refresh: Always show the focus ring when focused

Previously, we only showed the focus ring on certain platforms (Mac) or
keyboard accessibility mode.

Now, following the new Material Refresh guidelines, we display the focus
ring on the Omnibox whenever it is focused (and the popup is hidden).

This also simplifies the code a bit, as keyboard accessibility mode is
no longer relevant.

Bug:  844263 ,  823535 
Change-Id: Ic5133463f6e67af5ef6f0512034938e4a19a9972
Reviewed-on: https://chromium-review.googlesource.com/1069690
Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Tommy Li <tommycli@chromium.org>
Cr-Commit-Position: refs/heads/master@{#562979}
[modify] https://crrev.com/be652b796af75662f2d0dc64e152d8c90b14f271/chrome/browser/ui/views/location_bar/location_bar_view.cc
[modify] https://crrev.com/be652b796af75662f2d0dc64e152d8c90b14f271/chrome/browser/ui/views/location_bar/location_bar_view.h
[modify] https://crrev.com/be652b796af75662f2d0dc64e152d8c90b14f271/chrome/browser/ui/views/toolbar/toolbar_view.cc
[modify] https://crrev.com/be652b796af75662f2d0dc64e152d8c90b14f271/chrome/browser/ui/views/toolbar/toolbar_view.h
[modify] https://crrev.com/be652b796af75662f2d0dc64e152d8c90b14f271/ui/views/controls/focus_ring.cc
[modify] https://crrev.com/be652b796af75662f2d0dc64e152d8c90b14f271/ui/views/controls/focus_ring.h

Issue 847900 has been merged into this issue.

Should we merge #c5 to m68 for ChromeOS tablets?

tapted: I don't have a strong opinion. It's meant to implement the Material Refresh style launching in M69.

Is there a reason ChromeOS tablets would benefit from it in M68? If so, I don't object, and feel free to request a merge.

ChromeOS Tablets use the rounded omnibox style since m67. When those devices update to m68, they will pick up r559620, and they will get this bug. (right?)

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/479e0af586ef7a0b0770312a9f03a13aa72910c2

commit 479e0af586ef7a0b0770312a9f03a13aa72910c2
Author: Tommy C. Li <tommycli@chromium.org>
Date: Fri Jun 01 21:50:31 2018

Omnibox UI Refresh: Fix legacy focus ring for keyboard accessibility

Previously we displayed a legacy focus ring if Material Refresh was off
for full keyboard accessibilty mode on all platforms.

The CL below accidentally removed it:
https://chromium-review.googlesource.com/c/chromium/src/+/1069690

Now we are adding it back with a partial revert - and a refactor to
make the logic overall more clear. We can remove everything we are
adding in this CL once Material Refresh is permanent and launched.

Bug:  848641 ,  844263 ,  823535 
Change-Id: Ife78cd9660e38f16525b55044ee0a231101534a6
Reviewed-on: https://chromium-review.googlesource.com/1082794
Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Tommy Li <tommycli@chromium.org>
Cr-Commit-Position: refs/heads/master@{#563814}
[modify] https://crrev.com/479e0af586ef7a0b0770312a9f03a13aa72910c2/chrome/browser/ui/views/location_bar/location_bar_view.cc
[modify] https://crrev.com/479e0af586ef7a0b0770312a9f03a13aa72910c2/chrome/browser/ui/views/location_bar/location_bar_view.h
[modify] https://crrev.com/479e0af586ef7a0b0770312a9f03a13aa72910c2/chrome/browser/ui/views/toolbar/toolbar_view.cc
[modify] https://crrev.com/479e0af586ef7a0b0770312a9f03a13aa72910c2/chrome/browser/ui/views/toolbar/toolbar_view.h

I probably mistook #c11 for a merge and didn't nag hard enough. tommycli: please assess and merge.

My apologies. Requesting a Merge for both c#5 and c#11 now.

Thanks.

This bug requires manual review: M68 has already been promoted to the beta branch, so this requires manual review
Please contact the milestone owner if you have questions.
Owners: cmasso@(Android), kariahda@(iOS), bhthompson@(ChromeOS), abdulsyed@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e41d3cc0b23587b7dde5ebad20a69227b341de28

commit e41d3cc0b23587b7dde5ebad20a69227b341de28
Author: Tommy C. Li <tommycli@chromium.org>
Date: Tue Jun 26 23:56:49 2018

[Merge to M68] Omnibox UI Refresh: Always show the focus ring when focused

This merge comprises of the following two CLs together, since the
intermediate state is broken:

Omnibox UI Refresh: Always show the focus ring when focused

Previously, we only showed the focus ring on certain platforms (Mac) or
keyboard accessibility mode.

Now, following the new Material Refresh guidelines, we display the focus
ring on the Omnibox whenever it is focused (and the popup is hidden).

This also simplifies the code a bit, as keyboard accessibility mode is
no longer relevant.

Bug:  844263 ,  823535 
Change-Id: Ic5133463f6e67af5ef6f0512034938e4a19a9972
Reviewed-on: https://chromium-review.googlesource.com/1069690
Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Tommy Li <tommycli@chromium.org>
Cr-Commit-Position: refs/heads/master@{#562979}

(cherry picked from commit be652b796af75662f2d0dc64e152d8c90b14f271)

Omnibox UI Refresh: Fix legacy focus ring for keyboard accessibility

Previously we displayed a legacy focus ring if Material Refresh was off
for full keyboard accessibilty mode on all platforms.

The CL below accidentally removed it:
https://chromium-review.googlesource.com/c/chromium/src/+/1069690

Now we are adding it back with a partial revert - and a refactor to
make the logic overall more clear. We can remove everything we are
adding in this CL once Material Refresh is permanent and launched.

(cherry picked from commit 479e0af586ef7a0b0770312a9f03a13aa72910c2)

Bug:  848641 ,  844263 ,  823535 
Change-Id: Ife78cd9660e38f16525b55044ee0a231101534a6
Reviewed-on: https://chromium-review.googlesource.com/1082794
Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Tommy Li <tommycli@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#563814}
Reviewed-on: https://chromium-review.googlesource.com/1115432
Reviewed-by: Tommy Li <tommycli@chromium.org>
Reviewed-by: Justin Donnelly <jdonnelly@chromium.org>
Cr-Commit-Position: refs/branch-heads/3440@{#543}
Cr-Branched-From: 010ddcfda246975d194964ccf20038ebbdec6084-refs/heads/master@{#561733}
[modify] https://crrev.com/e41d3cc0b23587b7dde5ebad20a69227b341de28/chrome/browser/ui/views/location_bar/location_bar_view.cc
[modify] https://crrev.com/e41d3cc0b23587b7dde5ebad20a69227b341de28/chrome/browser/ui/views/location_bar/location_bar_view.h
[modify] https://crrev.com/e41d3cc0b23587b7dde5ebad20a69227b341de28/chrome/browser/ui/views/toolbar/toolbar_view.cc
[modify] https://crrev.com/e41d3cc0b23587b7dde5ebad20a69227b341de28/ui/views/controls/focus_ring.cc
[modify] https://crrev.com/e41d3cc0b23587b7dde5ebad20a69227b341de28/ui/views/controls/focus_ring.h

shend: can you confirm that this is Fixed?

Looks fixed in Chrome 68 Beta.