New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 844261 link

Starred by 1 user
Status: Fixed
Owner:
gan...@chromium.org
Closed: May 2018
Cc:
█ kbr@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 1
Type: Bug

Blocked on:
issue 843842


Sign in to add a comment

Presubmit generate_buildbot_json_unittest.py does not work on Windows

Project Member Reported by gan...@chromium.org, May 18 2018 
The comparison in generate_buildbot_json_unittest.py is looking for forward slashes v/s backslashes on Windows, causing a presubmit error at line 22: KeyError: '..\\..\\infra\\config\\global\\luci-milo.cfg'.

Comment 1 by kbr@chromium.org, May 18 2018

Blockedon: 843842

Comment 2 by kbr@chromium.org, May 18 2018

Cc: kbr@chromium.org
Components: Tools>Test
Labels: OS-Windows
Project Member

Comment 3 by bugdroid1@chromium.org, May 18 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/808efbb28c52cb8077f2a07fe471fc5c92fe8691

commit 808efbb28c52cb8077f2a07fe471fc5c92fe8691
Author: S. Ganesh <ganesh@chromium.org>
Date: Fri May 18 01:29:33 2018

Fix generate_buildbot_json_unittest.py to work on Windows.

The comparison in generate_buildbot_json_unittest.py was looking
for forward slashes v/s backslashes on Windows, causing a
presubmit error at line 22:
KeyError: '..\\..\\infra\\config\\global\\luci-milo.cfg'.

Bug:  844261 
Change-Id: I14418248409d58a451d9bd0520f24fcc50d27a2a
Reviewed-on: https://chromium-review.googlesource.com/1064475
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Commit-Queue: Kenneth Russell <kbr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#559761}
[modify] https://crrev.com/808efbb28c52cb8077f2a07fe471fc5c92fe8691/testing/buildbot/generate_buildbot_json_unittest.py

Comment 4 by kbr@chromium.org, May 18 2018

Status: Fixed (was: Assigned)
►

Sign in to add a comment