Issue metadata
Sign in to add a comment
|
When ONC network connection auth fails, the Join Wi-fi network dialog is not displaying the policy configured credentials |
||||||||||||||||||||||
Issue descriptionChrome Version: M68.0.3432.0 OS: ChromeOS 10684.0.0 dev paine What steps will reproduce the problem? (1) On Cpanel > Device management > Networks > Wi-Fi, configure an ONC WPA/WPA2 Enterprise (802.1X) PEAP or Dynamic WEP network user policy that requires username and password. Make sure the credential is incorrectly so that connection will fail. (2) Sign in user in that OU with the network policy defined in (1). (3) Connect to that network mentioned in (1). Connection failed and a Join Wi-Fi network dialog appears. What is the expected result? The policy credentials are be displayed in the Join Wi-Fi network dialog. What happens instead? Blanks where the values of the policy credentials should be displayed. In M66/67, the policy credential values are displayed instead of being blank in M68. Screenshots attached.
,
May 18 2018
,
May 21 2018
+hcarmona@ - This appears to be a side effect of: https://chromium-review.googlesource.com/1015644 It appears that value="{{value::input}}" is not working as expected when wrapped in an <iron-input>. Specifically, |value| is not showing up in the <input> value. I'll see if I can figure out why, but any thoughts or suggestions would be appreciated.
,
May 21 2018
It looks like a bunch of places in the network config UI are currently broken.
,
May 21 2018
Looks like we need to use bind-value in iron-input: https://www.webcomponents.org/element/PolymerElements/iron-input
,
May 21 2018
@stevenjb: Does the fix basically look like the follwing (from the same CL you linked)? https://chromium-review.googlesource.com/c/chromium/src/+/1015644/21/chrome/browser/resources/pdf/elements/viewer-page-selector/viewer-page-selector.html
,
May 21 2018
Yes. I did a (quickish) audit and it appears that bind-value was only missing from the cr_components/network changes.
Also, I discovered that value="{{value::input}}" is only required in the <input> element where 'input' events are required. i.e. normally value="{{value}}" can be omitted from the <input> element.
CL FYI: https://chromium-review.googlesource.com/c/chromium/src/+/1067840
,
May 21 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d286b4041c978e38b8c5618f2212611ce9337a71 commit d286b4041c978e38b8c5618f2212611ce9337a71 Author: Steven Bennetts <stevenjb@chromium.org> Date: Mon May 21 22:39:20 2018 Settings: Network: Fix inputs for polymer2 The Polymer2 conversion of iron-input broke network config inputs: https://chromium-review.googlesource.com/c/chromium/src/+/1015644 This fixes them by using bind-value as described here: https://www.webcomponents.org/element/PolymerElements/iron-input Bug: 844259 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I8ccc88d003cd04fca56eb2d86e2bc69654d7c896 Reviewed-on: https://chromium-review.googlesource.com/1067840 Reviewed-by: Hector Carmona <hcarmona@chromium.org> Commit-Queue: Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#560384} [modify] https://crrev.com/d286b4041c978e38b8c5618f2212611ce9337a71/ui/webui/resources/cr_components/chromeos/network/network_config_input.html [modify] https://crrev.com/d286b4041c978e38b8c5618f2212611ce9337a71/ui/webui/resources/cr_components/chromeos/network/network_nameservers.html [modify] https://crrev.com/d286b4041c978e38b8c5618f2212611ce9337a71/ui/webui/resources/cr_components/chromeos/network/network_property_list.html [modify] https://crrev.com/d286b4041c978e38b8c5618f2212611ce9337a71/ui/webui/resources/cr_components/chromeos/network/network_proxy.html [modify] https://crrev.com/d286b4041c978e38b8c5618f2212611ce9337a71/ui/webui/resources/cr_components/chromeos/network/network_proxy_input.html
,
May 21 2018
The primary issue should be fixed in the next update. There was a question about how macro expansion should be handled in the email thread (visible in the 67.0 screenshot), but that should be addressed as a separate issue.
,
May 25 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/48ab25f7683632b99e21ba42b0f6e29b85857bef commit 48ab25f7683632b99e21ba42b0f6e29b85857bef Author: Steven Bennetts <stevenjb@chromium.org> Date: Fri May 25 01:18:30 2018 Fix internet dialog styling for Polymer2 This moves the paper-input-container styling to the network components so that it applies consistently in Settings and in dialogs. It also includes some other minor fixes and adds styling to each dialog to match Settings (primarily for line-height). Bug: 844259 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: Ice417ced7cd3758c8270cfc00a221aa4b15fe466 Reviewed-on: https://chromium-review.googlesource.com/1072235 Reviewed-by: Hector Carmona <hcarmona@chromium.org> Commit-Queue: Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#561722} [modify] https://crrev.com/48ab25f7683632b99e21ba42b0f6e29b85857bef/chrome/browser/resources/chromeos/bluetooth_pairing_dialog/bluetooth_pairing_dialog.html [modify] https://crrev.com/48ab25f7683632b99e21ba42b0f6e29b85857bef/chrome/browser/resources/chromeos/internet_config_dialog/internet_config_dialog.html [modify] https://crrev.com/48ab25f7683632b99e21ba42b0f6e29b85857bef/chrome/browser/resources/chromeos/internet_detail_dialog/internet_detail_dialog.html [modify] https://crrev.com/48ab25f7683632b99e21ba42b0f6e29b85857bef/chrome/browser/resources/settings/internet_page/internet_shared_css.html [modify] https://crrev.com/48ab25f7683632b99e21ba42b0f6e29b85857bef/chrome/browser/resources/settings/settings_ui/settings_ui.html [modify] https://crrev.com/48ab25f7683632b99e21ba42b0f6e29b85857bef/ui/webui/resources/cr_components/chromeos/network/network_nameservers.html [modify] https://crrev.com/48ab25f7683632b99e21ba42b0f6e29b85857bef/ui/webui/resources/cr_components/chromeos/network/network_property_list.html [modify] https://crrev.com/48ab25f7683632b99e21ba42b0f6e29b85857bef/ui/webui/resources/cr_components/chromeos/network/network_proxy_input.html [modify] https://crrev.com/48ab25f7683632b99e21ba42b0f6e29b85857bef/ui/webui/resources/cr_components/chromeos/network/network_shared_css.html [modify] https://crrev.com/48ab25f7683632b99e21ba42b0f6e29b85857bef/ui/webui/resources/cr_elements/shared_vars_css.html
,
May 25 2018
Assuming that 68 branched before this landed.
,
May 25 2018
Oops, the patch in comment #10 was supposed to be for issue 845126 . Copy/pasting.
,
May 31 2018
Verified fixed in M68.0.3440.9 10718.7.0 dev paine. The configured credentials are now displayed as expected. |
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by jingwee@chromium.org
, May 18 2018