New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 844257 link

Starred by 2 users

Issue metadata

Status: Verified
Owner:
Last visit 19 days ago
Closed: May 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 1
Type: Bug



Sign in to add a comment

CHECK failure: packets_acked_.empty() in quic_sent_packet_manager.cc

Project Member Reported by ClusterFuzz, May 18 2018

Issue description

Detailed report: https://clusterfuzz.com/testcase?key=6561313363591168

Fuzzer: libFuzzer_net_quic_stream_factory_fuzzer
Job Type: libfuzzer_chrome_asan_debug
Platform Id: linux

Crash Type: CHECK failure
Crash Address: 
Crash State:
  packets_acked_.empty() in quic_sent_packet_manager.cc
  net::QuicSentPacketManager::OnAckFrameStart
  net::QuicConnection::OnAckFrameStart
  
Sanitizer: address (ASAN)

Regressed: https://clusterfuzz.com/revisions?job=libfuzzer_chrome_asan_debug&range=559600:559619

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=6561313363591168

Issue filed automatically.

See https://chromium.googlesource.com/chromium/src/+/master/testing/libfuzzer/reference.md for more information.
 
Project Member

Comment 1 by ClusterFuzz, May 18 2018

Components: Internals>Network
Labels: Test-Predator-Auto-Components
Automatically applying components based on crash stacktrace and information from OWNERS files.

If this is incorrect, please apply the Test-Predator-Wrong-Components label.
Project Member

Comment 2 by ClusterFuzz, May 18 2018

Cc: nedwilli...@gmail.com
Labels: ClusterFuzz-Auto-CC
Automatically adding ccs based on OWNERS file / target commit history.

If this is incorrect, please add ClusterFuzz-Wrong label.
Project Member

Comment 3 by ClusterFuzz, May 18 2018

Labels: Test-Predator-Auto-Owner
Owner: vasilvv@chromium.org
Status: Assigned (was: Untriaged)
Automatically assigning owner based on suspected regression changelist https://chromium.googlesource.com/chromium/src/+/71846d6cfa545bdfebbc7d81af253e6675708d52 (Landing Recent QUIC changes until Sun May 13 12:53:34 2018 +0000).

If this is incorrect, please let us know why and apply the Test-Predator-Wrong-CLs label. If you aren't the correct owner for this issue, please unassign yourself as soon as possible so it can be re-triaged.
Cc: vasilvv@chromium.org rch@chromium.org
Owner: fayang@chromium.org
I suspect it's either CL 195977538 or CL 195684113, since they seem to be the only ones which potentially interact with ack logic.  Fan, could you take a look when you have cycles?

Comment 5 by fayang@chromium.org, May 25 2018

On it now. Thanks, Victor!
Project Member

Comment 6 by bugdroid1@chromium.org, May 30 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7162d65903150611b23523141e32d377b7e64b29

commit 7162d65903150611b23523141e32d377b7e64b29
Author: Fan Yang <fayang@chromium.org>
Date: Wed May 30 15:07:33 2018

In QUIC, close connection if received a new ack while processing an ack frame. Protected by ENABLED quic_reloadable_flag_quic_use_incremental_ack_processing4.

Merge internal change: 198394989

R=rch@chromium.org

Bug:  844257 
Change-Id: I45966ad7bf4d29b8df643409c4af3d8095554662
Reviewed-on: https://chromium-review.googlesource.com/1076591
Reviewed-by: Ryan Hamilton <rch@chromium.org>
Commit-Queue: Fan Yang <fayang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#562826}
[modify] https://crrev.com/7162d65903150611b23523141e32d377b7e64b29/net/third_party/quic/core/quic_connection.cc
[modify] https://crrev.com/7162d65903150611b23523141e32d377b7e64b29/net/third_party/quic/core/quic_connection.h

Comment 7 by fayang@chromium.org, May 30 2018

Status: Fixed (was: Assigned)
Project Member

Comment 8 by ClusterFuzz, May 31 2018

ClusterFuzz has detected this issue as fixed in range 562811:562827.

Detailed report: https://clusterfuzz.com/testcase?key=6561313363591168

Fuzzer: libFuzzer_net_quic_stream_factory_fuzzer
Job Type: libfuzzer_chrome_asan_debug
Platform Id: linux

Crash Type: CHECK failure
Crash Address: 
Crash State:
  packets_acked_.empty() in quic_sent_packet_manager.cc
  net::QuicSentPacketManager::OnAckFrameStart
  net::QuicConnection::OnAckFrameStart
  
Sanitizer: address (ASAN)

Regressed: https://clusterfuzz.com/revisions?job=libfuzzer_chrome_asan_debug&range=559600:559619
Fixed: https://clusterfuzz.com/revisions?job=libfuzzer_chrome_asan_debug&range=562811:562827

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=6561313363591168

See https://chromium.googlesource.com/chromium/src/+/master/testing/libfuzzer/reference.md for more information.

If you suspect that the result above is incorrect, try re-doing that job on the test case report page.
Project Member

Comment 9 by ClusterFuzz, May 31 2018

Labels: ClusterFuzz-Verified
Status: Verified (was: Fixed)
ClusterFuzz testcase 6561313363591168 is verified as fixed, so closing issue as verified.

If this is incorrect, please add ClusterFuzz-Wrong label and re-open the issue.

Sign in to add a comment