New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 844239 link

Starred by 1 user

Issue metadata

Status: WontFix
Owner:
Last visit > 30 days ago
Closed: May 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 2
Type: Bug



Sign in to add a comment

Shadows in videos do not look correct

Reported by grant...@gmail.com, May 17 2018

Issue description

UserAgent: Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/66.0.3359.170 Safari/537.36

Example URL:
https://www.youtube.com/watch?v=IOEfJ7oqSK8&t=45s

Steps to reproduce the problem:
Watch a video (is more noticeable in certain videos than others; I suggest the Example URL video).  Note that certain color values show up brighter than they are supposed to be.  It appears to be mainly the shadows.

What is the expected behavior? / What went wrong?
Refer to linked screenshots; the Chrome screenshot looks very wrong compared to the Firefox version.

Did this work before? I vaguely remember this problematic rendering being around for a while.

Is it a problem with Flash or HTML5? I assume that this is an HTML5 issue as the video playback is not using Flash.

Does this work in other browsers? Yes; Firefox appears to get this right.

Chrome version: 66.0.3359.170  Channel: stable
OS Version: Ubuntu 16.04.4 LTS
Flash Version: N/A

Contents of chrome://gpu: 
Omitted due to "Comment is too long" error message.  Reproduced here: https://pastebin.com/raw/nkgWY9zg

Note: One can download the video from YouTube with youtube-dl to isolate the problem to Chrome's media playback specifically.

 
Firefox.png
1.2 MB View Download
Chrome.png
1.7 MB View Download
Does not repro on 66.0.3359.158 on sentry chromebook.
Cc: hubbe@chromium.org

Comment 3 by hubbe@chromium.org, May 17 2018

Cc: -hubbe@chromium.org
Owner: hubbe@chromium.org
Status: Started (was: Unconfirmed)
Your "about:gpu" says that you have a color profile installed with a pure gamma 2.2. With a true gamma 2.2 monitor, the first few values all produce *very* little light. (The "1" value is only 0.000005 as bright as "255".) Since the "1" value in the video is meant to be brighter than this, chrome will translate the "1" value in the video to the output value that is closest to the right brightness, which is probably "6".

If your monitor really is a gamma 2.2 monitor, this should be correct.
Unfortunately, it's likely that your monitor is not in fact a true gamma 2.2 monitor, but instead uses a gamma function which is close to 2.2, but has a flat region at the bottom. This means that the "6" value that chrome outputs doesn't produce the brightness that chrome expects. (Based on your ICC profile.)

Could you let us know what monitor and color profile you are using?

Comment 4 by grant...@gmail.com, May 17 2018

I'm using an LG 27UD58-B.

I've attached the .icc that I'm using.  It does appear to have a flat region at the bottom, according to the GNOME utility.
edid-e3da03028f8abca404ffea6bf3e49950.icc
1.5 KB Download

Comment 5 by hubbe@chromium.org, May 17 2018

Cc: ccameron@chromium.org
Wonder if we're approximating the ICC profile wrong then?

Comment 6 by grant...@gmail.com, May 18 2018

It might be of note that I am using a Dell XPS 13 9350, with this monitor attached as an external monitor.  Should I also upload the 9350 .icc as well?

Also I'm pulling the .icc from what the GNOME 3 Color dialogue says.  Is there a more authoritative place I should be pulling it from?

Comment 7 by hubbe@chromium.org, May 18 2018

The gnome color dialogue should be fine I think.
Chrome will read the ICC profile from X properties set on the root window, so you could look there, but there is no easy way to actually extract the data.
The second monitor thing may be part of the problem as until recently chrome would always use the color profile of the primary monitor on linux. (Fixed in version 67.0.3388.0 or later.) (Note that what you think is "primary" might not be what X11 think is "primary" though.)

Does the video look fine when you show it on the LG monitor and bad when you show it on the XPS monitor? (or vice versa?)

BTW, I looked at the ICC profile you uploaded in ICC Profile Inspector, and I don't see a flat region towards the bottom, which would mean that chrome is interpreting it correctly, unless I'm missing something.

I think the solution might be to find a better ICC profile for your monitor. Alternatively, you can go into about:flags in chrome and force an sRGB color profile.


Comment 8 by grant...@gmail.com, May 18 2018

Video looks wrong on both monitors.

I say that there seems to be a flat region towards the low end based on the TRC curve that GNOME Color is displaying.  Am I misinterpreting this graph/is it not actually relevant?

Screenshot from 2018-05-17 20-30-30.png
97.3 KB View Download

Comment 9 by hubbe@chromium.org, May 18 2018

That graph is weird. I don't know what it actually is trying to show us.
Possibly it's showing the difference between your profile and an sRGB profile.

This link shows how close sRGB and gamma 2.2 curves are:

 http://fooplot.com/#W3sidHlwZSI6MCwiZXEiOiJ4XjIuMiIsImNvbG9yIjoiIzFFMDBGRiJ9LHsidHlwZSI6MCwiZXEiOiIoeDw9MC4wNDA0NSkqeC8xMi45MisoeD4wLjA0MDQ1KSooKHgrMC4wNTUpLzEuMDU1KV4yLjQiLCJjb2xvciI6IiNGRjAwMDAifSx7InR5cGUiOjEwMDAsIndpbmRvdyI6WyItMCIsIjEiLCItMCIsIjEiXX1d

Note that if you zoom in near 0,0 you'll notice that the blue curve is really close to zero at the beginning, which is the effect you're seeing. Unfortunately, many monitor manufactures seem to view this as "close enough" for some reason.



Comment 10 by grant...@gmail.com, May 19 2018

Alright - I've forced an sRGB profile and it works around the issue.

It seems like the ICC profile I'm getting from EDID data (I think that's where it comes from?) is not great.  Once I own calibration tools I'll flip this workaround back off. 

Willing to mark as NOTABUG/whatever the equivalent is here.

Comment 11 by hubbe@chromium.org, May 21 2018

Status: WontFix (was: Started)
WAI, Working as Intended

Sign in to add a comment