New issue
Advanced search Search tips

Issue 844237 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: May 2018
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug



Sign in to add a comment

"AuraWindowVideoCaptureDeviceBrowserTestP.CapturesContentChanges/2" is flaky

Project Member Reported by chromium...@appspot.gserviceaccount.com, May 17 2018

Issue description

"AuraWindowVideoCaptureDeviceBrowserTestP.CapturesContentChanges/2" is flaky.

This issue was created automatically by the chromium-try-flakes app. Please find the right owner to fix the respective test/step and assign this issue to them. If the step/test is infrastructure-related, please add Infra-Troopers label and change issue status to Untriaged. When done, please remove the issue from Sheriff Bug Queue by removing the Sheriff-Chromium label.

We have detected 4 recent flakes. List of all flakes can be found at https://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9taXVtLXRyeS1mbGFrZXNyTAsSBUZsYWtlIkFBdXJhV2luZG93VmlkZW9DYXB0dXJlRGV2aWNlQnJvd3NlclRlc3RQLkNhcHR1cmVzQ29udGVudENoYW5nZXMvMgw.

Flaky tests should be disabled within 30 minutes unless culprit CL is found and reverted. Please see more details here: https://sites.google.com/a/chromium.org/dev/developers/tree-sheriffs/sheriffing-bug-queues#triaging-auto-filed-flakiness-bugs
 
Project Member

Comment 1 by bugdroid1@chromium.org, May 18 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8b201ee0215702f27a06203e6d5cb1beb5b2223a

commit 8b201ee0215702f27a06203e6d5cb1beb5b2223a
Author: Findit <findit-for-me@appspot.gserviceaccount.com>
Date: Fri May 18 00:47:28 2018

Revert "New Desktop/Browser Window screen capture impl, based on VIZ services."

This reverts commit b2afe0318cbb3c18ec0a456ea040c357149a64b8.

Reason for revert:

Findit (https://goo.gl/kROfz5) identified CL at revision 559371 as the
culprit for flakes in the build cycles as shown on:
https://findit-for-me.appspot.com/waterfall/flake/flake-culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyQwsSDEZsYWtlQ3VscHJpdCIxY2hyb21pdW0vYjJhZmUwMzE4Y2JiM2MxOGVjMGE0NTZlYTA0MGMzNTcxNDlhNjRiOAw

Sample Failed Build: https://ci.chromium.org/buildbot/tryserver.chromium.linux/linux_chromium_rel_ng/96258

Sample Failed Step: content_browsertests (with patch)

Sample Flaky Test: AuraWindowVideoCaptureDeviceBrowserTestP.CapturesContentChanges/2

Original change's description:
> New Desktop/Browser Window screen capture impl, based on VIZ services.
> 
> Adds content::AuraWindowVideoCaptureDevice, which provides screen
> capture of aura::Windows that have compositor frame sinks associated
> with them. Then, for Chrome OS browser window capture, where a CFS is
> not available, use a fall-back window capturer impl instead. The
> intention is for the LameWindowCapturerChromeOS to be a temporary
> solution until more work is complete on services/ui/ws (the new Window
> Service).
> 
> Note: This change does not activate the new impl yet. A follow-up
> change will switch from the legacy impl to the new impl.
> 
> Bug:  806366 
> Change-Id: Ia6aa81e4addde603b120a6ab61c5e35a0041b418
> Reviewed-on: https://chromium-review.googlesource.com/1006366
> Commit-Queue: Yuri Wiitala <miu@chromium.org>
> Reviewed-by: Antoine Labour <piman@chromium.org>
> Reviewed-by: Adam Parker <amp@chromium.org>
> Reviewed-by: Xiangjun Zhang <xjz@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#559371}

Change-Id: I6e3077a2589928ac33f0e6fe18b7a13f331be16a
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug:  806366 ,  844237 
Reviewed-on: https://chromium-review.googlesource.com/1065270
Cr-Commit-Position: refs/heads/master@{#559755}
[modify] https://crrev.com/8b201ee0215702f27a06203e6d5cb1beb5b2223a/content/browser/BUILD.gn
[delete] https://crrev.com/3f2dc028ad0011e5d68b17bf41870a9296181f28/content/browser/media/capture/aura_window_video_capture_device.cc
[delete] https://crrev.com/3f2dc028ad0011e5d68b17bf41870a9296181f28/content/browser/media/capture/aura_window_video_capture_device.h
[delete] https://crrev.com/3f2dc028ad0011e5d68b17bf41870a9296181f28/content/browser/media/capture/aura_window_video_capture_device_browsertest.cc
[modify] https://crrev.com/8b201ee0215702f27a06203e6d5cb1beb5b2223a/content/browser/media/capture/content_capture_device_browsertest_base.cc
[modify] https://crrev.com/8b201ee0215702f27a06203e6d5cb1beb5b2223a/content/browser/media/capture/content_capture_device_browsertest_base.h
[modify] https://crrev.com/8b201ee0215702f27a06203e6d5cb1beb5b2223a/content/browser/media/capture/frame_sink_video_capture_device.cc
[modify] https://crrev.com/8b201ee0215702f27a06203e6d5cb1beb5b2223a/content/browser/media/capture/frame_sink_video_capture_device.h
[modify] https://crrev.com/8b201ee0215702f27a06203e6d5cb1beb5b2223a/content/browser/media/capture/frame_sink_video_capture_device_unittest.cc
[delete] https://crrev.com/3f2dc028ad0011e5d68b17bf41870a9296181f28/content/browser/media/capture/lame_window_capturer_chromeos.cc
[delete] https://crrev.com/3f2dc028ad0011e5d68b17bf41870a9296181f28/content/browser/media/capture/lame_window_capturer_chromeos.h
[modify] https://crrev.com/8b201ee0215702f27a06203e6d5cb1beb5b2223a/content/browser/media/capture/web_contents_video_capture_device_browsertest.cc
[modify] https://crrev.com/8b201ee0215702f27a06203e6d5cb1beb5b2223a/content/test/BUILD.gn

Project Member

Comment 2 by Findit, May 18 2018

Labels: Test-Findit-Analyzed
Findit identified the culprit r559371 with confidence 100.0% in the config "tryserver.chromium.linux / linux_chromium_rel_ng"
based on the flakiness trend:

https://findit-for-me.appspot.com/waterfall/flake?key=ag9zfmZpbmRpdC1mb3ItbWVyxQELEhdNYXN0ZXJGbGFrZUFuYWx5c2lzUm9vdCKOAWNocm9taXVtLmxpbnV4L0xpbnV4IFRlc3RzLzY5OTY2L2NvbnRlbnRfYnJvd3NlcnRlc3RzL1FYVnlZVmRwYm1SdmQxWnBaR1Z2UTJGd2RIVnlaVVJsZG1salpVSnliM2R6WlhKVVpYTjBVQzVEWVhCMGRYSmxjME52Ym5SbGJuUkRhR0Z1WjJWekx6ST0MCxITTWFzdGVyRmxha2VBbmFseXNpcxgBDA


Automatically posted by the findit-for-me app (https://goo.gl/Ot9f7N).
Feedback is welcome! Please use component Tools>Test>FindIt>Flakiness

Comment 3 by st...@chromium.org, May 18 2018

Labels: -Sheriff-Chromium
Owner: m...@chromium.org
Status: Assigned (was: Untriaged)
miu@: assigned to you as you added the test.

Comment 4 by m...@chromium.org, May 18 2018

Status: Fixed (was: Assigned)
Resolved, with details explained in reland: https://chromium-review.googlesource.com/c/chromium/src/+/1066676

Sign in to add a comment