New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 844231 link

Starred by 1 user
Status: Fixed
Owner:
█ roc...@chromium.org
please use my google.com address
Closed: May 2018
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug

Blocking:
issue 844764
issue 844766



Sign in to add a comment

Mojo invitation API

Project Member Reported by roc...@chromium.org, May 17 2018 
Support for process invitations to bootstrap Mojo IPC should be migrated from unstable EDK C++ API into the stable C ABI, with other relevant support code (e.g. creating platform channel handles) also moving into the public support library.

Basic outline described in doc: https://docs.google.com/document/d/1-Xn2kx9_P0Giu5gwyWyo4eluxqc3E5lqdE-3BrP1pdU/edit#

Comment 1 by roc...@chromium.org, May 18 2018

Blocking: 844764

Comment 2 by roc...@chromium.org, May 18 2018

Blocking: 844766

Comment 3 by roc...@chromium.org, May 18 2018

Blocking: -822034
Project Member

Comment 4 by bugdroid1@chromium.org, May 19 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a523cf48c629d7327cde4a5f36098f47ad50a696

commit a523cf48c629d7327cde4a5f36098f47ad50a696
Author: Ken Rockot <rockot@chromium.org>
Date: Sat May 19 21:41:41 2018

Mojo: Invitation API

This is a public C API replacement for the EDK invitation API, i.e.
Incoming/OutgoingBrokerClientInvitation et al. Here the new C calls
are introduced and covered by unit tests.

See the associated bug and the bugs it's blocking for more context
and follow-up work.

Bug:  844231 
Change-Id: Iffa2e5b08eefbe3476430eb420efe2f52f4ad195
Reviewed-on: https://chromium-review.googlesource.com/1066807
Commit-Queue: Ken Rockot <rockot@chromium.org>
Reviewed-by: Jay Civelli <jcivelli@chromium.org>
Cr-Commit-Position: refs/heads/master@{#560164}
[modify] https://crrev.com/a523cf48c629d7327cde4a5f36098f47ad50a696/mojo/edk/BUILD.gn
[modify] https://crrev.com/a523cf48c629d7327cde4a5f36098f47ad50a696/mojo/edk/embedder/entrypoints.cc
[modify] https://crrev.com/a523cf48c629d7327cde4a5f36098f47ad50a696/mojo/edk/embedder/platform_handle_utils.cc
[modify] https://crrev.com/a523cf48c629d7327cde4a5f36098f47ad50a696/mojo/edk/embedder/platform_handle_utils.h
[modify] https://crrev.com/a523cf48c629d7327cde4a5f36098f47ad50a696/mojo/edk/system/BUILD.gn
[modify] https://crrev.com/a523cf48c629d7327cde4a5f36098f47ad50a696/mojo/edk/system/core.cc
[modify] https://crrev.com/a523cf48c629d7327cde4a5f36098f47ad50a696/mojo/edk/system/core.h
[modify] https://crrev.com/a523cf48c629d7327cde4a5f36098f47ad50a696/mojo/edk/system/dispatcher.cc
[modify] https://crrev.com/a523cf48c629d7327cde4a5f36098f47ad50a696/mojo/edk/system/dispatcher.h
[modify] https://crrev.com/a523cf48c629d7327cde4a5f36098f47ad50a696/mojo/edk/system/handle_table.cc
[add] https://crrev.com/a523cf48c629d7327cde4a5f36098f47ad50a696/mojo/edk/system/invitation_dispatcher.cc
[add] https://crrev.com/a523cf48c629d7327cde4a5f36098f47ad50a696/mojo/edk/system/invitation_dispatcher.h
[add] https://crrev.com/a523cf48c629d7327cde4a5f36098f47ad50a696/mojo/edk/system/invitation_unittest.cc
[modify] https://crrev.com/a523cf48c629d7327cde4a5f36098f47ad50a696/mojo/edk/system/node_controller.cc
[modify] https://crrev.com/a523cf48c629d7327cde4a5f36098f47ad50a696/mojo/public/c/system/BUILD.gn
[modify] https://crrev.com/a523cf48c629d7327cde4a5f36098f47ad50a696/mojo/public/c/system/core.h
[add] https://crrev.com/a523cf48c629d7327cde4a5f36098f47ad50a696/mojo/public/c/system/invitation.h
[modify] https://crrev.com/a523cf48c629d7327cde4a5f36098f47ad50a696/mojo/public/c/system/macros.h
[modify] https://crrev.com/a523cf48c629d7327cde4a5f36098f47ad50a696/mojo/public/c/system/thunks.cc
[modify] https://crrev.com/a523cf48c629d7327cde4a5f36098f47ad50a696/mojo/public/c/system/thunks.h
Project Member

Comment 5 by bugdroid1@chromium.org, May 19 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6958662bf45564a48de067bf6c906fb8f890a386

commit 6958662bf45564a48de067bf6c906fb8f890a386
Author: Ken Rockot <rockot@chromium.org>
Date: Sat May 19 21:55:51 2018

Revert "Mojo: Invitation API"

This reverts commit a523cf48c629d7327cde4a5f36098f47ad50a696.

Reason for revert: Bad rebase, conflicted with another change

Original change's description:
> Mojo: Invitation API
> 
> This is a public C API replacement for the EDK invitation API, i.e.
> Incoming/OutgoingBrokerClientInvitation et al. Here the new C calls
> are introduced and covered by unit tests.
> 
> See the associated bug and the bugs it's blocking for more context
> and follow-up work.
> 
> Bug:  844231 
> Change-Id: Iffa2e5b08eefbe3476430eb420efe2f52f4ad195
> Reviewed-on: https://chromium-review.googlesource.com/1066807
> Commit-Queue: Ken Rockot <rockot@chromium.org>
> Reviewed-by: Jay Civelli <jcivelli@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#560164}

TBR=jcivelli@chromium.org,rockot@chromium.org

Change-Id: I798545dc19a146fe40a9e1ad7ff95a41d0d5dd25
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug:  844231 
Reviewed-on: https://chromium-review.googlesource.com/1067053
Reviewed-by: Ken Rockot <rockot@chromium.org>
Commit-Queue: Ken Rockot <rockot@chromium.org>
Cr-Commit-Position: refs/heads/master@{#560175}
[modify] https://crrev.com/6958662bf45564a48de067bf6c906fb8f890a386/mojo/edk/BUILD.gn
[modify] https://crrev.com/6958662bf45564a48de067bf6c906fb8f890a386/mojo/edk/embedder/entrypoints.cc
[modify] https://crrev.com/6958662bf45564a48de067bf6c906fb8f890a386/mojo/edk/embedder/platform_handle_utils.cc
[modify] https://crrev.com/6958662bf45564a48de067bf6c906fb8f890a386/mojo/edk/embedder/platform_handle_utils.h
[modify] https://crrev.com/6958662bf45564a48de067bf6c906fb8f890a386/mojo/edk/system/BUILD.gn
[modify] https://crrev.com/6958662bf45564a48de067bf6c906fb8f890a386/mojo/edk/system/core.cc
[modify] https://crrev.com/6958662bf45564a48de067bf6c906fb8f890a386/mojo/edk/system/core.h
[modify] https://crrev.com/6958662bf45564a48de067bf6c906fb8f890a386/mojo/edk/system/dispatcher.cc
[modify] https://crrev.com/6958662bf45564a48de067bf6c906fb8f890a386/mojo/edk/system/dispatcher.h
[modify] https://crrev.com/6958662bf45564a48de067bf6c906fb8f890a386/mojo/edk/system/handle_table.cc
[delete] https://crrev.com/f748c29f44b2f94e194c64d585ca86f53d8e11e5/mojo/edk/system/invitation_dispatcher.cc
[delete] https://crrev.com/f748c29f44b2f94e194c64d585ca86f53d8e11e5/mojo/edk/system/invitation_dispatcher.h
[delete] https://crrev.com/f748c29f44b2f94e194c64d585ca86f53d8e11e5/mojo/edk/system/invitation_unittest.cc
[modify] https://crrev.com/6958662bf45564a48de067bf6c906fb8f890a386/mojo/edk/system/node_controller.cc
[modify] https://crrev.com/6958662bf45564a48de067bf6c906fb8f890a386/mojo/public/c/system/BUILD.gn
[modify] https://crrev.com/6958662bf45564a48de067bf6c906fb8f890a386/mojo/public/c/system/core.h
[delete] https://crrev.com/f748c29f44b2f94e194c64d585ca86f53d8e11e5/mojo/public/c/system/invitation.h
[modify] https://crrev.com/6958662bf45564a48de067bf6c906fb8f890a386/mojo/public/c/system/macros.h
[modify] https://crrev.com/6958662bf45564a48de067bf6c906fb8f890a386/mojo/public/c/system/thunks.cc
[modify] https://crrev.com/6958662bf45564a48de067bf6c906fb8f890a386/mojo/public/c/system/thunks.h
Project Member

Comment 6 by bugdroid1@chromium.org, May 19 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f86cdb8bcfcdeec95ec57789dd3ae7d43d812862

commit f86cdb8bcfcdeec95ec57789dd3ae7d43d812862
Author: Ken Rockot <rockot@chromium.org>
Date: Sat May 19 23:35:01 2018

Mojo: Invitation API [reland]

Reland fixes a simple merge conflict which caused a non-existent
header to be included. Original CL is
https://chromium-review.googlesource.com/c/chromium/src/+/1066807

This is a public C API replacement for the EDK invitation API, i.e.
Incoming/OutgoingBrokerClientInvitation et al. Here the new C calls
are introduced and covered by unit tests.

See the associated bug and the bugs it's blocking for more context
and follow-up work.

TBR=jcivelli@chromium.org

Bug:  844231 
Change-Id: If23b70ea381031a4caaed0ba5e6cf45c6b218971
Reviewed-on: https://chromium-review.googlesource.com/1067087
Reviewed-by: Ken Rockot <rockot@chromium.org>
Commit-Queue: Ken Rockot <rockot@chromium.org>
Cr-Commit-Position: refs/heads/master@{#560185}
[modify] https://crrev.com/f86cdb8bcfcdeec95ec57789dd3ae7d43d812862/mojo/edk/BUILD.gn
[modify] https://crrev.com/f86cdb8bcfcdeec95ec57789dd3ae7d43d812862/mojo/edk/embedder/entrypoints.cc
[modify] https://crrev.com/f86cdb8bcfcdeec95ec57789dd3ae7d43d812862/mojo/edk/embedder/platform_handle_utils.cc
[modify] https://crrev.com/f86cdb8bcfcdeec95ec57789dd3ae7d43d812862/mojo/edk/embedder/platform_handle_utils.h
[modify] https://crrev.com/f86cdb8bcfcdeec95ec57789dd3ae7d43d812862/mojo/edk/system/BUILD.gn
[modify] https://crrev.com/f86cdb8bcfcdeec95ec57789dd3ae7d43d812862/mojo/edk/system/core.cc
[modify] https://crrev.com/f86cdb8bcfcdeec95ec57789dd3ae7d43d812862/mojo/edk/system/core.h
[modify] https://crrev.com/f86cdb8bcfcdeec95ec57789dd3ae7d43d812862/mojo/edk/system/dispatcher.cc
[modify] https://crrev.com/f86cdb8bcfcdeec95ec57789dd3ae7d43d812862/mojo/edk/system/dispatcher.h
[modify] https://crrev.com/f86cdb8bcfcdeec95ec57789dd3ae7d43d812862/mojo/edk/system/handle_table.cc
[add] https://crrev.com/f86cdb8bcfcdeec95ec57789dd3ae7d43d812862/mojo/edk/system/invitation_dispatcher.cc
[add] https://crrev.com/f86cdb8bcfcdeec95ec57789dd3ae7d43d812862/mojo/edk/system/invitation_dispatcher.h
[add] https://crrev.com/f86cdb8bcfcdeec95ec57789dd3ae7d43d812862/mojo/edk/system/invitation_unittest.cc
[modify] https://crrev.com/f86cdb8bcfcdeec95ec57789dd3ae7d43d812862/mojo/edk/system/node_controller.cc
[modify] https://crrev.com/f86cdb8bcfcdeec95ec57789dd3ae7d43d812862/mojo/public/c/system/BUILD.gn
[modify] https://crrev.com/f86cdb8bcfcdeec95ec57789dd3ae7d43d812862/mojo/public/c/system/core.h
[add] https://crrev.com/f86cdb8bcfcdeec95ec57789dd3ae7d43d812862/mojo/public/c/system/invitation.h
[modify] https://crrev.com/f86cdb8bcfcdeec95ec57789dd3ae7d43d812862/mojo/public/c/system/macros.h
[modify] https://crrev.com/f86cdb8bcfcdeec95ec57789dd3ae7d43d812862/mojo/public/c/system/thunks.cc
[modify] https://crrev.com/f86cdb8bcfcdeec95ec57789dd3ae7d43d812862/mojo/public/c/system/thunks.h

Comment 7 by roc...@chromium.org, May 21 2018

Status: Fixed (was: Started)
►

Sign in to add a comment