Issue metadata
Sign in to add a comment
|
Existing issue doesn't show up in Cast dialog |
||||||||||||||||||||||
Issue descriptionWhen there is an issue (e.g. shown when desktop picker is cancelled), closing and reopening the dialog makes the issue banner disappear, when the banner should still be visible. This is a regression in M68.
,
May 18 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b7ae3de88743704fef261049759ef2a19a8e20dd commit b7ae3de88743704fef261049759ef2a19a8e20dd Author: Takumi Fujimoto <takumif@chromium.org> Date: Fri May 18 17:45:32 2018 Set |ui_initialized_| in MRUI before initializing issue observer The |ui_initialized_| boolean needs to be set before we initialize the issue observer and receive the first issue. Also rename MRUI::UIInitialized() to MRUI::OnUIInitialized(). Bug:844217 Change-Id: I1bfefb69f586f0fa3470255e4ea9665bff1c2098 Reviewed-on: https://chromium-review.googlesource.com/1065078 Commit-Queue: Takumi Fujimoto <takumif@chromium.org> Reviewed-by: Adam Parker <amp@chromium.org> Cr-Commit-Position: refs/heads/master@{#559946} [modify] https://crrev.com/b7ae3de88743704fef261049759ef2a19a8e20dd/chrome/browser/ui/webui/media_router/media_router_ui.cc [modify] https://crrev.com/b7ae3de88743704fef261049759ef2a19a8e20dd/chrome/browser/ui/webui/media_router/media_router_ui.h [modify] https://crrev.com/b7ae3de88743704fef261049759ef2a19a8e20dd/chrome/browser/ui/webui/media_router/media_router_webui_message_handler.cc [modify] https://crrev.com/b7ae3de88743704fef261049759ef2a19a8e20dd/chrome/browser/ui/webui/media_router/media_router_webui_message_handler_unittest.cc
,
May 18 2018
|
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by taku...@chromium.org
, May 17 2018