New issue
Advanced search Search tips

Issue 844211 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Sep 28
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome , Mac
Pri: 3
Type: Bug

Blocking:
issue 775999



Sign in to add a comment

N-up does not work for a particular PDF

Project Member Reported by thestig@chromium.org, May 17 2018

Issue description

Chrome Version: 68.0.3434.0 / r559595
OS: Linux

What steps will reproduce the problem?

If necessary:
(1) Go to chrome://flags
(2) Turn on "Enable new Print Preview UI"
(3) Turn on "Enable N-up printing"
(4) Restart the browser

Then:
(5) Navigate to http://dsal.uchicago.edu/dictionaries/gwynn/frontmatter.pdf
(6) Print
(7) Set "Pages Per Sheet" to 2 in the left pane.
(8) Wait for the updated print preview to render.

What is the expected result?

A 10 page print preview with the original PDF contents laid out in 2-up mode.

What happens instead?

A 10 page print preview where all the pages are blank.

 
Status: Started (was: Assigned)
Status: Fixed (was: Started)
Fixed by this CL: https://chromium-review.googlesource.com/c/chromium/src/+/1237719/
Labels: OS-Chrome OS-Mac OS-Windows
Status: Started (was: Fixed)
My CL referenced by comment 2 does not fix this issue.
Project Member

Comment 4 by bugdroid1@chromium.org, Sep 28

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/82637b85857d4040c38004a4db95d7a09385217d

commit 82637b85857d4040c38004a4db95d7a09385217d
Author: Lei Zhang <thestig@chromium.org>
Date: Fri Sep 28 16:35:26 2018

Make PDF printing transformations consistent between 1-up and N-up.

Currently, 1-up printing and N-up printing have separate paths that do
transformations on PDFs to fit them to the printable area for printing.
The 1-up path has been in use for years. The N-up path is in development
but has some trouble with certain PDFs.

To fix the N-up path, make it go through the 1-up path first. Now with a
properly transformed 1-up PDF, the N-up path can just do N-up layout in
addition. This also makes N-up PDF printing work correctly with the
scaling setting.

BUG= 844211 

Change-Id: I911187e585214ff40327752801c38bda8cf129b7
Reviewed-on: https://chromium-review.googlesource.com/1238078
Reviewed-by: Rebekah Potter <rbpotter@chromium.org>
Commit-Queue: Lei Zhang <thestig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#595118}
[modify] https://crrev.com/82637b85857d4040c38004a4db95d7a09385217d/pdf/pdfium/pdfium_print.cc

Owner: thestig@chromium.org
Status: Fixed (was: Started)

Sign in to add a comment