Settings: device_page/display's overscan row alignment seems off |
|||
Issue descriptionI think cr-link-row assumes padding's always desired but in this case that might be false. This was originally converted to cr-link-row in this CL: https://chromium-review.googlesource.com/c/chromium/src/+/656527
,
May 17 2018
Malay, can you take a look while you are looking int issue 844199 ?
,
Jun 21 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/48d75487205f581cb8fd09d90350fa4a682d173c commit 48d75487205f581cb8fd09d90350fa4a682d173c Author: Malay Keshav <malaykeshav@chromium.org> Date: Thu Jun 21 22:50:37 2018 Fix display settings overscan indent This patch replaces the use of cr-link-row polymer element with a simple div element similar to what the touch calibration button is using. The cr-link-row element is meant for non indented DOM sections which the display page is not. The cr-link-row element comes with its own left padding which is not required in an already indented DOM. Bug: 844205 Cq-Include-Trybots: luci.chromium.try:closure_compilation Change-Id: Ic4ecc5bf7388384cb403fa7783a53a18963305d6 Component: Display settings UI, overscan Reviewed-on: https://chromium-review.googlesource.com/1109205 Commit-Queue: Malay Keshav <malaykeshav@chromium.org> Reviewed-by: Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#569388} [modify] https://crrev.com/48d75487205f581cb8fd09d90350fa4a682d173c/chrome/browser/resources/settings/device_page/display.html [modify] https://crrev.com/48d75487205f581cb8fd09d90350fa4a682d173c/ui/webui/resources/cr_elements/cr_link_row/cr_link_row.html
,
Jun 21 2018
|
|||
►
Sign in to add a comment |
|||
Comment 1 by steve...@chromium.org
, May 17 2018