New issue
Advanced search Search tips

Issue 844201 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: May 2018
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 3
Type: Bug



Sign in to add a comment

Download Infobar : Create IPH

Project Member Reported by shaktisahu@chromium.org, May 17 2018

Issue description

Add two IPH for the infobar
1 - When infobar is closed, IPH would show up with message "Your download is still running"
2 - When the infobar starts up, IPH would show up with message "Chrome now downloads files faster"

UX Specs : https://docs.google.com/presentation/d/1wfX6QkEzDbt3Bx2hj6v85_lND1iSUUfXIZN6TMhREuo/


 
Project Member

Comment 1 by bugdroid1@chromium.org, May 18 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/dd0f00b919e8fd932c2b63871463ffbc17194d1d

commit dd0f00b919e8fd932c2b63871463ffbc17194d1d
Author: Shakti Sahu <shaktisahu@chromium.org>
Date: Fri May 18 15:06:23 2018

Download Infobar : Show IPH

Added two IPH for the accelerated infobar
1 - When infobar is closed, IPH would show up with message "Your download is still running"
2 - When the infobar starts up, IPH would show up with message "Chrome now downloads files faster"

Bug:  844201 
Change-Id: Id1ccde95e0175ce285c29f033b0bf23996433f7d
Reviewed-on: https://chromium-review.googlesource.com/1054157
Commit-Queue: Shakti Sahu <shaktisahu@chromium.org>
Reviewed-by: Ilya Sherman <isherman@chromium.org>
Reviewed-by: David Trainor <dtrainor@chromium.org>
Cr-Commit-Position: refs/heads/master@{#559894}
[modify] https://crrev.com/dd0f00b919e8fd932c2b63871463ffbc17194d1d/chrome/android/java/src/org/chromium/chrome/browser/ChromeTabbedActivity.java
[modify] https://crrev.com/dd0f00b919e8fd932c2b63871463ffbc17194d1d/chrome/android/java/src/org/chromium/chrome/browser/download/DownloadInfoBarController.java
[modify] https://crrev.com/dd0f00b919e8fd932c2b63871463ffbc17194d1d/chrome/android/java/src/org/chromium/chrome/browser/infobar/IPHBubbleDelegateImpl.java
[modify] https://crrev.com/dd0f00b919e8fd932c2b63871463ffbc17194d1d/chrome/android/java/src/org/chromium/chrome/browser/infobar/IPHInfoBarSupport.java
[modify] https://crrev.com/dd0f00b919e8fd932c2b63871463ffbc17194d1d/chrome/android/java/strings/android_chrome_strings.grd
[modify] https://crrev.com/dd0f00b919e8fd932c2b63871463ffbc17194d1d/components/feature_engagement/public/android/java/src/org/chromium/components/feature_engagement/FeatureConstants.java
[modify] https://crrev.com/dd0f00b919e8fd932c2b63871463ffbc17194d1d/components/feature_engagement/public/feature_constants.cc
[modify] https://crrev.com/dd0f00b919e8fd932c2b63871463ffbc17194d1d/components/feature_engagement/public/feature_constants.h
[modify] https://crrev.com/dd0f00b919e8fd932c2b63871463ffbc17194d1d/components/feature_engagement/public/feature_list.cc
[modify] https://crrev.com/dd0f00b919e8fd932c2b63871463ffbc17194d1d/components/feature_engagement/public/feature_list.h
[modify] https://crrev.com/dd0f00b919e8fd932c2b63871463ffbc17194d1d/testing/variations/fieldtrial_testing_config.json
[modify] https://crrev.com/dd0f00b919e8fd932c2b63871463ffbc17194d1d/tools/metrics/histograms/histograms.xml

Status: Fixed (was: Started)

Sign in to add a comment