Disable forced tab stacking on touchable UI |
||||
Issue descriptionCurrently the tabstrip forces tab stacking when touchable ui is enabled. This makes mouse interactions difficult with the stacked tabs. We need to rever the force tab stacking.
,
May 18 2018
The spec says:"If the user clicks the stack, it reveals 4 additional tabs, stacking tabs on the other side" Wasn't the agreement to simply fallback to non-stacked ui if a mouse click is detected? And then go back to touch(stacked) layout when a touch event is detected? And we only reveal additional tabs if a tab is detected on the stack?
,
May 19 2018
Sorry it should read "taps the stack". This behavior is now touch only, as you said.
,
May 20 2018
Issue 844495 has been merged into this issue.
,
May 21 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/df7f3d1c42f771a610b2ef4d3321ef886e769dc3 commit df7f3d1c42f771a610b2ef4d3321ef886e769dc3 Author: Malay Keshav <malaykeshav@chromium.org> Date: Mon May 21 17:45:36 2018 Remove force stacking when touchable chrome is enabled This patch removes the force stacking of tabs when touch optimized chrome is enabled and restores the old approach. Bug: 844193 Change-Id: Icf591860d06afe4698817291f70d619343237a82 Component: Touchable chrome, tabstrip, tab stacking Reviewed-on: https://chromium-review.googlesource.com/1066864 Commit-Queue: Malay Keshav <malaykeshav@chromium.org> Reviewed-by: Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#560292} [modify] https://crrev.com/df7f3d1c42f771a610b2ef4d3321ef886e769dc3/chrome/browser/ui/views/tabs/browser_tab_strip_controller.cc [modify] https://crrev.com/df7f3d1c42f771a610b2ef4d3321ef886e769dc3/chrome/browser/ui/views/tabs/tab_strip.cc
,
May 21 2018
,
May 22 2018
Is there any reason this bug needs to be restricted? I linked to it from somewhere, and people told me they couldn't access it. Looks like it could be public?
,
May 22 2018
,
May 25 2018
Issue 846052 has been merged into this issue.
,
May 25 2018
What build is the fix targeted for? Thanks.
,
May 25 2018
Issue 846805 has been merged into this issue.
,
May 31 2018
|
||||
►
Sign in to add a comment |
||||
Comment 1 by sgabr...@chromium.org
, May 18 2018164 KB
164 KB View Download