New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 844193 link

Starred by 13 users

Issue metadata

Status: Fixed
Owner:
Closed: May 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug



Sign in to add a comment

Disable forced tab stacking on touchable UI

Project Member Reported by malaykeshav@chromium.org, May 17 2018

Issue description

Currently the tabstrip forces tab stacking when touchable ui is enabled. This makes mouse interactions difficult with the stacked tabs. We need to rever the force tab stacking.
 
Spec has been updated to reflect this change:
https://gallery.googleplex.com/projects/MCHbtQVoQ2HCZZsKUFLaS3Ii/files/MCGnZePQNEdEshUCveL64FYEwMSJbxAVNpw


spec excerpt.png
164 KB View Download
The spec says:"If the user clicks the stack, it reveals 4 additional tabs, stacking tabs on the other side"

Wasn't the agreement to simply fallback to non-stacked ui if a mouse click is detected? And then go back to touch(stacked) layout when a touch event is detected?
And we only reveal additional tabs if a tab is detected on the stack?
Sorry it should read "taps the stack". This behavior is now touch only, as you said.
Cc: abodenha@chromium.org malaykeshav@chromium.org rachelsn@chromium.org
 Issue 844495  has been merged into this issue.
Project Member

Comment 5 by bugdroid1@chromium.org, May 21 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/df7f3d1c42f771a610b2ef4d3321ef886e769dc3

commit df7f3d1c42f771a610b2ef4d3321ef886e769dc3
Author: Malay Keshav <malaykeshav@chromium.org>
Date: Mon May 21 17:45:36 2018

Remove force stacking when touchable chrome is enabled

This patch removes the force stacking of tabs when touch optimized
chrome is enabled and restores the old approach.

Bug:  844193 
Change-Id: Icf591860d06afe4698817291f70d619343237a82
Component: Touchable chrome, tabstrip, tab stacking
Reviewed-on: https://chromium-review.googlesource.com/1066864
Commit-Queue: Malay Keshav <malaykeshav@chromium.org>
Reviewed-by: Peter Kasting <pkasting@chromium.org>
Cr-Commit-Position: refs/heads/master@{#560292}
[modify] https://crrev.com/df7f3d1c42f771a610b2ef4d3321ef886e769dc3/chrome/browser/ui/views/tabs/browser_tab_strip_controller.cc
[modify] https://crrev.com/df7f3d1c42f771a610b2ef4d3321ef886e769dc3/chrome/browser/ui/views/tabs/tab_strip.cc

Status: Fixed (was: Assigned)

Comment 7 by thakis@chromium.org, May 22 2018

Is there any reason this bug needs to be restricted? I linked to it from somewhere, and people told me they couldn't access it. Looks like it could be public?
Labels: -Restrict-View-Google
Issue 846052 has been merged into this issue.

Comment 10 by ptam@google.com, May 25 2018

What build is the fix targeted for? Thanks.
 Issue 846805  has been merged into this issue.
Cc: zelidrag@chromium.org
 Issue 848008  has been merged into this issue.

Sign in to add a comment