New issue
Advanced search Search tips

Issue 844185 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner:
Closed: May 2018
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 1
Type: Bug

Blocking:
issue 717696



Sign in to add a comment

[Incompatible Applications] The application name is not written in the search box

Project Member Reported by pmonette@chromium.org, May 17 2018

Issue description

Clicking "Uninstall" in chrome://settings/incompatibleApplications does not cause
the name of the application to be written into the search box.
 
Project Member

Comment 1 by bugdroid1@chromium.org, May 17 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/bc84dc82d13115138000a6b4b578e9fca655556a

commit bc84dc82d13115138000a6b4b578e9fca655556a
Author: Patrick Monette <pmonette@chromium.org>
Date: Thu May 17 21:26:32 2018

Fix UninstallAppController

The callback was cleared for each focus changed event even if it wasn't
for the right element. This meant that SetValue() was never called since
the first focus changed event we received was never the right one.

Fix it by swapping the callback after the right element is found.

Tbr: grt@chromium.org
Bug:  844185 
Change-Id: I7dabce15513c0346e6c78adf1802a562002de08a
Reviewed-on: https://chromium-review.googlesource.com/1064543
Reviewed-by: Patrick Monette <pmonette@chromium.org>
Commit-Queue: Patrick Monette <pmonette@chromium.org>
Cr-Commit-Position: refs/heads/master@{#559684}
[modify] https://crrev.com/bc84dc82d13115138000a6b4b578e9fca655556a/chrome/browser/conflicts/uninstall_application_win.cc

Labels: Needs-Feedback
Unable to verify this issue as on navigating to chrome://settings/incompatibleApplications redirects us to chrome://settings.

@pmonette: Please provide steps to reproduce to verify this from TE end. Please help in verifying the fix.

Thanks!
Labels: -Needs-Feedback
Status: Fixed (was: Assigned)
I have verified the fix on m68 dev manually.
Labels: Merge-Approved-67
Hi govind@

Requesting a merge to m67 as discussed via email.

This is a very safe merge containing 6 line changes and that is behind a finch flag. We want to have it in the next stable respin, if one does happen. This is because it's blocking the release of a feature we've committed to externally. (https://blog.chromium.org/2017/11/reducing-chrome-crashes-caused-by-third.html)

Thanks and sorry for the trouble.

Comment 5 by gov...@chromium.org, May 31 2018

Labels: -Merge-Approved-67 Merge-Request-67
Adding Merge-Request-67 label per comment #4.

Comment 6 by gov...@chromium.org, May 31 2018

Labels: -Merge-Request-67 Merge-Approved-67
Approving merge to M67 branch 3396 based on comment #4. Please merge. Thank you.


Project Member

Comment 7 by bugdroid1@chromium.org, May 31 2018

Labels: -merge-approved-67 merge-merged-3396
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3d0bc42ac010f115660ea28b5615dbe6062104d2

commit 3d0bc42ac010f115660ea28b5615dbe6062104d2
Author: Patrick Monette <pmonette@chromium.org>
Date: Thu May 31 20:55:20 2018

Fix UninstallAppController

The callback was cleared for each focus changed event even if it wasn't
for the right element. This meant that SetValue() was never called since
the first focus changed event we received was never the right one.

Fix it by swapping the callback after the right element is found.

Merging to m57 stable

(cherry picked from commit bc84dc82d13115138000a6b4b578e9fca655556a)

Bug:  844185 
Change-Id: I7dabce15513c0346e6c78adf1802a562002de08a
Reviewed-on: https://chromium-review.googlesource.com/1064543
Reviewed-by: Patrick Monette <pmonette@chromium.org>
Commit-Queue: Patrick Monette <pmonette@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#559684}
Reviewed-on: https://chromium-review.googlesource.com/1081337
Cr-Commit-Position: refs/branch-heads/3396@{#724}
Cr-Branched-From: 9ef2aa869bc7bc0c089e255d698cca6e47d6b038-refs/heads/master@{#550428}
[modify] https://crrev.com/3d0bc42ac010f115660ea28b5615dbe6062104d2/chrome/browser/conflicts/uninstall_application_win.cc

Sign in to add a comment