New issue
Advanced search Search tips

Issue 844177 link

Starred by 1 user
Status: WontFix
Owner:
xiaochu@chromium.org
Closed: May 2018
Cc:
waff...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Bug



Sign in to add a comment

replace sha2hashstr with appid

Project Member Reported by xiaochu@chromium.org, May 17 2018 
The sha2hash in https://cs.chromium.org/chromium/src/chrome/browser/component_updater/cros_component_installer_chromeos.cc?sq=package:chromium&g=0&l=34 is only used for generating appid. 

According to go/crx3, appid is no longer necessarily correlated with sha2hash. So I propose to use appid directly in the ComponentConfig.

Comment 1 by xiaochu@chromium.org, May 17 2018 

It turns out ComponentInstallerPolicy::GetHash still needs the hash for some reasons (?). The sha2hash is still required...

Comment 2 by waff...@chromium.org, May 18 2018 

Hash is no longer necessarily correlated with appid as per the package format. However, in practice we still pin a key (via hash) that we require the downloaded file to be signed with.

Comment 3 by xiaochu@chromium.org, May 18 2018

Status: WontFix (was: Untriaged)
I see. Thanks!
►

Sign in to add a comment