New issue
Advanced search Search tips

Issue 844176 link

Starred by 1 user
Status: Fixed
Owner:
mef@chromium.org
Closed: May 2018
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 3
Type: Bug



Sign in to add a comment

stale_host_resolver.cc(256) DCHECK crash

Project Member Reported by kapishnikov@chromium.org, May 17 2018 
The following steps:
1. Enabling "AsyncDNS" and "StaleDns" with "persist to disk" in Cronet experimental options,
2. assigning an IP to a host in /etc/hosts,
3. connecting to the host
may result in the following error:
FATAL:stale_host_resolver.cc(256)] Check failed: net::ERR_IO_PENDING == network_rv (-1 vs. 0)

Internal bug: b/79916046

Comment 1 by mef@chromium.org, May 17 2018

Status: Available (was: Untriaged)
Looking at https://cs.chromium.org/chromium/src/net/dns/host_resolver_impl.cc?rcl=e6c0da17e63db018c0140922fcea3ea6284f865e&l=2087 it does return OK if ServeFromHosts() returns true.

This is returned back to StaleHostResolver::RequestImpl::Start() and triggers DCHECK that expects the status to always be net::ERR_IO_PENDING.

Comment 2 by mef@chromium.org, May 21 2018

Owner: mef@chromium.org
Status: Started (was: Available)
Project Member

Comment 3 by bugdroid1@chromium.org, May 21 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/debaf4cdbf00fed03d13c4ae576d4b0d57fb7391

commit debaf4cdbf00fed03d13c4ae576d4b0d57fb7391
Author: Misha Efimov <mef@chromium.org>
Date: Mon May 21 15:35:42 2018

Fix StaleHostResolver to handle sync returns from /etc/hosts resolution.

Bug:  844176 
Cq-Include-Trybots: master.tryserver.chromium.android:android_cronet_tester;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: I24afd90a60a00ed7bd4700f13de78217cf4953e7
Reviewed-on: https://chromium-review.googlesource.com/1066751
Reviewed-by: Paul Jensen <pauljensen@chromium.org>
Commit-Queue: Misha Efimov <mef@chromium.org>
Cr-Commit-Position: refs/heads/master@{#560274}
[modify] https://crrev.com/debaf4cdbf00fed03d13c4ae576d4b0d57fb7391/components/cronet/stale_host_resolver.cc
[modify] https://crrev.com/debaf4cdbf00fed03d13c4ae576d4b0d57fb7391/components/cronet/stale_host_resolver_unittest.cc

Comment 4 by mef@chromium.org, May 21 2018

Status: Fixed (was: Started)
►

Sign in to add a comment