Files app dialog should have affirmative actions on the right |
||||||||||||||
Issue descriptionChrome Version: 68.0.3431.0 (Official Build) canary (64-bit) OS: Chrome OS What steps will reproduce the problem? (1)Open files app (2)Invoke a dialog, for example try to delete a file, open a file, save a page/file as,etc (3)Notice that affirmative actions (blue button) are on the left What is the expected result? We've established convention to have affirmative actions on the right as a Chrome OS convention. This is reviewed & approved at UI OH, below is the PoR deck Accessibility wise, after changing affirmative actions to the right hand side, tabbing order needs to change too. It will first focus on affirmative action, then focus on dismissive action. In the new order, it will be "right to left". We do not change tabbing order (or views on text, etc) outside of button group. Chrome OS button ordering (go/cros-button-order) What happens instead? Affirmative actions currently in files app are on the left.
,
May 18 2018
,
Jun 1 2018
,
Jun 5 2018
,
Jun 5 2018
,
Jun 5 2018
,
Jun 8 2018
Weifang what's the priority on this? Do we have UI approval? This seems easy enough to do
,
Jun 8 2018
Let's make this a 1 for M-71. UI approval has been obtained. :)
,
Jun 13 2018
Stu - here's your nontrivial UI bug for M67 ;) (Actually, this one might be pretty trivial, but its a good starting place)
,
Jun 13 2018
Nevermind, stuart has no bandwidth for this for M71 :( Marking as Available and we'll find an owner once people free up.
,
Jun 13 2018
M-71? I can probably take a crack at it. I was misled by comment #9 on the urgency.
,
Jun 13 2018
Oh, sorry, no idea why I said 67. I thought 71. :/ #multitasking
,
Sep 18
,
Nov 7
,
Nov 19
,
Nov 19
Note we also updated the tab stops here as well so the flow makes sense. So now first tab will be cancel not ok for these dialogs.
,
Nov 19
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/eb625ae70721292c475196de60d795c02c62faf8 commit eb625ae70721292c475196de60d795c02c62faf8 Author: Stuart Langley <slangley@google.com> Date: Mon Nov 19 06:54:34 2018 Make files app dialogs have affirmative actions on the right. - For cr-dialog-button (e.g. delete file dialog) use css to set the order so that the ok button is on the right of the cancel button. - For the dialog footer just modify the html so that the ok button comes after the cancel button. Tested visually as there are no automated tests for style. Bug: 844168 Change-Id: Ia6eb652928cba50dd30cb8324b9c33ac13d46df2 Reviewed-on: https://chromium-review.googlesource.com/c/1341283 Reviewed-by: Noel Gordon <noel@chromium.org> Commit-Queue: Stuart Langley <slangley@chromium.org> Cr-Commit-Position: refs/heads/master@{#609192} [modify] https://crrev.com/eb625ae70721292c475196de60d795c02c62faf8/ui/file_manager/file_manager/foreground/css/common.css [modify] https://crrev.com/eb625ae70721292c475196de60d795c02c62faf8/ui/file_manager/file_manager/main.html [modify] https://crrev.com/eb625ae70721292c475196de60d795c02c62faf8/ui/file_manager/integration_tests/file_manager/tab_index.js
,
Nov 19
|
||||||||||||||
►
Sign in to add a comment |
||||||||||||||
Comment 1 by qqwangxin@chromium.org
, May 17 2018