New issue
Advanced search Search tips

Issue 844167 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner:
Closed: Jan 8
Cc:
Components:
EstimatedDays: ----
NextAction: 2018-09-04
OS: Chrome
Pri: 2
Type: Bug

Blocking:
issue 849574



Sign in to add a comment

Print dialog should have affirmative actions on the right

Project Member Reported by qqwangxin@chromium.org, May 17 2018

Issue description

Chrome Version: 68.0.3431.0 (Official Build) canary (64-bit)
OS: Chrome OS

What steps will reproduce the problem?
(1)Try to print anything from chrome
(2)Notice that "Print" or "Save" button is on the left
(3)

What is the expected result?
We've established effort to have affirmative actions on the right as a Chrome OS convention. This is reviewed & approved at UI OH, below is the PoR deck
Accessibility wise, after changing affirmative actions to the right hand side, tabbing order needs to change too. It will first focus on affirmative action, then focus on dismissive action. In the new order, it will be "right to left". 

We do not change tabbing order (or views on text, etc) outside of button group.


Chrome OS button ordering (go/cros-button-order)


What happens instead?
Affirmative actions currently in print dialog is on the left. 

 
Screenshot 2018-05-17 at 1.12.09 PM.png
337 KB View Download

Comment 1 by dpa...@chromium.org, May 18 2018

Components: UI>Browser>PrintPreview
Make this change is easy. Linux already has it on the right. Just reassign the bug to me or rbpotter when you are ready to make the change.
Awesome, thanks thestig@! I'm checking on timelines and will update once I have the info.
Description: Show this description
Blocking: 849574
Cc: weifangsun@chromium.org
Labels: M-71
Owner: thestig@chromium.org
Status: Assigned (was: Untriaged)
thestig@ - We're aiming to align these dialogs across the system for M-71. The launch bug has been added as blocked to this bug. Let me know if you have any questions!
weifangsun: To be clear, do we want to make this change in the M-71 cycle (AKA September) or any time before the M-71 branch? (AKA do it now for M-69)
thestig@ - Sorry for the slow turn around. Let's make this change in the M-71 cycle, no need to action now.
NextAction: 2018-09-04
The NextAction date has arrived: 2018-09-04
Owner: rbpotter@chromium.org
Let's flip it again for ChromeOS.
This should be done as of https://crrev.com/c/1152042 which landed at  71.0.3552.0. Figured it would make sense to flip it with the refresh, so that everything changes at the same time.


Thank you!!
rbpotter@ - FYI, we moved the blocking launch bug back to M-72 given delays. I think it's fine to keep the update you've made for the print affirmation dialog in M-71 with the print UI refresh, but wanted to give you a heads up. Let me know if you have any questions.
Status: Fixed (was: Assigned)
This should be fixed in M-71. Please re-open if it is not.

Sign in to add a comment