New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 844166 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Oct 22
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Feature

Blocking:
issue 891826
issue 682860



Sign in to add a comment

Add ebuilds for shellcheck

Project Member Reported by bmgordon@chromium.org, May 17 2018

Issue description

We want to evaluate whether shellcheck is useful in presubmits.  As a first step, import the ebuild with whatever dependencies are needed to see what effect it will have on the chroot.
 
Project Member

Comment 1 by bugdroid1@chromium.org, May 22 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/portage-stable/+/47366d42ecf8e3e763e14f45c5d2d2c590250f3f

commit 47366d42ecf8e3e763e14f45c5d2d2c590250f3f
Author: Benjamin Gordon <bmgordon@chromium.org>
Date: Tue May 22 19:56:24 2018

gdk-pixbuf: Explicitly inherit eutils

The new version of versionator.eclass coming in crrev.com/c/1065027 no
longer implicitly inherits eutils, but gdk-pixbuf needs functions from
it.  We should ideally upgrade gdk-pixbuf instead of patching this
ebuild, but that requires a large number of additional dependent eclass
upgrades (tracked in  crbug.com/845181 ).  Directly inherit eutils as a
temporary workaround.

BUG= chromium:845181 ,  chromium:844166 
TEST=emerge-grunt gdk-pixbuf

Change-Id: I48aa4b2bfe479cbd78e8ae744f4453cd324ebac9
Reviewed-on: https://chromium-review.googlesource.com/1066086
Commit-Ready: Benjamin Gordon <bmgordon@chromium.org>
Tested-by: Benjamin Gordon <bmgordon@chromium.org>
Reviewed-by: Mike Frysinger <vapier@chromium.org>

[modify] https://crrev.com/47366d42ecf8e3e763e14f45c5d2d2c590250f3f/x11-libs/gdk-pixbuf/gdk-pixbuf-2.22.1-r2.ebuild
[rename] https://crrev.com/47366d42ecf8e3e763e14f45c5d2d2c590250f3f/x11-libs/gdk-pixbuf/gdk-pixbuf-2.22.1-r5.ebuild

Project Member

Comment 2 by bugdroid1@chromium.org, May 23 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/portage-stable/+/0810b099c8c3be97035d48191141fc550debdb14

commit 0810b099c8c3be97035d48191141fc550debdb14
Author: Benjamin Gordon <bmgordon@chromium.org>
Date: Wed May 23 04:56:43 2018

eclass: Update haskell eclasses to upstream.

This brings the necessary eclasses for haskell ebuilds up to upstream
886be91c3059bff491055aff3b01eb3fa23b33ec from 2018-04-23.

BUG= chromium:844166 
TEST=sudo emerge cabal

Change-Id: I1808f1197de09981245df433a4fa12575c1946f7
Reviewed-on: https://chromium-review.googlesource.com/1065027
Commit-Ready: Benjamin Gordon <bmgordon@chromium.org>
Tested-by: Benjamin Gordon <bmgordon@chromium.org>
Reviewed-by: Chirantan Ekbote <chirantan@chromium.org>

[modify] https://crrev.com/0810b099c8c3be97035d48191141fc550debdb14/eclass/haskell-cabal.eclass
[modify] https://crrev.com/0810b099c8c3be97035d48191141fc550debdb14/eclass/ghc-package.eclass
[modify] https://crrev.com/0810b099c8c3be97035d48191141fc550debdb14/eclass/versionator.eclass

Project Member

Comment 3 by bugdroid1@chromium.org, May 23 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/portage-stable/+/1908acae4407cce4f10d3aaa04798de8c597522d

commit 1908acae4407cce4f10d3aaa04798de8c597522d
Author: Benjamin Gordon <bmgordon@chromium.org>
Date: Wed May 23 04:56:43 2018

portage-stable: New ebuilds for shellcheck dependencies

This imports the haskell compiler (ghc) and all of the dependencies for
dev-util/shellcheck.

Upgraded dev-lang/ghc to version 8.0.2 on amd64
Upgraded app-admin/haskell-updater to version 1.2.10 on amd64
Upgraded dev-haskell/hunit to version 1.2.5.2 on amd64
Upgraded dev-haskell/test-framework-quickcheck2 to version 0.3.0.3-r2 on amd64
Upgraded dev-haskell/test-framework-hunit to version 0.3.0 on amd64
Upgraded dev-haskell/test-framework to version 0.8.1.1 on amd64
Upgraded dev-haskell/libxml to version 0.1.1 on amd64
Upgraded dev-haskell/old-locale to version 1.0.0.7 on amd64
Upgraded dev-haskell/hostname to version 1.0 on amd64
Upgraded dev-haskell/xml to version 1.3.13 on amd64
Upgraded dev-haskell/ansi-wl-pprint to version 0.6.7.3 on amd64
Upgraded dev-haskell/regex-posix to version 0.95.2 on amd64
Upgraded dev-haskell/ansi-terminal to version 0.6.2.1 on amd64
Upgraded dev-haskell/extensible-exceptions to version 0.1.1.4 on amd64
Upgraded dev-haskell/tf-random to version 0.5 on amd64
Upgraded dev-haskell/primitive to version 0.5.1.0 on amd64
Upgraded dev-haskell/semigroups to version 0.18.2 on amd64
Upgraded dev-haskell/tagged to version 0.8.4 on amd64
Upgraded dev-haskell/unordered-containers to version 0.2.7.0 on amd64
Upgraded dev-haskell/bytestring-builder to version 0.10.6.0.0 on amd64
Upgraded dev-haskell/random to version 1.0.1.1-r1 on amd64
Upgraded dev-haskell/nats to version 1 on amd64
Upgraded dev-haskell/hashable to version 1.2.4.0 on amd64
Upgraded dev-haskell/quickcheck to version 2.9.2 on amd64
Upgraded dev-haskell/json to version 0.9.1 on amd64
Upgraded dev-haskell/syb to version 0.4.4 on amd64
Upgraded dev-haskell/regex-tdfa to version 1.2.0 on amd64
Upgraded dev-haskell/binary to version 0.7.6.1 on amd64
Upgraded dev-haskell/text to version 1.2.2.1 on amd64
Upgraded dev-haskell/regex-base to version 0.93.2-r1 on amd64
Upgraded dev-haskell/mtl to version 2.2.1-r1 on amd64
Upgraded dev-haskell/transformers to version 0.5.2.0 on amd64
Upgraded dev-haskell/parsec to version 3.1.9-r1 on amd64
Upgraded dev-haskell/cabal to version 1.24.2.0 on amd64

BUG= chromium:844166 
TEST=None

Change-Id: I670c8be81e957191151c9a93e83ec7813948993a
Reviewed-on: https://chromium-review.googlesource.com/1065028
Commit-Ready: Benjamin Gordon <bmgordon@chromium.org>
Tested-by: Benjamin Gordon <bmgordon@chromium.org>
Reviewed-by: Mike Frysinger <vapier@chromium.org>

[add] https://crrev.com/1908acae4407cce4f10d3aaa04798de8c597522d/dev-haskell/regex-tdfa/regex-tdfa-1.2.0.ebuild
[add] https://crrev.com/1908acae4407cce4f10d3aaa04798de8c597522d/dev-haskell/ansi-terminal/Manifest
[add] https://crrev.com/1908acae4407cce4f10d3aaa04798de8c597522d/dev-lang/ghc/files/ghc-8.2.1_rc1-hp2ps-cross.patch
[add] https://crrev.com/1908acae4407cce4f10d3aaa04798de8c597522d/metadata/md5-cache/dev-haskell/test-framework-hunit-0.3.0
[add] https://crrev.com/1908acae4407cce4f10d3aaa04798de8c597522d/dev-haskell/bytestring-builder/metadata.xml
[add] https://crrev.com/1908acae4407cce4f10d3aaa04798de8c597522d/dev-haskell/regex-tdfa/metadata.xml
[add] https://crrev.com/1908acae4407cce4f10d3aaa04798de8c597522d/dev-haskell/hostname/hostname-1.0.ebuild
[add] https://crrev.com/1908acae4407cce4f10d3aaa04798de8c597522d/metadata/md5-cache/dev-haskell/xml-1.3.13
[add] https://crrev.com/1908acae4407cce4f10d3aaa04798de8c597522d/dev-haskell/primitive/primitive-0.5.1.0.ebuild
[add] https://crrev.com/1908acae4407cce4f10d3aaa04798de8c597522d/dev-haskell/parsec/parsec-3.1.9-r1.ebuild
[add] https://crrev.com/1908acae4407cce4f10d3aaa04798de8c597522d/dev-haskell/ansi-terminal/ansi-terminal-0.6.2.1.ebuild
[add] https://crrev.com/1908acae4407cce4f10d3aaa04798de8c597522d/dev-haskell/cabal/cabal-1.24.2.0.ebuild
[add] https://crrev.com/1908acae4407cce4f10d3aaa04798de8c597522d/dev-haskell/tf-random/Manifest
[add] https://crrev.com/1908acae4407cce4f10d3aaa04798de8c597522d/dev-haskell/xml/metadata.xml
[add] https://crrev.com/1908acae4407cce4f10d3aaa04798de8c597522d/dev-haskell/tf-random/metadata.xml
[add] https://crrev.com/1908acae4407cce4f10d3aaa04798de8c597522d/dev-haskell/text/metadata.xml
[add] https://crrev.com/1908acae4407cce4f10d3aaa04798de8c597522d/metadata/md5-cache/dev-haskell/tagged-0.8.4
[add] https://crrev.com/1908acae4407cce4f10d3aaa04798de8c597522d/dev-haskell/regex-posix/Manifest
[add] https://crrev.com/1908acae4407cce4f10d3aaa04798de8c597522d/dev-haskell/quickcheck/files/quickcheck-1.2.0.1-ghc-7.10.patch
[add] https://crrev.com/1908acae4407cce4f10d3aaa04798de8c597522d/dev-haskell/hashable/hashable-1.2.4.0.ebuild
[add] https://crrev.com/1908acae4407cce4f10d3aaa04798de8c597522d/app-admin/haskell-updater/Manifest
[add] https://crrev.com/1908acae4407cce4f10d3aaa04798de8c597522d/dev-haskell/test-framework-hunit/test-framework-hunit-0.3.0.ebuild
[add] https://crrev.com/1908acae4407cce4f10d3aaa04798de8c597522d/dev-lang/ghc/files/ghc-7.8.1_rc1-libbfd.patch
[add] https://crrev.com/1908acae4407cce4f10d3aaa04798de8c597522d/dev-haskell/test-framework/metadata.xml
[add] https://crrev.com/1908acae4407cce4f10d3aaa04798de8c597522d/dev-haskell/text/Manifest
[add] https://crrev.com/1908acae4407cce4f10d3aaa04798de8c597522d/dev-lang/ghc/files/ghc-7.8.4-gold.patch
[add] https://crrev.com/1908acae4407cce4f10d3aaa04798de8c597522d/dev-haskell/test-framework-hunit/Manifest
[add] https://crrev.com/1908acae4407cce4f10d3aaa04798de8c597522d/metadata/md5-cache/dev-haskell/cabal-1.24.2.0
[add] https://crrev.com/1908acae4407cce4f10d3aaa04798de8c597522d/dev-haskell/transformers/Manifest
[add] https://crrev.com/1908acae4407cce4f10d3aaa04798de8c597522d/dev-haskell/hashable/Manifest
[add] https://crrev.com/1908acae4407cce4f10d3aaa04798de8c597522d/dev-haskell/ansi-wl-pprint/Manifest
[add] https://crrev.com/1908acae4407cce4f10d3aaa04798de8c597522d/dev-lang/ghc/files/ghc-8.0.2-O2-unreg.patch
[add] https://crrev.com/1908acae4407cce4f10d3aaa04798de8c597522d/dev-haskell/quickcheck/quickcheck-2.9.2.ebuild
[add] https://crrev.com/1908acae4407cce4f10d3aaa04798de8c597522d/dev-haskell/libxml/Manifest
[add] https://crrev.com/1908acae4407cce4f10d3aaa04798de8c597522d/dev-haskell/unordered-containers/Manifest
[add] https://crrev.com/1908acae4407cce4f10d3aaa04798de8c597522d/dev-haskell/mtl/mtl-2.2.1-r1.ebuild
[add] https://crrev.com/1908acae4407cce4f10d3aaa04798de8c597522d/dev-haskell/transformers/metadata.xml
[add] https://crrev.com/1908acae4407cce4f10d3aaa04798de8c597522d/metadata/md5-cache/dev-haskell/ansi-wl-pprint-0.6.7.3
[add] https://crrev.com/1908acae4407cce4f10d3aaa04798de8c597522d/dev-haskell/text/files/text-1.2.2.0-integer-simple.patch
[add] https://crrev.com/1908acae4407cce4f10d3aaa04798de8c597522d/dev-haskell/random/random-1.0.1.1-r1.ebuild
[add] https://crrev.com/1908acae4407cce4f10d3aaa04798de8c597522d/dev-haskell/semigroups/metadata.xml
[add] https://crrev.com/1908acae4407cce4f10d3aaa04798de8c597522d/metadata/md5-cache/dev-lang/ghc-8.0.2
[add] https://crrev.com/1908acae4407cce4f10d3aaa04798de8c597522d/dev-haskell/syb/metadata.xml
[add] https://crrev.com/1908acae4407cce4f10d3aaa04798de8c597522d/metadata/md5-cache/dev-haskell/parsec-3.1.9-r1
[add] https://crrev.com/1908acae4407cce4f10d3aaa04798de8c597522d/dev-lang/ghc/files/ghc-7.10.1-rc3-ghc-7.10-bootstrap.patch
[add] https://crrev.com/1908acae4407cce4f10d3aaa04798de8c597522d/metadata/md5-cache/dev-haskell/mtl-2.2.1-r1
[add] https://crrev.com/1908acae4407cce4f10d3aaa04798de8c597522d/dev-haskell/cabal/metadata.xml
[add] https://crrev.com/1908acae4407cce4f10d3aaa04798de8c597522d/metadata/md5-cache/dev-haskell/text-1.2.2.1
[add] https://crrev.com/1908acae4407cce4f10d3aaa04798de8c597522d/metadata/md5-cache/dev-haskell/transformers-0.5.2.0
[add] https://crrev.com/1908acae4407cce4f10d3aaa04798de8c597522d/dev-haskell/hostname/metadata.xml
[add] https://crrev.com/1908acae4407cce4f10d3aaa04798de8c597522d/dev-haskell/primitive/metadata.xml
[add] https://crrev.com/1908acae4407cce4f10d3aaa04798de8c597522d/dev-haskell/bytestring-builder/bytestring-builder-0.10.6.0.0.ebuild
[add] https://crrev.com/1908acae4407cce4f10d3aaa04798de8c597522d/dev-haskell/parsec/Manifest
[add] https://crrev.com/1908acae4407cce4f10d3aaa04798de8c597522d/dev-lang/ghc/files/ghc-7.8.3-ppc32-fPIC.patch
[add] https://crrev.com/1908acae4407cce4f10d3aaa04798de8c597522d/dev-lang/ghc/files/ghc-8.2.1_rc1-win32-cross-2-hack.patch
[add] https://crrev.com/1908acae4407cce4f10d3aaa04798de8c597522d/metadata/md5-cache/dev-haskell/extensible-exceptions-0.1.1.4
[add] https://crrev.com/1908acae4407cce4f10d3aaa04798de8c597522d/dev-haskell/nats/metadata.xml
[add] https://crrev.com/1908acae4407cce4f10d3aaa04798de8c597522d/dev-lang/ghc/files/ghc-8.2.1_rc1-staged-cross.patch
[add] https://crrev.com/1908acae4407cce4f10d3aaa04798de8c597522d/metadata/md5-cache/dev-haskell/unordered-containers-0.2.7.0
[add] https://crrev.com/1908acae4407cce4f10d3aaa04798de8c597522d/dev-haskell/nats/Manifest
[add] https://crrev.com/1908acae4407cce4f10d3aaa04798de8c597522d/dev-haskell/libxml/libxml-0.1.1.ebuild
[add] https://crrev.com/1908acae4407cce4f10d3aaa04798de8c597522d/dev-haskell/old-locale/metadata.xml
[add] https://crrev.com/1908acae4407cce4f10d3aaa04798de8c597522d/dev-haskell/bytestring-builder/Manifest
[add] https://crrev.com/1908acae4407cce4f10d3aaa04798de8c597522d/dev-haskell/random/Manifest
[add] https://crrev.com/1908acae4407cce4f10d3aaa04798de8c597522d/dev-haskell/tf-random/tf-random-0.5.ebuild
[add] https://crrev.com/1908acae4407cce4f10d3aaa04798de8c597522d/dev-lang/ghc/files/ghc-8.0.2-libffi-alpha.patch
[add] https://crrev.com/1908acae4407cce4f10d3aaa04798de8c597522d/dev-lang/ghc/files/ghc-8.0.1_rc1-cgen-constify.patch
[add] https://crrev.com/1908acae4407cce4f10d3aaa04798de8c597522d/dev-haskell/hostname/Manifest
[add] https://crrev.com/1908acae4407cce4f10d3aaa04798de8c597522d/dev-haskell/json/Manifest
[add] https://crrev.com/1908acae4407cce4f10d3aaa04798de8c597522d/dev-haskell/extensible-exceptions/metadata.xml
[add] https://crrev.com/1908acae4407cce4f10d3aaa04798de8c597522d/dev-haskell/ansi-wl-pprint/metadata.xml
[add] https://crrev.com/1908acae4407cce4f10d3aaa04798de8c597522d/metadata/md5-cache/dev-haskell/primitive-0.5.1.0
[add] https://crrev.com/1908acae4407cce4f10d3aaa04798de8c597522d/dev-haskell/text/files/text-1.1.1.3-deepseq-1.4.patch
[add] https://crrev.com/1908acae4407cce4f10d3aaa04798de8c597522d/dev-lang/ghc/Manifest
[add] https://crrev.com/1908acae4407cce4f10d3aaa04798de8c597522d/metadata/md5-cache/dev-haskell/regex-posix-0.95.2
[add] https://crrev.com/1908acae4407cce4f10d3aaa04798de8c597522d/dev-haskell/binary/metadata.xml
[add] https://crrev.com/1908acae4407cce4f10d3aaa04798de8c597522d/dev-haskell/syb/syb-0.4.4.ebuild
[add] https://crrev.com/1908acae4407cce4f10d3aaa04798de8c597522d/metadata/md5-cache/dev-haskell/semigroups-0.18.2
[add] https://crrev.com/1908acae4407cce4f10d3aaa04798de8c597522d/dev-haskell/tagged/metadata.xml
[add] https://crrev.com/1908acae4407cce4f10d3aaa04798de8c597522d/dev-haskell/tagged/tagged-0.8.4.ebuild
[add] https://crrev.com/1908acae4407cce4f10d3aaa04798de8c597522d/dev-lang/ghc/files/ghc-8.2.1_rc3-stginit-data.patch
[add] https://crrev.com/1908acae4407cce4f10d3aaa04798de8c597522d/dev-haskell/primitive/Manifest
[add] https://crrev.com/1908acae4407cce4f10d3aaa04798de8c597522d/dev-lang/ghc/files/ghc-8.2.1_rc1-ghci-cross.patch
[add] https://crrev.com/1908acae4407cce4f10d3aaa04798de8c597522d/dev-lang/ghc/ghc-8.0.2.ebuild
[add] https://crrev.com/1908acae4407cce4f10d3aaa04798de8c597522d/dev-haskell/regex-base/regex-base-0.93.2-r1.ebuild
[add] https://crrev.com/1908acae4407cce4f10d3aaa04798de8c597522d/dev-haskell/binary/Manifest
[add] https://crrev.com/1908acae4407cce4f10d3aaa04798de8c597522d/dev-haskell/test-framework/test-framework-0.8.1.1.ebuild
[add] https://crrev.com/1908acae4407cce4f10d3aaa04798de8c597522d/metadata/md5-cache/dev-haskell/ansi-terminal-0.6.2.1
[add] https://crrev.com/1908acae4407cce4f10d3aaa04798de8c597522d/dev-haskell/test-framework-hunit/metadata.xml
[add] https://crrev.com/1908acae4407cce4f10d3aaa04798de8c597522d/metadata/md5-cache/dev-haskell/hunit-1.2.5.2
[add] https://crrev.com/1908acae4407cce4f10d3aaa04798de8c597522d/dev-haskell/mtl/Manifest
[add] https://crrev.com/1908acae4407cce4f10d3aaa04798de8c597522d/dev-haskell/transformers/transformers-0.5.2.0.ebuild
[add] https://crrev.com/1908acae4407cce4f10d3aaa04798de8c597522d/dev-lang/ghc/files/ghc-8.2.1-darwin.patch
[add] https://crrev.com/1908acae4407cce4f10d3aaa04798de8c597522d/dev-haskell/quickcheck/Manifest
[add] https://crrev.com/1908acae4407cce4f10d3aaa04798de8c597522d/dev-lang/ghc/files/ghc-7.8.3-pic-sparc.patch
[add] https://crrev.com/1908acae4407cce4f10d3aaa04798de8c597522d/dev-haskell/text/text-1.2.2.1.ebuild
[add] https://crrev.com/1908acae4407cce4f10d3aaa04798de8c597522d/dev-haskell/hunit/Manifest
[add] https://crrev.com/1908acae4407cce4f10d3aaa04798de8c597522d/metadata/md5-cache/dev-haskell/quickcheck-2.9.2
[add] https://crrev.com/1908acae4407cce4f10d3aaa04798de8c597522d/metadata/md5-cache/dev-haskell/hostname-1.0
[add] https://crrev.com/1908acae4407cce4f10d3aaa04798de8c597522d/dev-haskell/quickcheck/metadata.xml
[add] https://crrev.com/1908acae4407cce4f10d3aaa04798de8c597522d/dev-lang/ghc/files/ghc-7.8.3-linker-warn.patch
[add] https://crrev.com/1908acae4407cce4f10d3aaa04798de8c597522d/dev-haskell/regex-posix/metadata.xml
[add] https://crrev.com/1908acae4407cce4f10d3aaa04798de8c597522d/dev-lang/ghc/files/ghc-8.2.1_rc1-unphased-cross.patch
[add] https://crrev.com/1908acae4407cce4f10d3aaa04798de8c597522d/dev-haskell/regex-base/Manifest
[add] https://crrev.com/1908acae4407cce4f10d3aaa04798de8c597522d/dev-lang/ghc/files/ghc-7.8.3-prim-lm.patch
[add] https://crrev.com/1908acae4407cce4f10d3aaa04798de8c597522d/dev-haskell/hashable/metadata.xml
[add] https://crrev.com/1908acae4407cce4f10d3aaa04798de8c597522d/app-admin/haskell-updater/haskell-updater-1.2.10.ebuild
[add] https://crrev.com/1908acae4407cce4f10d3aaa04798de8c597522d/metadata/md5-cache/dev-haskell/random-1.0.1.1-r1
[add] https://crrev.com/1908acae4407cce4f10d3aaa04798de8c597522d/dev-haskell/unordered-containers/unordered-containers-0.2.7.0.ebuild
[add] https://crrev.com/1908acae4407cce4f10d3aaa04798de8c597522d/dev-lang/ghc/files/ghc-8.2.1_rc3-any-vendor.patch
[add] https://crrev.com/1908acae4407cce4f10d3aaa04798de8c597522d/dev-haskell/old-locale/old-locale-1.0.0.7.ebuild
[add] https://crrev.com/1908acae4407cce4f10d3aaa04798de8c597522d/dev-lang/ghc/files/ghc-8.0.1-ww-args-limit.patch
[add] https://crrev.com/1908acae4407cce4f10d3aaa04798de8c597522d/metadata/md5-cache/dev-haskell/hashable-1.2.4.0
[add] https://crrev.com/1908acae4407cce4f10d3aaa04798de8c597522d/dev-haskell/xml/xml-1.3.13.ebuild
[add] https://crrev.com/1908acae4407cce4f10d3aaa04798de8c597522d/dev-haskell/nats/nats-1.ebuild
[add] https://crrev.com/1908acae4407cce4f10d3aaa04798de8c597522d/dev-haskell/extensible-exceptions/extensible-exceptions-0.1.1.4.ebuild
[add] https://crrev.com/1908acae4407cce4f10d3aaa04798de8c597522d/dev-haskell/ansi-wl-pprint/ansi-wl-pprint-0.6.7.3.ebuild
[add] https://crrev.com/1908acae4407cce4f10d3aaa04798de8c597522d/dev-haskell/semigroups/semigroups-0.18.2.ebuild
[add] https://crrev.com/1908acae4407cce4f10d3aaa04798de8c597522d/metadata/md5-cache/dev-haskell/syb-0.4.4
[add] https://crrev.com/1908acae4407cce4f10d3aaa04798de8c597522d/dev-haskell/xml/Manifest
[add] https://crrev.com/1908acae4407cce4f10d3aaa04798de8c597522d/dev-haskell/regex-base/metadata.xml
[add] https://crrev.com/1908acae4407cce4f10d3aaa04798de8c597522d/metadata/md5-cache/dev-haskell/binary-0.7.6.1
[add] https://crrev.com/1908acae4407cce4f10d3aaa04798de8c597522d/dev-haskell/test-framework/Manifest
[add] https://crrev.com/1908acae4407cce4f10d3aaa04798de8c597522d/dev-lang/ghc/files/ghc-7.6.3-preserve-inplace-xattr.patch
[add] https://crrev.com/1908acae4407cce4f10d3aaa04798de8c597522d/dev-haskell/tagged/Manifest
[add] https://crrev.com/1908acae4407cce4f10d3aaa04798de8c597522d/dev-lang/ghc/files/ghc-7.8.2-cgen-constify.patch
[add] https://crrev.com/1908acae4407cce4f10d3aaa04798de8c597522d/metadata/md5-cache/dev-haskell/old-locale-1.0.0.7
[add] https://crrev.com/1908acae4407cce4f10d3aaa04798de8c597522d/dev-haskell/json/json-0.9.1.ebuild
[add] https://crrev.com/1908acae4407cce4f10d3aaa04798de8c597522d/dev-lang/ghc/files/ghc-8.0.2_rc2-old-sphinx.patch
[add] https://crrev.com/1908acae4407cce4f10d3aaa04798de8c597522d/dev-haskell/regex-tdfa/Manifest
[add] https://crrev.com/1908acae4407cce4f10d3aaa04798de8c597522d/dev-lang/ghc/files/ghc-8.0.1-limit-jN.patch
[add] https://crrev.com/1908acae4407cce4f10d3aaa04798de8c597522d/dev-haskell/mtl/metadata.xml
[add] https://crrev.com/1908acae4407cce4f10d3aaa04798de8c597522d/dev-lang/ghc/files/ghc-7.10.3-relnotes.patch
[add] https://crrev.com/1908acae4407cce4f10d3aaa04798de8c597522d/dev-haskell/hunit/metadata.xml
[add] https://crrev.com/1908acae4407cce4f10d3aaa04798de8c597522d/dev-haskell/semigroups/files/semigroups-0.15.1-trust.patch
[add] https://crrev.com/1908acae4407cce4f10d3aaa04798de8c597522d/metadata/md5-cache/dev-haskell/libxml-0.1.1
[add] https://crrev.com/1908acae4407cce4f10d3aaa04798de8c597522d/dev-lang/ghc/metadata.xml
[add] https://crrev.com/1908acae4407cce4f10d3aaa04798de8c597522d/dev-haskell/json/metadata.xml
[add] https://crrev.com/1908acae4407cce4f10d3aaa04798de8c597522d/metadata/md5-cache/dev-haskell/bytestring-builder-0.10.6.0.0
[add] https://crrev.com/1908acae4407cce4f10d3aaa04798de8c597522d/dev-haskell/test-framework-quickcheck2/Manifest
[add] https://crrev.com/1908acae4407cce4f10d3aaa04798de8c597522d/dev-lang/ghc/files/ghc-8.2.1_rc1-cgen-constify.patch
[add] https://crrev.com/1908acae4407cce4f10d3aaa04798de8c597522d/metadata/md5-cache/dev-haskell/nats-1
[add] https://crrev.com/1908acae4407cce4f10d3aaa04798de8c597522d/dev-lang/ghc/files/ghc-7.0.4-CHOST-prefix.patch
[add] https://crrev.com/1908acae4407cce4f10d3aaa04798de8c597522d/metadata/md5-cache/dev-haskell/tf-random-0.5
[add] https://crrev.com/1908acae4407cce4f10d3aaa04798de8c597522d/dev-haskell/test-framework-quickcheck2/test-framework-quickcheck2-0.3.0.3-r2.ebuild
[add] https://crrev.com/1908acae4407cce4f10d3aaa04798de8c597522d/dev-haskell/libxml/metadata.xml
[add] https://crrev.com/1908acae4407cce4f10d3aaa04798de8c597522d/app-admin/haskell-updater/metadata.xml
[add] https://crrev.com/1908acae4407cce4f10d3aaa04798de8c597522d/dev-haskell/syb/Manifest
[add] https://crrev.com/1908acae4407cce4f10d3aaa04798de8c597522d/dev-haskell/test-framework-quickcheck2/metadata.xml
[add] https://crrev.com/1908acae4407cce4f10d3aaa04798de8c597522d/metadata/md5-cache/dev-haskell/json-0.9.1
[add] https://crrev.com/1908acae4407cce4f10d3aaa04798de8c597522d/metadata/md5-cache/dev-haskell/test-framework-0.8.1.1
[add] https://crrev.com/1908acae4407cce4f10d3aaa04798de8c597522d/dev-haskell/semigroups/Manifest
[add] https://crrev.com/1908acae4407cce4f10d3aaa04798de8c597522d/dev-haskell/unordered-containers/metadata.xml
[add] https://crrev.com/1908acae4407cce4f10d3aaa04798de8c597522d/dev-lang/ghc/files/ghc-8.2.1_rc2-O2-unreg.patch
[add] https://crrev.com/1908acae4407cce4f10d3aaa04798de8c597522d/dev-haskell/regex-posix/regex-posix-0.95.2.ebuild
[add] https://crrev.com/1908acae4407cce4f10d3aaa04798de8c597522d/dev-lang/ghc/files/ghc-bash-completion
[add] https://crrev.com/1908acae4407cce4f10d3aaa04798de8c597522d/dev-haskell/old-locale/Manifest
[add] https://crrev.com/1908acae4407cce4f10d3aaa04798de8c597522d/dev-haskell/binary/binary-0.7.6.1.ebuild
[add] https://crrev.com/1908acae4407cce4f10d3aaa04798de8c597522d/dev-haskell/hunit/hunit-1.2.5.2.ebuild
[add] https://crrev.com/1908acae4407cce4f10d3aaa04798de8c597522d/dev-haskell/random/metadata.xml
[add] https://crrev.com/1908acae4407cce4f10d3aaa04798de8c597522d/dev-lang/ghc/files/ghc-8.2.1_rc1-win32-cross-1.patch
[add] https://crrev.com/1908acae4407cce4f10d3aaa04798de8c597522d/dev-haskell/regex-posix/files/regex-posix-0.95.1-ghc-7.5.patch
[add] https://crrev.com/1908acae4407cce4f10d3aaa04798de8c597522d/dev-haskell/cabal/files/cabal-2.0.0.2-no-bootstrap.patch
[add] https://crrev.com/1908acae4407cce4f10d3aaa04798de8c597522d/dev-haskell/parsec/metadata.xml
[add] https://crrev.com/1908acae4407cce4f10d3aaa04798de8c597522d/dev-lang/ghc/files/ghc-7.8.4-ia64-CLOSUREs.patch
[add] https://crrev.com/1908acae4407cce4f10d3aaa04798de8c597522d/dev-lang/ghc/files/ghc-8.0.1-par-g0-on-A32.patch
[add] https://crrev.com/1908acae4407cce4f10d3aaa04798de8c597522d/metadata/md5-cache/app-admin/haskell-updater-1.2.10
[add] https://crrev.com/1908acae4407cce4f10d3aaa04798de8c597522d/metadata/md5-cache/dev-haskell/regex-base-0.93.2-r1
[add] https://crrev.com/1908acae4407cce4f10d3aaa04798de8c597522d/dev-haskell/syb/files/syb-0.4.3-ghc-7.10.patch
[add] https://crrev.com/1908acae4407cce4f10d3aaa04798de8c597522d/dev-lang/ghc/files/ghc-8.2.1_rc1-stage2-cross.patch
[add] https://crrev.com/1908acae4407cce4f10d3aaa04798de8c597522d/dev-lang/ghc/files/ghc-7.10.3-hardfloat.patch
[add] https://crrev.com/1908acae4407cce4f10d3aaa04798de8c597522d/metadata/md5-cache/dev-haskell/regex-tdfa-1.2.0
[add] https://crrev.com/1908acae4407cce4f10d3aaa04798de8c597522d/dev-haskell/extensible-exceptions/Manifest
[add] https://crrev.com/1908acae4407cce4f10d3aaa04798de8c597522d/metadata/md5-cache/dev-haskell/test-framework-quickcheck2-0.3.0.3-r2
[add] https://crrev.com/1908acae4407cce4f10d3aaa04798de8c597522d/dev-haskell/cabal/Manifest
[add] https://crrev.com/1908acae4407cce4f10d3aaa04798de8c597522d/dev-haskell/ansi-terminal/metadata.xml

Project Member

Comment 4 by bugdroid1@chromium.org, May 23 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/portage-stable/+/7f1073673c42ba8f05e33d3dd8bbea702669a05a

commit 7f1073673c42ba8f05e33d3dd8bbea702669a05a
Author: Benjamin Gordon <bmgordon@chromium.org>
Date: Wed May 23 04:56:44 2018

dev-util/shellcheck: New ebuild

This adds dev-util/shellcheck version 0.4.7 for the host.  The new
ebuild isn't linked into any SDK dependencies, so it won't be built by
default, but now we can start playing with it.

BUG= chromium:844166 
TEST=sudo emerge shellcheck

Change-Id: I514cefa29daf00efef5cce60a542ee04c0637564
Reviewed-on: https://chromium-review.googlesource.com/1065029
Commit-Ready: Benjamin Gordon <bmgordon@chromium.org>
Tested-by: Benjamin Gordon <bmgordon@chromium.org>
Reviewed-by: Mike Frysinger <vapier@chromium.org>

[add] https://crrev.com/7f1073673c42ba8f05e33d3dd8bbea702669a05a/dev-util/shellcheck/Manifest
[add] https://crrev.com/7f1073673c42ba8f05e33d3dd8bbea702669a05a/dev-util/shellcheck/metadata.xml
[add] https://crrev.com/7f1073673c42ba8f05e33d3dd8bbea702669a05a/metadata/md5-cache/dev-util/shellcheck-0.4.7
[add] https://crrev.com/7f1073673c42ba8f05e33d3dd8bbea702669a05a/dev-util/shellcheck/shellcheck-0.4.7.ebuild

My initial trial run suggests that this adds ~200MB to the compressed SDK tarball and ~1.1GB to the uncompressed chroot.  If we can change shellcheck to be statically linked, the needed runtime is ~20MB uncompressed and the rest is built-time-only dependencies.  I'm looking into how much surgery in make_chroot.sh this would need.
Project Member

Comment 6 by bugdroid1@chromium.org, May 26 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/chromite/+/a29e19d9f75dbfcf53d2bc3d2d9989dc503257b9

commit a29e19d9f75dbfcf53d2bc3d2d9989dc503257b9
Author: Benjamin Gordon <bmgordon@chromium.org>
Date: Sat May 26 07:21:43 2018

cros lint: Run shellcheck if it is available

shellcheck is available outside the chroot through apt-get or dnf.  As
of crrev.com/c/1065029, it is also available in the chroot if the user
has emerged it.  Make cros lint try to run it for shell files so we can
start collecting data about what it finds.  For now, both the presence
of shellcheck and any errors it produces are considered non-blocking.

BUG= chromium:844166 ,  chromium:682860 
TEST=cros lint .../dev-util/shellcheck/shellcheck-0.4.7.ebuild

Change-Id: I332ff3fec34f6dd9bcf35125d84aaf4f7fa9bf44
Reviewed-on: https://chromium-review.googlesource.com/1070410
Commit-Ready: Benjamin Gordon <bmgordon@chromium.org>
Tested-by: Benjamin Gordon <bmgordon@chromium.org>
Reviewed-by: Mike Frysinger <vapier@chromium.org>

[modify] https://crrev.com/a29e19d9f75dbfcf53d2bc3d2d9989dc503257b9/cli/cros/cros_lint.py

Project Member

Comment 7 by bugdroid1@chromium.org, May 26 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/chromite/+/603af0111ae82ca5f785b2142779c72dc23cf916

commit 603af0111ae82ca5f785b2142779c72dc23cf916
Author: Benjamin Gordon <bmgordon@chromium.org>
Date: Sat May 26 07:21:42 2018

cros lint: Call shell linter based on extensions

The shell linter is currently called for files that contain a shell
shebang, but not based on extension.  Add some shell extensions to the
list so they get picked up regardless of the shebang.

BUG= chromium:844166 
TEST=cros lint .../dev-util/shellcheck/shellcheck-0.4.7.ebuild

Change-Id: I9221a18249b415283b1630ab7226c1bbaf26243d
Reviewed-on: https://chromium-review.googlesource.com/1071867
Commit-Ready: Benjamin Gordon <bmgordon@chromium.org>
Tested-by: Benjamin Gordon <bmgordon@chromium.org>
Reviewed-by: Mike Frysinger <vapier@chromium.org>

[modify] https://crrev.com/603af0111ae82ca5f785b2142779c72dc23cf916/cli/cros/cros_lint.py

Project Member

Comment 8 by bugdroid1@chromium.org, May 26 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4b00245a305aa1273434d2a67b24b5498fafea72

commit 4b00245a305aa1273434d2a67b24b5498fafea72
Author: chromite-chromium-autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Date: Sat May 26 10:11:54 2018

Roll src/third_party/chromite/ 046952c65..a29e19d9f (2 commits)

https://chromium.googlesource.com/chromiumos/chromite.git/+log/046952c65549..a29e19d9f75d

$ git log 046952c65..a29e19d9f --date=short --no-merges --format='%ad %ae %s'
2018-05-23 bmgordon cros lint: Run shellcheck if it is available
2018-05-24 bmgordon cros lint: Call shell linter based on extensions

Created with:
  roll-dep src/third_party/chromite
BUG= chromium:844166 , chromium:682860 , chromium:844166 


The AutoRoll server is located here: https://chromite-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=chrome-os-gardeners@chromium.org

Change-Id: Ibdb4b4bce29bd0440f4d111914856e148ab8b31f
Reviewed-on: https://chromium-review.googlesource.com/1074492
Reviewed-by: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#562122}
[modify] https://crrev.com/4b00245a305aa1273434d2a67b24b5498fafea72/DEPS

Project Member

Comment 9 by bugdroid1@chromium.org, Sep 28

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/portage-stable/+/8226336494eaea967f15e5983f8a17397f990289

commit 8226336494eaea967f15e5983f8a17397f990289
Author: Benjamin Gordon <bmgordon@chromium.org>
Date: Fri Sep 28 02:43:53 2018

portage-stable: New ebuilds for shellcheck upgrade

This imports new haskell dependencies that will be required by an
upgrade to shellcheck 0.5.0.

Upgraded dev-haskell/aeson to version 1.0.2.1 on amd64
Upgraded dev-haskell/dlist to version 0.8.0.2 on amd64
Upgraded dev-haskell/attoparsec to version 0.13.0.1 on amd64
Upgraded dev-haskell/scientific to version 0.3.4.9 on amd64
Upgraded dev-haskell/vector to version 0.11.0.0 on amd64
Upgraded dev-haskell/time-locale-compat to version 0.1.1.1 on amd64
Upgraded dev-haskell/fail to version 4.9.0.0 on amd64
Upgraded dev-haskell/base-compat to version 0.9.1 on amd64
Upgraded dev-haskell/transformers-compat to version 0.5.1.4 on amd64

BUG= chromium:844166 
TEST=sudo emerge shellcheck

Change-Id: I87952a8afb8cb5c29b007730d62f2b2d59ef5c70
Reviewed-on: https://chromium-review.googlesource.com/1244120
Commit-Ready: Benjamin Gordon <bmgordon@chromium.org>
Tested-by: Benjamin Gordon <bmgordon@chromium.org>
Reviewed-by: Mike Frysinger <vapier@chromium.org>

[add] https://crrev.com/8226336494eaea967f15e5983f8a17397f990289/dev-haskell/scientific/Manifest
[add] https://crrev.com/8226336494eaea967f15e5983f8a17397f990289/dev-haskell/vector/files/vector-0.11.0.0-primitive-0.6.2.0.patch
[add] https://crrev.com/8226336494eaea967f15e5983f8a17397f990289/dev-haskell/fail/metadata.xml
[add] https://crrev.com/8226336494eaea967f15e5983f8a17397f990289/dev-haskell/aeson/Manifest
[add] https://crrev.com/8226336494eaea967f15e5983f8a17397f990289/dev-haskell/dlist/metadata.xml
[add] https://crrev.com/8226336494eaea967f15e5983f8a17397f990289/dev-haskell/time-locale-compat/time-locale-compat-0.1.1.1.ebuild
[add] https://crrev.com/8226336494eaea967f15e5983f8a17397f990289/dev-haskell/vector/vector-0.11.0.0.ebuild
[add] https://crrev.com/8226336494eaea967f15e5983f8a17397f990289/metadata/md5-cache/dev-haskell/transformers-compat-0.5.1.4
[add] https://crrev.com/8226336494eaea967f15e5983f8a17397f990289/dev-haskell/base-compat/Manifest
[add] https://crrev.com/8226336494eaea967f15e5983f8a17397f990289/metadata/md5-cache/dev-haskell/aeson-1.0.2.1
[add] https://crrev.com/8226336494eaea967f15e5983f8a17397f990289/metadata/md5-cache/dev-haskell/fail-4.9.0.0
[add] https://crrev.com/8226336494eaea967f15e5983f8a17397f990289/dev-haskell/fail/fail-4.9.0.0.ebuild
[add] https://crrev.com/8226336494eaea967f15e5983f8a17397f990289/dev-haskell/transformers-compat/metadata.xml
[add] https://crrev.com/8226336494eaea967f15e5983f8a17397f990289/dev-haskell/time-locale-compat/Manifest
[add] https://crrev.com/8226336494eaea967f15e5983f8a17397f990289/dev-haskell/attoparsec/metadata.xml
[add] https://crrev.com/8226336494eaea967f15e5983f8a17397f990289/dev-haskell/aeson/metadata.xml
[add] https://crrev.com/8226336494eaea967f15e5983f8a17397f990289/dev-haskell/vector/Manifest
[add] https://crrev.com/8226336494eaea967f15e5983f8a17397f990289/dev-haskell/dlist/dlist-0.8.0.2.ebuild
[add] https://crrev.com/8226336494eaea967f15e5983f8a17397f990289/dev-haskell/dlist/Manifest
[add] https://crrev.com/8226336494eaea967f15e5983f8a17397f990289/dev-haskell/transformers-compat/Manifest
[add] https://crrev.com/8226336494eaea967f15e5983f8a17397f990289/dev-haskell/base-compat/base-compat-0.9.1.ebuild
[add] https://crrev.com/8226336494eaea967f15e5983f8a17397f990289/dev-haskell/time-locale-compat/metadata.xml
[add] https://crrev.com/8226336494eaea967f15e5983f8a17397f990289/metadata/md5-cache/dev-haskell/attoparsec-0.13.0.1
[add] https://crrev.com/8226336494eaea967f15e5983f8a17397f990289/dev-haskell/attoparsec/Manifest
[add] https://crrev.com/8226336494eaea967f15e5983f8a17397f990289/metadata/md5-cache/dev-haskell/dlist-0.8.0.2
[add] https://crrev.com/8226336494eaea967f15e5983f8a17397f990289/dev-haskell/scientific/metadata.xml
[add] https://crrev.com/8226336494eaea967f15e5983f8a17397f990289/dev-haskell/fail/Manifest
[add] https://crrev.com/8226336494eaea967f15e5983f8a17397f990289/dev-haskell/aeson/aeson-1.0.2.1.ebuild
[add] https://crrev.com/8226336494eaea967f15e5983f8a17397f990289/dev-haskell/base-compat/metadata.xml
[add] https://crrev.com/8226336494eaea967f15e5983f8a17397f990289/metadata/md5-cache/dev-haskell/time-locale-compat-0.1.1.1
[add] https://crrev.com/8226336494eaea967f15e5983f8a17397f990289/metadata/md5-cache/dev-haskell/base-compat-0.9.1
[add] https://crrev.com/8226336494eaea967f15e5983f8a17397f990289/dev-haskell/scientific/scientific-0.3.4.9.ebuild
[add] https://crrev.com/8226336494eaea967f15e5983f8a17397f990289/metadata/md5-cache/dev-haskell/scientific-0.3.4.9
[add] https://crrev.com/8226336494eaea967f15e5983f8a17397f990289/dev-haskell/transformers-compat/transformers-compat-0.5.1.4.ebuild
[add] https://crrev.com/8226336494eaea967f15e5983f8a17397f990289/dev-haskell/attoparsec/attoparsec-0.13.0.1.ebuild
[add] https://crrev.com/8226336494eaea967f15e5983f8a17397f990289/metadata/md5-cache/dev-haskell/vector-0.11.0.0
[add] https://crrev.com/8226336494eaea967f15e5983f8a17397f990289/dev-haskell/vector/metadata.xml

Project Member

Comment 10 by bugdroid1@chromium.org, Sep 28

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/portage-stable/+/e0f04511c4797c07d9695404b13cc1ad5f61fc0f

commit e0f04511c4797c07d9695404b13cc1ad5f61fc0f
Author: Benjamin Gordon <bmgordon@chromium.org>
Date: Fri Sep 28 02:43:54 2018

shellcheck: upgraded package to upstream

Upgraded dev-util/shellcheck to version 0.5.0-r1 on amd64

BUG= chromium:844166 
TEST=sudo emerge shellcheck; ran shellcheck

Change-Id: I30ef285627f1f8ec830fd7bc9930b9841ee936dd
Reviewed-on: https://chromium-review.googlesource.com/1244121
Commit-Ready: Benjamin Gordon <bmgordon@chromium.org>
Tested-by: Benjamin Gordon <bmgordon@chromium.org>
Reviewed-by: Mike Frysinger <vapier@chromium.org>

[modify] https://crrev.com/e0f04511c4797c07d9695404b13cc1ad5f61fc0f/dev-util/shellcheck/Manifest
[rename] https://crrev.com/e0f04511c4797c07d9695404b13cc1ad5f61fc0f/dev-util/shellcheck/shellcheck-0.5.0-r1.ebuild
[add] https://crrev.com/e0f04511c4797c07d9695404b13cc1ad5f61fc0f/metadata/md5-cache/dev-util/shellcheck-0.5.0-r1
[delete] https://crrev.com/8226336494eaea967f15e5983f8a17397f990289/metadata/md5-cache/dev-util/shellcheck-0.4.7

Project Member

Comment 11 by bugdroid1@chromium.org, Sep 28

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/portage-stable/+/ed7eadce7453e7d21651e31918f3d4ae1c041e3b

commit ed7eadce7453e7d21651e31918f3d4ae1c041e3b
Author: Benjamin Gordon <bmgordon@chromium.org>
Date: Fri Sep 28 02:43:55 2018

dev-util/shellcheck: Move to chromiumos-overlay

We're going to start carrying local patches, so we need this out of
portage-stable.

BUG= chromium:844166 
TEST=emerge shellcheck
CQ-DEPEND=CL:1244578

Change-Id: Id93c1ae1f0d4a3e3d59f9f0b436a640c9218ecc0
Reviewed-on: https://chromium-review.googlesource.com/1244122
Commit-Ready: Benjamin Gordon <bmgordon@chromium.org>
Tested-by: Benjamin Gordon <bmgordon@chromium.org>
Reviewed-by: Mike Frysinger <vapier@chromium.org>

[delete] https://crrev.com/e0f04511c4797c07d9695404b13cc1ad5f61fc0f/dev-util/shellcheck/Manifest
[delete] https://crrev.com/e0f04511c4797c07d9695404b13cc1ad5f61fc0f/dev-util/shellcheck/shellcheck-0.5.0-r1.ebuild
[delete] https://crrev.com/e0f04511c4797c07d9695404b13cc1ad5f61fc0f/dev-util/shellcheck/metadata.xml

Project Member

Comment 12 by bugdroid1@chromium.org, Sep 28

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/98a97626b06dfe5be9953e3c66f36ca75f28691c

commit 98a97626b06dfe5be9953e3c66f36ca75f28691c
Author: Benjamin Gordon <bmgordon@chromium.org>
Date: Fri Sep 28 02:43:53 2018

dev-util/shellcheck: Move to chromiumos-overlay

We're going to start carrying local patches, so we need this out of
portage-stable.

BUG= chromium:844166 
TEST=emerge shellcheck
CQ-DEPEND=CL:1244122

Change-Id: I920394b238f07c3a38812d93c6e30f65fd032f59
Reviewed-on: https://chromium-review.googlesource.com/1244578
Commit-Ready: Benjamin Gordon <bmgordon@chromium.org>
Tested-by: Benjamin Gordon <bmgordon@chromium.org>
Reviewed-by: Mike Frysinger <vapier@chromium.org>

[add] https://crrev.com/98a97626b06dfe5be9953e3c66f36ca75f28691c/dev-util/shellcheck/Manifest
[add] https://crrev.com/98a97626b06dfe5be9953e3c66f36ca75f28691c/dev-util/shellcheck/shellcheck-0.5.0-r1.ebuild
[add] https://crrev.com/98a97626b06dfe5be9953e3c66f36ca75f28691c/dev-util/shellcheck/metadata.xml

Project Member

Comment 13 by bugdroid1@chromium.org, Sep 28

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/0995ea66a6a6c9f758887b7d8f8b88051a47c3a6

commit 0995ea66a6a6c9f758887b7d8f8b88051a47c3a6
Author: Benjamin Gordon <bmgordon@chromium.org>
Date: Fri Sep 28 02:43:56 2018

shellcheck: Disable dynamic linking

By statically linking shellcheck's Haskell dependencies, we can turn
them all into build-time dependencies instead of runtime dependencies.
This is a first step to letting us use shellcheck in the chroot without
importing the full 1GB ghc ebuild.

BUG= chromium:844166 
TEST=ldd /usr/bin/shellcheck; run shellcheck without ghc installed

Change-Id: I2bda5ee1d8c731d7aff832b01e4651391e2bc855
Reviewed-on: https://chromium-review.googlesource.com/1244579
Commit-Ready: Benjamin Gordon <bmgordon@chromium.org>
Tested-by: Benjamin Gordon <bmgordon@chromium.org>
Reviewed-by: Mike Frysinger <vapier@chromium.org>

[rename] https://crrev.com/0995ea66a6a6c9f758887b7d8f8b88051a47c3a6/dev-util/shellcheck/shellcheck-0.5.0-r2.ebuild

Blocking: 891826
Blocking: 682860
Project Member

Comment 16 by bugdroid1@chromium.org, Oct 16

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/926369b2103e5d0f2c559cbfc20151708067a020

commit 926369b2103e5d0f2c559cbfc20151708067a020
Author: Benjamin Gordon <bmgordon@chromium.org>
Date: Tue Oct 16 09:57:24 2018

target-sdk-nobdeps: New ebuilds for sdk

The new virtual/target-sdk-nobdeps target is used to pull in ebuilds
where we don't want their build-time deps installed.  The initial use
case is to add shellcheck to the chroot without all the Haskell compiler
dependencies.

BUG= chromium:844166 
TEST=chromiumos-sdk-tryjob

Change-Id: Iaf5b669537921c592b34747a9b2e8c3cb4ef70ad
Reviewed-on: https://chromium-review.googlesource.com/1070324
Commit-Ready: Benjamin Gordon <bmgordon@chromium.org>
Tested-by: Benjamin Gordon <bmgordon@chromium.org>
Reviewed-by: Simon Glass <sjg@chromium.org>
Reviewed-by: Alex Klein <saklein@chromium.org>

[add] https://crrev.com/926369b2103e5d0f2c559cbfc20151708067a020/virtual/target-chromium-os-sdk-nobdeps/target-chromium-os-sdk-nobdeps-1.ebuild
[add] https://crrev.com/926369b2103e5d0f2c559cbfc20151708067a020/virtual/target-sdk-nobdeps/target-sdk-nobdeps-1.ebuild
[add] https://crrev.com/926369b2103e5d0f2c559cbfc20151708067a020/virtual/target-sdk-nobdeps/target-sdk-nobdeps-1-r1.ebuild
[add] https://crrev.com/926369b2103e5d0f2c559cbfc20151708067a020/virtual/target-chromium-os-sdk-nobdeps/target-chromium-os-sdk-nobdeps-1-r1.ebuild

Project Member

Comment 17 by bugdroid1@chromium.org, Oct 16

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/crosutils/+/9723bfda6d8099707aa1a894acc2378edba6588b

commit 9723bfda6d8099707aa1a894acc2378edba6588b
Author: Benjamin Gordon <bmgordon@chromium.org>
Date: Tue Oct 16 09:57:24 2018

setup_board: Use virtual/target-sdk-nobdeps on host

virtual/target-sdk-nobdeps pulls in ebuilds that should be installed
without their build-deps.  This gets built as normal during the first
pass of rebuilding the chroot, then gets pulled into the new board root
with --with-bdeps=n to ensure that build-time dependencies are not
present in the final chroot image.  The initial use case is to make
shellcheck available in the chroot without bringing in all the Haskell
compiler dependencies.

BUG= chromium:844166 
TEST=chromiumos-sdk-tryjob
CQ-DEPEND=CL:1070324

Change-Id: I536d7da844ecd29a09e4b3a7fb8e922328bcb465
Reviewed-on: https://chromium-review.googlesource.com/1260045
Commit-Ready: Benjamin Gordon <bmgordon@chromium.org>
Tested-by: Benjamin Gordon <bmgordon@chromium.org>
Reviewed-by: Simon Glass <sjg@chromium.org>
Reviewed-by: Alex Klein <saklein@chromium.org>

[modify] https://crrev.com/9723bfda6d8099707aa1a894acc2378edba6588b/setup_board

Project Member

Comment 18 by bugdroid1@chromium.org, Oct 22

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/crosutils/+/aefd3d9f42f1eb48af08815f5dc846088b9bbd21

commit aefd3d9f42f1eb48af08815f5dc846088b9bbd21
Author: Benjamin Gordon <bmgordon@chromium.org>
Date: Mon Oct 22 20:40:08 2018

update_chroot: Install virtual/target-sdk-nobdeps

The virtual/target-sdk-nobdeps target brings in ebuilds that should be
installed from binary packages without their build-time deps.  The
initial use is to add shellcheck without all of its Haskell compiler
dependencies.  Now that the SDK builder has produced binpkgs for
shellcheck, start installing the new target in chroots.

BUG= chromium:844166 
TEST=update_chroot installs shellcheck binpkg

Change-Id: I9aacf34b4def661de4d62bfe9473f6d39792e78c
Reviewed-on: https://chromium-review.googlesource.com/1286067
Commit-Ready: Benjamin Gordon <bmgordon@chromium.org>
Tested-by: Benjamin Gordon <bmgordon@chromium.org>
Reviewed-by: Alex Klein <saklein@chromium.org>

[modify] https://crrev.com/aefd3d9f42f1eb48af08815f5dc846088b9bbd21/update_chroot

Status: Fixed (was: Started)
shellcheck is in and should be showing up in chroots now.

Sign in to add a comment