Supersize: Unable to view path of new png resource files |
|||
Issue descriptiontools/binary_size/diagnose_bloat.py 32b2ee10a083db73000b17bda67afde2942fb6ee I 13 Checking source directory I 1043 Processing 2 commits I 2868 Syncing to 1da30cab1d95b4d161e3ab570de0ed413fa97af0 I 48040 Building monochrome_public_apk within out/binary-size-build (this might take a while). I 259231 Saving build results to: /usr/local/google/home/wnwen/clankium2/src/out/binary-size-results/1da30cab1d95b4d161 e3ab570de0ed413fa97af0 I 263821 Creating .size file I 315741 Syncing to 32b2ee10a083db73000b17bda67afde2942fb6ee I 367219 Building monochrome_public_apk within out/binary-size-build (this might take a while). I 697646 Saving build results to: /usr/local/google/home/wnwen/clankium2/src/out/binary-size-results/32b2ee10a083db7300 0b17bda67afde2942fb6ee I 701824 Creating .size file I 753591 Creating: Native Diff I 786034 Creating: Resource Sizes Diff ******************************Native Diff****************************** Common Metadata: apk_file_name=apks/MonochromePublic.apk elf_arch=arm elf_file_name=lib.unstripped/libmonochrome.so gn_args=enable_chrome_android_internal=false is_chrome_branded=true is_official_build=true symbol_level=0 target_os ="android" treat_warnings_as_errors=false use_goma=true map_file_name=lib.unstripped/libmonochrome.so.map.gz tool_prefix=third_party/llvm-build/Release+Asserts/bin/llvm- Old Metadata: apk_size=65153204 elf_build_id=55c092897ea2ca36442765c15ec67b4109219146 elf_mtime=2018-05-17 11:01:42 git_revision=1da30cab1d95b4d161e3ab570de0ed413fa97af0 New Metadata: apk_size=65187010 elf_build_id=288050707462b3ec126c97b09dbba741b81c5991 elf_mtime=2018-05-17 11:04:40 git_revision=32b2ee10a083db73000b17bda67afde2942fb6ee Section Sizes (Total=37.4kb (38317 bytes)): .bss: 80 bytes (80 bytes) (not included in totals) .data: 0 bytes (0 bytes) (0.0%) .data.rel.ro: 0 bytes (0 bytes) (0.0%) .dex: 10.7kb (10996 bytes) (28.7%) .other: 26.5kb (27099 bytes) (70.7%) .pak.nontranslated: 0 bytes (0 bytes) (0.0%) .pak.translations: 0 bytes (0 bytes) (0.0%) .rel.dyn: 0 bytes (0 bytes) (0.0%) .rodata: 96 bytes (96 bytes) (0.3%) .text: 8 bytes (8 bytes) (0.0%) 187 symbols added (+), 435 changed (~), 15 removed (-), 977005 unchanged (not shown) Of changed symbols, 422 grew, 214 shrank Number of unique symbols 612737 -> 612912 (+175) 7 paths added, 0 removed, 198 changed Showing 637 symbols (455 -> 630 unique) with total pss: 38199 bytes Histogram of symbols based on PSS: (-512,-256]: 4 (-32,-16]: 4 (-2,-1]: 139 [4,8): 9 [64,128): 49 [1024,2048): 3 (-256,-128]: 5 (-16,-8]: 4 {0}: 1 [8,16): 65 [128,256): 21 [4096,8192): 1 (-128,-64]: 8 (-8,-4]: 3 [1,2): 178 [16,32): 16 [256,512): 15 [8192,16384): 1 (-64,-32]: 4 (-4,-2]: 43 [2,4): 29 [32,64): 32 [512,1024): 3 .text=8 bytes .rodata=96 bytes .data.rel.ro=0 bytes .data=0 bytes .bss=80 bytes .dex=658 bytes .dex.metho d=10.1kb .pak.translations=0 bytes .pak.nontranslated=0 bytes .other=26.5kb total=37.3kb Number of unique paths: 139 Section Legend: t=.text, r=.rodata, R=.data.rel.ro, d=.data, b=.bss, x=.dex, m=.dex.method, p=.pak.translations, P=.pak .nontranslated, o=.other Index | Running Total | Section@Address | Δ PSS (Δ size_without_padding) | Path ------------------------------------------------------------ ~ 0) 15308 (40.1%) o@0x0 15308 (4332268->4347576) $APK/resources.arsc resources.arsc ~ 1) 20160 (52.8%) o@0x0 4852 (0->0) {no path} Overhead: APK file + 2) 22128 (57.9%) o@Group 1968 (0->1968) {no path} ic_error_outline_googblue_24dp.webp (count=4)
,
May 17 2018
,
May 17 2018
We should consider failing the run for missing paths so that this is caught right away (and also for pak ID names, which are also missing atm I think?)
,
May 18 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/1d3d3febb6d20bde02d02e49ee0d6b6fe0cec0f7 commit 1d3d3febb6d20bde02d02e49ee0d6b6fe0cec0f7 Author: Peter Wen <wnwen@chromium.org> Date: Fri May 18 02:01:56 2018 Supersize: Fix merging resource files Due to using os.path.basename on resource file paths, the full name was truncated and caused resource symbols to be merged together resulting in no path in the diff. Bug: 844161 Change-Id: I26e85d3950082ddd0695f44a540f00d1bc972cc1 Reviewed-on: https://chromium-review.googlesource.com/1064974 Commit-Queue: agrieve <agrieve@chromium.org> Reviewed-by: agrieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#559775} [modify] https://crrev.com/1d3d3febb6d20bde02d02e49ee0d6b6fe0cec0f7/tools/binary_size/libsupersize/archive.py [modify] https://crrev.com/1d3d3febb6d20bde02d02e49ee0d6b6fe0cec0f7/tools/binary_size/libsupersize/testdata/Archive_Apk.golden
,
May 24 2018
|
|||
►
Sign in to add a comment |
|||
Comment 1 by wnwen@chromium.org
, May 17 2018Notice the {no path} for the webp files, it is the same for the other resource files.