Issue metadata
Sign in to add a comment
|
Implement GetPropertyValue |
||||||||||||||||||||||
Issue descriptionWe need to implement one method from the UI Automation raw simple interface. GetPropertyValue should return the name, role (known as control type in UI Automation) and the following states: focusable, enabled, focused and is password for password fields.
,
Jun 16 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a65d8a04a607450eaff672f226ea0d5b524f500b commit a65d8a04a607450eaff672f226ea0d5b524f500b Author: Suproteem Sarkar <suproteem@chromium.org> Date: Sat Jun 16 23:00:09 2018 Added relational propertyvalues to GetPropertyValue, which allows UI Automation to access relations from an automation element R=nektar@chromium.org,dmazzoni@chromium.org Bug: 844149 Change-Id: I7e92097761057c8fb795582098f54daeb00ef204 Reviewed-on: https://chromium-review.googlesource.com/1099434 Commit-Queue: Nektarios Paisios <nektar@chromium.org> Reviewed-by: Nektarios Paisios <nektar@chromium.org> Cr-Commit-Position: refs/heads/master@{#567899} [modify] https://crrev.com/a65d8a04a607450eaff672f226ea0d5b524f500b/ui/accessibility/platform/ax_platform_node_win.cc [modify] https://crrev.com/a65d8a04a607450eaff672f226ea0d5b524f500b/ui/accessibility/platform/ax_platform_node_win.h
,
Jun 17 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f30471c585171ddd4240258f35b9f31300da7e0b commit f30471c585171ddd4240258f35b9f31300da7e0b Author: Dirk Pranke <dpranke@chromium.org> Date: Sun Jun 17 00:38:44 2018 Revert "Added relational propertyvalues to GetPropertyValue, which allows UI Automation to access relations from an automation element" This reverts commit a65d8a04a607450eaff672f226ea0d5b524f500b. Reason for revert: I think this broken the layout tests on 32-bit Win10, see https://ci.chromium.org/buildbot/chromium.webkit/WebKit%20Win10/36552 Original change's description: > Added relational propertyvalues to GetPropertyValue, which allows UI Automation to access relations from an automation element > > R=nektar@chromium.org,dmazzoni@chromium.org > > Bug: 844149 > Change-Id: I7e92097761057c8fb795582098f54daeb00ef204 > Reviewed-on: https://chromium-review.googlesource.com/1099434 > Commit-Queue: Nektarios Paisios <nektar@chromium.org> > Reviewed-by: Nektarios Paisios <nektar@chromium.org> > Cr-Commit-Position: refs/heads/master@{#567899} TBR=dmazzoni@chromium.org,nektar@chromium.org,suproteem@chromium.org Change-Id: I0efca59b219cc9432d14e68f340c3dff12f4ef76 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 844149 Reviewed-on: https://chromium-review.googlesource.com/1103502 Reviewed-by: Dirk Pranke <dpranke@chromium.org> Commit-Queue: Dirk Pranke <dpranke@chromium.org> Cr-Commit-Position: refs/heads/master@{#567904} [modify] https://crrev.com/f30471c585171ddd4240258f35b9f31300da7e0b/ui/accessibility/platform/ax_platform_node_win.cc [modify] https://crrev.com/f30471c585171ddd4240258f35b9f31300da7e0b/ui/accessibility/platform/ax_platform_node_win.h
,
Jun 20 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/951911bd44c520e72181d906fa7063c555a6a8bd commit 951911bd44c520e72181d906fa7063c555a6a8bd Author: Nektarios Paisios <nektar@chromium.org> Date: Wed Jun 20 22:44:57 2018 Reland "Added relational propertyvalues to GetPropertyValue, which allows UI Automation to access relations from an automation element" This reverts commit f30471c585171ddd4240258f35b9f31300da7e0b. Reason for revert: Test failures don't appear to be related in any way. This is accessibility code that hasn't been turned on yet, i.e. it should never be running. Original change's description: > Revert "Added relational propertyvalues to GetPropertyValue, which allows UI Automation to access relations from an automation element" > > This reverts commit a65d8a04a607450eaff672f226ea0d5b524f500b. > > Reason for revert: I think this broken the layout tests on 32-bit Win10, see https://ci.chromium.org/buildbot/chromium.webkit/WebKit%20Win10/36552 > > Original change's description: > > Added relational propertyvalues to GetPropertyValue, which allows UI Automation to access relations from an automation element > > > > R=nektar@chromium.org,dmazzoni@chromium.org > > > > Bug: 844149 > > Change-Id: I7e92097761057c8fb795582098f54daeb00ef204 > > Reviewed-on: https://chromium-review.googlesource.com/1099434 > > Commit-Queue: Nektarios Paisios <nektar@chromium.org> > > Reviewed-by: Nektarios Paisios <nektar@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#567899} > > TBR=dmazzoni@chromium.org,nektar@chromium.org,suproteem@chromium.org > > Change-Id: I0efca59b219cc9432d14e68f340c3dff12f4ef76 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 844149 > Reviewed-on: https://chromium-review.googlesource.com/1103502 > Reviewed-by: Dirk Pranke <dpranke@chromium.org> > Commit-Queue: Dirk Pranke <dpranke@chromium.org> > Cr-Commit-Position: refs/heads/master@{#567904} TBR=dmazzoni@chromium.org,dpranke@chromium.org,nektar@chromium.org,suproteem@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 844149 Change-Id: I0fc68b9b611e0b90b6fc5cf73bdf709020fba079 Reviewed-on: https://chromium-review.googlesource.com/1108937 Reviewed-by: Nektarios Paisios <nektar@chromium.org> Commit-Queue: Nektarios Paisios <nektar@chromium.org> Cr-Commit-Position: refs/heads/master@{#569058} [modify] https://crrev.com/951911bd44c520e72181d906fa7063c555a6a8bd/ui/accessibility/platform/ax_platform_node_win.cc [modify] https://crrev.com/951911bd44c520e72181d906fa7063c555a6a8bd/ui/accessibility/platform/ax_platform_node_win.h
,
Aug 3
,
Jan 9
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f1e2b949259f5b7f5569ec7ff57ce168eac56277 commit f1e2b949259f5b7f5569ec7ff57ce168eac56277 Author: Rossen Atanassov <ratan@microsoft.com> Date: Wed Jan 09 08:34:30 2019 Fixing VARIANT value handling in AXPlatformNodeWin Handling of VT_BOOL type variants inside AXPlatformNodeWin::GetPropertyValue resulted in wrong boolean logic. The problem was that VARIANT_TRUE has the value of negative one while all other true value types are positive one. Initializing and/or comparing such values was the core issue. To completely fix the problem a change to the ScopedVariant constructor was added. In order to initialize a variant of type VT_BOOL additional handling was added to the VT_I4 constructor. Finally, new UIAutomation unit tests are added to validate such parameter passing. Bug: 844149 Change-Id: I8e466235ffe41d9eff256de0dc7433d823ab828b Reviewed-on: https://chromium-review.googlesource.com/c/1378799 Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by: Bruce Dawson <brucedawson@chromium.org> Reviewed-by: Nektarios Paisios <nektar@chromium.org> Cr-Commit-Position: refs/heads/master@{#621077} [modify] https://crrev.com/f1e2b949259f5b7f5569ec7ff57ce168eac56277/base/win/scoped_variant.cc [modify] https://crrev.com/f1e2b949259f5b7f5569ec7ff57ce168eac56277/base/win/scoped_variant.h [modify] https://crrev.com/f1e2b949259f5b7f5569ec7ff57ce168eac56277/ui/accessibility/platform/ax_platform_node_win.cc [modify] https://crrev.com/f1e2b949259f5b7f5569ec7ff57ce168eac56277/ui/accessibility/platform/ax_platform_node_win_unittest.cc [modify] https://crrev.com/f1e2b949259f5b7f5569ec7ff57ce168eac56277/ui/accessibility/platform/test_ax_node_wrapper.h
,
Jan 14
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/4b7562972f94809ad60cf9b4fdf510337dc6371c commit 4b7562972f94809ad60cf9b4fdf510337dc6371c Author: Rossen Atanassov <ratan@microsoft.com> Date: Mon Jan 14 18:29:01 2019 Adding UIA provider callbacks error handling Unlike straight COM and IA2, UIAutomation provider implementations are expected to return UIA_E_ELEMENTNOTAVAILABLE instead of E_FAIL. This change adds the correct error propagation and unit tests to all currently supported UIA provider interfaces. Bug: 844149 Change-Id: I0726be3541132f2d384edfdddac5df00fb6a2827 Reviewed-on: https://chromium-review.googlesource.com/c/1388218 Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#622521} [modify] https://crrev.com/4b7562972f94809ad60cf9b4fdf510337dc6371c/ui/accessibility/platform/ax_platform_node_win.cc [modify] https://crrev.com/4b7562972f94809ad60cf9b4fdf510337dc6371c/ui/accessibility/platform/ax_platform_node_win_unittest.cc |
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by bugdroid1@chromium.org
, Jun 13 2018