New issue
Advanced search Search tips

Issue 844147 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: May 2018
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 2
Type: Bug



Sign in to add a comment

Don't include text attributes when they have the default value

Project Member Reported by aleventhal@chromium.org, May 17 2018

Issue description

According to the IA2 spec here:
https://wiki.linuxfoundation.org/accessibility/iaccessible2/textattributes
"If an attribute is not specified and if the table shows that there is a default value, the default value should be assumed."

This makes the a11y tree less noisy, smaller and easier to debug.


 
Project Member

Comment 1 by bugdroid1@chromium.org, May 18 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c2877c98e39bbc16e943a4c199ada9a2e7c616c8

commit c2877c98e39bbc16e943a4c199ada9a2e7c616c8
Author: Aaron Leventhal <aleventhal@chromium.org>
Date: Fri May 18 14:33:13 2018

Do not expose IA2 text attribute default values

According to the IA2 spec here:
https://wiki.linuxfoundation.org/accessibility/iaccessible2/textattributes
"If an attribute is not specified and if the table shows that there is a default value, the default value should be assumed."

This makes the a11y tree less noisy, smaller and easier to debug, and is similar to how Firefox works.

Bug:  844147 
Change-Id: I1c4578abc84097f0fc5e9624d9020ad20276bffc
Reviewed-on: https://chromium-review.googlesource.com/1064850
Commit-Queue: Aaron Leventhal <aleventhal@chromium.org>
Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#559885}
[modify] https://crrev.com/c2877c98e39bbc16e943a4c199ada9a2e7c616c8/content/browser/accessibility/browser_accessibility_com_win.cc
[modify] https://crrev.com/c2877c98e39bbc16e943a4c199ada9a2e7c616c8/content/browser/accessibility/browser_accessibility_win_unittest.cc
[modify] https://crrev.com/c2877c98e39bbc16e943a4c199ada9a2e7c616c8/content/test/data/accessibility/aria/aria-invalid-expected-win.txt
[modify] https://crrev.com/c2877c98e39bbc16e943a4c199ada9a2e7c616c8/content/test/data/accessibility/css/font-style-expected-win.txt
[modify] https://crrev.com/c2877c98e39bbc16e943a4c199ada9a2e7c616c8/content/test/data/accessibility/html/b-expected-blink.txt
[modify] https://crrev.com/c2877c98e39bbc16e943a4c199ada9a2e7c616c8/content/test/data/accessibility/html/b-expected-win.txt
[modify] https://crrev.com/c2877c98e39bbc16e943a4c199ada9a2e7c616c8/content/test/data/accessibility/html/b.html

Status: Fixed (was: Assigned)
Project Member

Comment 3 by bugdroid1@chromium.org, May 21 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2d8012e3da11a4cb420eee9f4ab77961114187cd

commit 2d8012e3da11a4cb420eee9f4ab77961114187cd
Author: Aaron Leventhal <aleventhal@chromium.org>
Date: Mon May 21 18:45:22 2018

More default text attribute value removal

According to the IA2 spec here:
https://wiki.linuxfoundation.org/accessibility/iaccessible2/textattributes
"If an attribute is not specified and if the table shows that there is a default value, the default value should be assumed."

This makes the a11y tree less noisy, smaller and easier to debug, and is similar to how Firefox works.

Bug:  844147 
Change-Id: I3f7827d10d9659e5e758827a806da0b7f6598e41
Reviewed-on: https://chromium-review.googlesource.com/1066112
Reviewed-by: Nektarios Paisios <nektar@chromium.org>
Commit-Queue: Aaron Leventhal <aleventhal@chromium.org>
Cr-Commit-Position: refs/heads/master@{#560318}
[modify] https://crrev.com/2d8012e3da11a4cb420eee9f4ab77961114187cd/content/browser/accessibility/browser_accessibility_com_win.cc
[modify] https://crrev.com/2d8012e3da11a4cb420eee9f4ab77961114187cd/content/test/data/accessibility/css/color-expected-win.txt

Sign in to add a comment