Content visually shifts when switching between GVR quad layer and UI-driven rendering |
||||
Issue descriptionGVR now renders the VR content quad, unless content is transparent or has an overlay. Toggling between modes happens on fades, such as when spawning the omnibox or a pop-up. When doing so, there is a visible shift in content. It appears that the top right corner is anchored, and content shifts toward the bottom left corner, meaning the effect is most easily seen to the bottom left. This was discussed with mthiesse@ when the quad content implementation was new, and it seemed very minor. However, I'm noticing it now during testing, and finding it distracting. I think we should investigate. It looks like there's a slight size difference between the two quads, a one-pixel difference in size, or something similar.
,
Jun 4 2018
,
Jun 13 2018
,
Aug 9
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d16f24a3b14969d51835c71eb73f3bd9ee6ac36d commit d16f24a3b14969d51835c71eb73f3bd9ee6ac36d Author: yuqinganniesun <yuqinganniesun@chromium.org> Date: Thu Aug 09 14:27:17 2018 VR: Fix black border visible on the content quad edge. Increased kBorder to 4 to temporarily cover black lines on left and bottom sides. Content shifting still exists but we identify that as a result of gvr rendering instead of quad_layer code. For the sake of future debugging, a function is added in VrShellGl to allow a snapshot of content quad texture after rendered by WebVrRenderer. This is enabled by passing an argument as a flag and then pressing app button on the controller will take a snapshot. Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:linux_vr;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I99ee84d907237bd7f7c43bf99d22dc67f3b7d2f4 Bug: 844138 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:linux_vr;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I99ee84d907237bd7f7c43bf99d22dc67f3b7d2f4 Reviewed-on: https://chromium-review.googlesource.com/1120938 Reviewed-by: Michael Thiessen <mthiesse@chromium.org> [modify] https://crrev.com/d16f24a3b14969d51835c71eb73f3bd9ee6ac36d/chrome/browser/android/vr/vr_shell_gl.cc [modify] https://crrev.com/d16f24a3b14969d51835c71eb73f3bd9ee6ac36d/chrome/browser/android/vr/vr_shell_gl.h [modify] https://crrev.com/d16f24a3b14969d51835c71eb73f3bd9ee6ac36d/chrome/browser/vr/ui.cc [modify] https://crrev.com/d16f24a3b14969d51835c71eb73f3bd9ee6ac36d/chrome/browser/vr/ui.h [modify] https://crrev.com/d16f24a3b14969d51835c71eb73f3bd9ee6ac36d/chrome/browser/vr/ui_interface.h
,
Aug 9
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/0c9973952c118155d4b731dc36b75b5edff20a44 commit 0c9973952c118155d4b731dc36b75b5edff20a44 Author: Andrii Shyshkalov <tandrii@chromium.org> Date: Thu Aug 09 19:19:46 2018 Revert "VR: Fix black border visible on the content quad edge." This reverts commit d16f24a3b14969d51835c71eb73f3bd9ee6ac36d. Reason for revert: Due to Gerrit outage http://crbug.com/872722 , we are reverting this CL. Please, re-land it after all clear is given. If you have questions, please ask on the bug. Sorry for the inconvenience. Original change's description: > VR: Fix black border visible on the content quad edge. > > Increased kBorder to 4 to temporarily cover black lines on left and bottom sides. > Content shifting still exists but we identify that as a result of gvr rendering > instead of quad_layer code. > For the sake of future debugging, a function is added in VrShellGl to allow a snapshot > of content quad texture after rendered by WebVrRenderer. This is enabled by passing an argument > as a flag and then pressing app button on the controller will take a snapshot. > > Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:linux_vr;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel > Change-Id: I99ee84d907237bd7f7c43bf99d22dc67f3b7d2f4 > > Bug: 844138 > Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:linux_vr;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel > Change-Id: I99ee84d907237bd7f7c43bf99d22dc67f3b7d2f4 > Reviewed-on: https://chromium-review.googlesource.com/1120938 > Reviewed-by: Michael Thiessen <mthiesse@chromium.org> TBR=mthiesse@chromium.org,yuqinganniesun@chromium.org Change-Id: I98c46a5251a15294a2339fd46f39663f5dc0d91f No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 844138 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:linux_vr;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Reviewed-on: https://chromium-review.googlesource.com/1169792 Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org> [modify] https://crrev.com/0c9973952c118155d4b731dc36b75b5edff20a44/chrome/browser/android/vr/vr_shell_gl.cc [modify] https://crrev.com/0c9973952c118155d4b731dc36b75b5edff20a44/chrome/browser/android/vr/vr_shell_gl.h [modify] https://crrev.com/0c9973952c118155d4b731dc36b75b5edff20a44/chrome/browser/vr/ui.cc [modify] https://crrev.com/0c9973952c118155d4b731dc36b75b5edff20a44/chrome/browser/vr/ui.h [modify] https://crrev.com/0c9973952c118155d4b731dc36b75b5edff20a44/chrome/browser/vr/ui_interface.h
,
Today
(15 hours ago)
|
||||
►
Sign in to add a comment |
||||
Comment 1 by cjgrant@chromium.org
, Jun 4 2018