New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 844126 link

Starred by 5 users

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Jun 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 2
Type: Bug



Sign in to add a comment

Spellcheck suggestions no longer show up

Project Member Reported by yyushkina@chromium.org, May 17 2018

Issue description

OS: MacOS

From reporter: "I have noticed that when typing email, though chrome happy to highlight the misspelled words, it no longer offers the correct replacement. 
I still have both enabled:
- ask google for suggestions &
- Use a web service to help resolve spelling errors"

Optimizations Blink-side are suspected to be at fault.


 
Is there any more detailed repro steps or test cases?

I can't reproduce locally with Chrome Mac Canary 68.0.3433.0 with the two options enabled.

Tried typing editpad.org. When right-clicking on the misspelled words, the context menu shows suggestions as expected. When opening the spelling panel, the suggestions are also shown as expected.

Comment 2 by groby@google.com, May 18 2018

Repro step:

Enable  "Ask Google for suggestions"
Type "icland is an icland" in a spellchecked textbox.

The first "icland" should have one suggestion - "Iceland". The second one should have also only one suggestion, "island". If you see more than one suggestion, or different suggestions, those are provided by the system spellcheck.

Project Member

Comment 3 by bugdroid1@chromium.org, May 18 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7cdf18f8b5ff707820ceb8c2e18ec3e5b75a9ad0

commit 7cdf18f8b5ff707820ceb8c2e18ec3e5b75a9ad0
Author: Rachel Blum <groby@chromium.org>
Date: Fri May 18 01:35:01 2018

[Spellcheck] Look up browser context directly.

Looking it up via the RenderProcessHost fails, because the identity
doesn't seem to attached to an RPH.

It's not entirely clear why, but it removes an unnecessary redirection either way, so here it is.

R=xiaochengh@chromium.org

Bug:  844126 
Change-Id: I487d47d974b0c6ad45e90bb669a5b34f0b076717
Reviewed-on: https://chromium-review.googlesource.com/1063117
Commit-Queue: Rachel Blum <groby@chromium.org>
Reviewed-by: Ken Rockot <rockot@chromium.org>
Cr-Commit-Position: refs/heads/master@{#559770}
[modify] https://crrev.com/7cdf18f8b5ff707820ceb8c2e18ec3e5b75a9ad0/chrome/browser/spellchecker/spell_check_host_chrome_impl_mac.cc

Labels: TE-Verified-68.0.3434.0 TE-Verified-M68
Able to reproduce the issue on chrome build without fix(68.0.3433.0)
Verified the fix on Mac 10.12.6 on Chrome version #68.0.3434.0 as per the comment#0 & 2
Attaching screen cast for reference.
Observed "The correct suggestions are seen"
Hence, the fix is working as expected.
Adding the verified label.

Thanks!
844126.mp4
1.9 MB View Download

Comment 5 by aidas@google.com, May 29 2018

Do we have a date when this fix is rolling out to prod, please?
Fix landed in 68.0.3434.0 so it will be in the next stable release (End of July).
Status: Fixed (was: Started)

Comment 8 by sdy@chromium.org, Jan 17 (5 days ago)

Cc: ellyjo...@chromium.org
 Issue 843864  has been merged into this issue.

Sign in to add a comment