Spellcheck suggestions no longer show up |
|||
Issue descriptionOS: MacOS From reporter: "I have noticed that when typing email, though chrome happy to highlight the misspelled words, it no longer offers the correct replacement. I still have both enabled: - ask google for suggestions & - Use a web service to help resolve spelling errors" Optimizations Blink-side are suspected to be at fault.
,
May 18 2018
Repro step: Enable "Ask Google for suggestions" Type "icland is an icland" in a spellchecked textbox. The first "icland" should have one suggestion - "Iceland". The second one should have also only one suggestion, "island". If you see more than one suggestion, or different suggestions, those are provided by the system spellcheck.
,
May 18 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/7cdf18f8b5ff707820ceb8c2e18ec3e5b75a9ad0 commit 7cdf18f8b5ff707820ceb8c2e18ec3e5b75a9ad0 Author: Rachel Blum <groby@chromium.org> Date: Fri May 18 01:35:01 2018 [Spellcheck] Look up browser context directly. Looking it up via the RenderProcessHost fails, because the identity doesn't seem to attached to an RPH. It's not entirely clear why, but it removes an unnecessary redirection either way, so here it is. R=xiaochengh@chromium.org Bug: 844126 Change-Id: I487d47d974b0c6ad45e90bb669a5b34f0b076717 Reviewed-on: https://chromium-review.googlesource.com/1063117 Commit-Queue: Rachel Blum <groby@chromium.org> Reviewed-by: Ken Rockot <rockot@chromium.org> Cr-Commit-Position: refs/heads/master@{#559770} [modify] https://crrev.com/7cdf18f8b5ff707820ceb8c2e18ec3e5b75a9ad0/chrome/browser/spellchecker/spell_check_host_chrome_impl_mac.cc
,
May 18 2018
Able to reproduce the issue on chrome build without fix(68.0.3433.0) Verified the fix on Mac 10.12.6 on Chrome version #68.0.3434.0 as per the comment#0 & 2 Attaching screen cast for reference. Observed "The correct suggestions are seen" Hence, the fix is working as expected. Adding the verified label. Thanks!
,
May 29 2018
Do we have a date when this fix is rolling out to prod, please?
,
May 29 2018
Fix landed in 68.0.3434.0 so it will be in the next stable release (End of July).
,
Jun 5 2018
,
Jan 17
(5 days ago)
|
|||
►
Sign in to add a comment |
|||
Comment 1 by xiaoche...@chromium.org
, May 18 2018