New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 844117 link

Starred by 5 users

Issue metadata

Status: Fixed
Owner:
Closed: May 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

CrOS FR: Add button to remove proxy exception in VPN profile

Project Member Reported by ykrychala@google.com, May 17 2018

Issue description

Summary:
Customer can't delete an incorrect entry in Proxy configuration under Chrome Settings in the current UI (Version 66). But we are able to confirm that this settings/buttons are available from the older version. 

Use case / Motivation:
If customer mistypes an entry, there's no method or button to delete the incorrect entry. 

Existing workarounds:
Customer have to delete the profile and re-add, then enter the correct information under exception (poor customer experience as per customer) 

Case#: 
14519100

Screenshots:
https://drive.google.com/open?id=1OACqJavFJ_sXuxCSW1vIJ89puJCRzK84 - old version 59, an user can delete an entry
https://drive.google.com/open?id=1ObyKkITu-FZa6Wx8Z5debFH3I7R_ZlMN - current version, 'Remove' button is not there anymore

Steps to reproduce: 
1) Go to Chrome://settings > Network 
2) Create a profile, once connected to the VPN, select the VPN profile and configure 
3) There is an option of adding the exception within the page 
4) Add an entry to proxy exception list
5) there is no button to remove the entry

 
Components: UI>Shell>Networking
Description: Show this description
Status: Sas (was: Unconfirmed)
Components: UI>Settings
Labels: M-67
Owner: steve...@chromium.org
Status: Assigned (was: Sas)
Labels: -Type-Feature Type-Bug

Comment 6 by jayhlee@google.com, May 21 2018

Cc: cernekee@chromium.org
Workaround is to "forget" entire VPN config.

+ cernekee - major Google customer is facing this issue. Do you know who could take a look?


Status: Started (was: Assigned)
I have a fix in progress.

Project Member

Comment 8 by bugdroid1@chromium.org, May 21 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c8bd543bff627677301ee63cf66abe2b7023bcf5

commit c8bd543bff627677301ee63cf66abe2b7023bcf5
Author: Steven Bennetts <stevenjb@chromium.org>
Date: Mon May 21 23:29:51 2018

Settings: Internet: Correctly make proxy exclusions editable

Bug:  844117 
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: Ie54bc10acac1463d4b9d06dbc54fd540f1a4b463
Reviewed-on: https://chromium-review.googlesource.com/1067490
Reviewed-by: Toni Barzic <tbarzic@chromium.org>
Commit-Queue: Steven Bennetts <stevenjb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#560402}
[modify] https://crrev.com/c8bd543bff627677301ee63cf66abe2b7023bcf5/ui/webui/resources/cr_components/chromeos/network/network_proxy.html

Labels: Merge-Request-67
Status: Fixed (was: Started)
This doesn't affect a lot of people and there is a work around, but it's a pain for the people it does affect.

The fix is CrOS only and fairly trivial.

Project Member

Comment 10 by sheriffbot@chromium.org, May 21 2018

Labels: -Merge-Request-67 Merge-Review-67 Hotlist-Merge-Review
This bug requires manual review: We are only 7 days from stable.
Please contact the milestone owner if you have questions.
Owners: cmasso@(Android), cmasso@(iOS), kbleicher@(ChromeOS), govind@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 11 by cindyb@google.com, May 23 2018

Has the fix been confirmed/test on impacted and other devices?
Any/all devices were affected by the bug. Simple repro:

1. Navigate to Settings > Network > WiFi > (any wifi network, I recommend an open network, see 'Workaround' below)
2. Expand 'Proxy'
3. enable 'Allow proxies for shared networks' if necessary (i.e for shared networks)
4. Set Connection type = manual
5. Enter 'foo.com' (or anything) in the input field before 'Add exception' and click 'Add exception'.

Observe:
Entry appears in 'Do not use the proxy settings for these hosts and domains' with no way to remove it.

Workaround:
To remove the proxy exception, 'Forget' and re-configure the network.

Note:
In 68 here is a bug (fixed in ToT) preventing saving of the proxy configuration, but it should be reproducible in 67.

Sorry,  stevenjb@, just to confirm, you're saying in your 'Note:' that the fix has been confirmed, I assume?  Seems a bit like an added feature late in the M67 lifecycle.  Impact if declined?
It's definitely a bug, not a new feature, it just survived several releases before it was reported. At this point it is more embarrassing than anything.

Labels: -Merge-Review-67 Merge-Rejected-67
Rejecting after a review with Steven since there's a workaround and this isn't a top priority (and since it has been in prod for some time).
Hi team, thank you for the attention that you are showing for this report.
Will this mean that the fix was rejected to be merged in version 67 but will become available in version 68? 
Yes, that is correct, the fix is in 68. For 67 please follow the existing workaround.

Thank you for the confirmation stevenjb, we'll update the customer about this. 

Sign in to add a comment