Fix/disable base_unittests:ChromeOSMemoryPressureMonitorTest.CheckMemoryPressure in amd64-generic CrOS VM |
||||
Issue descriptionWe're gradually adding browser test suites running in amd64-generic CrOS VMs to the CQ. ChromeOSMemoryPressureMonitorTest.CheckMemoryPressure in base_unittests currently fails in this test configuration: https://logs.chromium.org/v/?s=chromium%2Fbuildbucket%2Fcr-buildbucket.appspot.com%2F8946265906196994912%2F%2B%2Fsteps%2Fbase_unittests%2F0%2Flogs%2FChromeOSMemoryPressureMonitorTest.CheckMemoryPressure%2F0 It's continuously running on this FYI bot: https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/chromeos-amd64-generic-rel-vm-tests I'd like to enable that suite on the CQ, but this test is one of a few blocking it. Please fix or disable it.
,
May 18 2018
I'm not sure how/if this is working now. skuhne@ is probably still most knowledgeable person. +abodenha@ who may know, or know the person who knows.
,
May 18 2018
No clue. What does history say about who added that test?
,
May 18 2018
Doesn't look like there's been much activity for years on the test file (the recent changes are all due to wide refactorings). I can disable the test on the device for now.
,
May 18 2018
Sounds like the right move. Should probably also file a bug to investigate and re-enable it.
,
May 18 2018
https://chromium-review.googlesource.com/c/chromium/src/+/1066466 I think Stefan is probably best equipped to figure out a good owner for this bug. The following commands should allow you to run base_unittests in the VM. Enter the SDK shell and download the VM: (shell) .../chrome/src $ cros chrome-sdk --board=amd64-generic --download-vm --clear-sdk-cache --log-level info Start the VM: (sdk) .../chrome/src $ cros_vm --start Build base_unittests: (sdk) .../chrome/src $ autoninja -C out_amd64-generic/Release/ base_unittests Run base_unittests: (sdk) .../chrome/src $ cros_run_vm_test --files out_amd64-generic/Release/base_unittests --files out_amd64-generic/Release/libmalloc_wrapper.so --cwd out_amd64-generic/Release/ --cmd -- ./base_unittests
,
May 19 2018
+chrisha has re-worked a lot here with his team.
,
May 22 2018
,
May 23 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f4bbd3093fe90c6d844b19ea9c37cc3217f6ab4a commit f4bbd3093fe90c6d844b19ea9c37cc3217f6ab4a Author: Achuith Bhandarkar <achuith@chromium.org> Date: Wed May 23 00:16:36 2018 Disable CheckMemoryPressure in chromeos VM. ChromeOSMemoryPressureMonitorTest.CheckMemoryPressure fails in the ChromeOS VM. BUG=844102 TEST=This is the test TBR=skuhne@chromium.org Change-Id: I58cef93ff9df4cd12b103a0bc5f99b576aab542f Reviewed-on: https://chromium-review.googlesource.com/1066466 Commit-Queue: Achuith Bhandarkar <achuith@chromium.org> Reviewed-by: Chris Hamilton <chrisha@chromium.org> Cr-Commit-Position: refs/heads/master@{#560847} [modify] https://crrev.com/f4bbd3093fe90c6d844b19ea9c37cc3217f6ab4a/base/memory/memory_pressure_monitor_chromeos_unittest.cc |
||||
►
Sign in to add a comment |
||||
Comment 1 by achuith@chromium.org
, May 17 2018