New issue
Advanced search Search tips

Issue 844099 link

Starred by 2 users
Status: Fixed
Owner:
taku...@chromium.org
Closed: May 2018
Cc:
mfo...@chromium.org
taku...@chromium.org
powerb@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Feature

Blocking:
issue 754101


Participants' hotlists:
Harmony-Cast-Dialog


Sign in to add a comment

Show "Avaliable" status in Harmony Cast Dialog

Project Member Reported by taku...@chromium.org, May 17 2018 
Per the mocks [1], available sinks should have "Available" as their status text.

[1] https://docs.google.com/presentation/d/1B58rYE3W5IMrewQjMvIlu7hAuR4Ym_le9lmk3AX_nZ4/edit
Project Member

Comment 1 by bugdroid1@chromium.org, May 31 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/452d37a0887d3e2664c6eae538e4251b60124acd

commit 452d37a0887d3e2664c6eae538e4251b60124acd
Author: Takumi Fujimoto <takumif@chromium.org>
Date: Thu May 31 00:18:35 2018

[Harmony Cast Dialog] Add sink status text for available and connecting states

Show "Available" or "Connecting..." as the status text for sinks in respective
states. Default to the status text if supplied by the sink.

Bug:  844099 
Change-Id: I5ba8b82960413dd7927182d34e2112ed391a12ba
Reviewed-on: https://chromium-review.googlesource.com/1071089
Reviewed-by: Derek Cheng <imcheng@chromium.org>
Commit-Queue: Takumi Fujimoto <takumif@chromium.org>
Cr-Commit-Position: refs/heads/master@{#563083}
[modify] https://crrev.com/452d37a0887d3e2664c6eae538e4251b60124acd/chrome/app/media_router_strings.grdp
[modify] https://crrev.com/452d37a0887d3e2664c6eae538e4251b60124acd/chrome/browser/ui/views/media_router/cast_dialog_sink_button.cc

Comment 2 by taku...@chromium.org, May 31 2018

Status: Fixed (was: Assigned)
►

Sign in to add a comment