New issue
Advanced search Search tips

Issue 844089 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: May 2018
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 1
Type: Bug-Security



Sign in to add a comment

Security DCHECK failure: !object || (object->IsBox()) in layout_box.h

Project Member Reported by ClusterFuzz, May 17 2018

Issue description

Detailed report: https://clusterfuzz.com/testcase?key=5866384165437440

Fuzzer: mbarbella_webcomponents
Job Type: linux_asan_content_shell_drt
Platform Id: linux

Crash Type: Security DCHECK failure
Crash Address: 
Crash State:
  !object || (object->IsBox()) in layout_box.h
  blink::GetScrollableArea
  blink::RootScrollerController::ProcessImplicitCandidates
  
Sanitizer: address (ASAN)

Regressed: https://clusterfuzz.com/revisions?job=linux_asan_content_shell_drt&range=559493:559495

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=5866384165437440

Issue filed automatically.

See https://github.com/google/clusterfuzz-tools for more information.
 
Project Member

Comment 1 by ClusterFuzz, May 17 2018

Components: Blink
Labels: Test-Predator-Auto-Components
Automatically applying components based on crash stacktrace and information from OWNERS files.

If this is incorrect, please apply the Test-Predator-Wrong-Components label.
Project Member

Comment 2 by ClusterFuzz, May 17 2018

Labels: Test-Predator-Auto-Owner
Owner: bokan@chromium.org
Status: Assigned (was: Untriaged)
Automatically assigning owner based on suspected regression changelist https://chromium.googlesource.com/chromium/src/+/e952fd3e13420f487cc512c01528a6bf93121cca ([root-scroller] Select implicit from scrollable elements).

If this is incorrect, please let us know why and apply the Test-Predator-Wrong-CLs label. If you aren't the correct owner for this issue, please unassign yourself as soon as possible so it can be re-triaged.
Project Member

Comment 3 by sheriffbot@chromium.org, May 18 2018

Labels: M-68
Project Member

Comment 4 by sheriffbot@chromium.org, May 18 2018

Labels: ReleaseBlock-Stable
This is a serious security regression. If you are not able to fix this quickly, please revert the change that introduced it.

If this doesn't affect a release branch, or has not been properly classified for severity, please update the Security_Impact or Security_Severity labels, and remove the ReleaseBlock label. To disable this altogether, apply ReleaseBlock-NA.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 5 by sheriffbot@chromium.org, May 18 2018

Labels: Pri-1

Comment 6 by bokan@chromium.org, May 18 2018

Status: Started (was: Assigned)
Components: -Blink Blink>Scroll
Project Member

Comment 8 by bugdroid1@chromium.org, May 18 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/badbd32bba4d43453f0625b8c0beab49558b29c2

commit badbd32bba4d43453f0625b8c0beab49558b29c2
Author: David Bokan <bokan@chromium.org>
Date: Fri May 18 21:33:30 2018

Fix LayoutObject conversion crash

Ensure that a LayoutObject is actually a LayoutBox before we try to get
a PaintLayerScrollableArea out of it.

Bug:  844089 
Change-Id: I96e7316d8d72f9f35b2b871e323004e3c5875792
Reviewed-on: https://chromium-review.googlesource.com/1066398
Commit-Queue: David Bokan <bokan@chromium.org>
Reviewed-by: Philip Rogers <pdr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#560051}
[modify] https://crrev.com/badbd32bba4d43453f0625b8c0beab49558b29c2/third_party/blink/renderer/core/page/scrolling/root_scroller_controller.cc
[modify] https://crrev.com/badbd32bba4d43453f0625b8c0beab49558b29c2/third_party/blink/renderer/core/page/scrolling/root_scroller_test.cc

Project Member

Comment 9 by ClusterFuzz, May 19 2018

ClusterFuzz has detected this issue as fixed in range 560048:560053.

Detailed report: https://clusterfuzz.com/testcase?key=5866384165437440

Fuzzer: mbarbella_webcomponents
Job Type: linux_asan_content_shell_drt
Platform Id: linux

Crash Type: Security DCHECK failure
Crash Address: 
Crash State:
  !object || (object->IsBox()) in layout_box.h
  blink::GetScrollableArea
  blink::RootScrollerController::ProcessImplicitCandidates
  
Sanitizer: address (ASAN)

Regressed: https://clusterfuzz.com/revisions?job=linux_asan_content_shell_drt&range=559493:559495
Fixed: https://clusterfuzz.com/revisions?job=linux_asan_content_shell_drt&range=560048:560053

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=5866384165437440

See https://github.com/google/clusterfuzz-tools for more information.

If you suspect that the result above is incorrect, try re-doing that job on the test case report page.
Project Member

Comment 10 by ClusterFuzz, May 19 2018

Labels: ClusterFuzz-Verified
Status: Verified (was: Started)
ClusterFuzz testcase 5866384165437440 is verified as fixed, so closing issue as verified.

If this is incorrect, please add ClusterFuzz-Wrong label and re-open the issue.
Project Member

Comment 11 by sheriffbot@chromium.org, May 19 2018

Labels: -Restrict-View-SecurityTeam Restrict-View-SecurityNotify
Labels: -ReleaseBlock-Stable
Project Member

Comment 13 by sheriffbot@chromium.org, Aug 25

Labels: -Restrict-View-SecurityNotify allpublic
This bug has been closed for more than 14 weeks. Removing security view restrictions.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Sign in to add a comment