New issue
Advanced search Search tips
Starred by 7 users

Issue metadata

Status: Fixed
Owner:
Closed: Aug 6
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug

Blocked on:
issue 812881
issue 830219
issue 849136
issue 869962

Blocking:
issue 854923
issue 863578



Sign in to add a comment
link

Issue 844079: utilize LXD's API for container lifecycle

Reported by smbar...@chromium.org, May 17 2018 Project Member

Issue description

run_container.sh was meant as a stepping stone, and LXD's command line interface isn't really built with scripting in mind. We should be using an API to speak to LXD.

There are two semi-reasonable routes here:
1) Add gRPC support directly to LXD.
2) Create a daemon to translate LXD's REST API into gRPC.
 

Comment 1 by jkardatzke@chromium.org, May 17 2018

Cc: jkardatzke@chromium.org

Comment 2 by smbar...@chromium.org, Jun 12 2018

Blockedon: 812881 849136 830219
Adding blockers on creating the tremplin repo, upgrading to LXD 3.0 (or 3.0.1 at this rate), and using the cros-go.eclass improvements so we can install LXD's client API for tremplin to use.

Comment 3 by bugdroid1@chromium.org, Jun 15 2018

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/system_api/+/48a215ef7df3b9b93569e4ac3361b4ad8b842235

commit 48a215ef7df3b9b93569e4ac3361b4ad8b842235
Author: Stephen Barber <smbarber@chromium.org>
Date: Fri Jun 15 22:26:32 2018

vm_cicerone: add ipv4_address to NotifyVmStartedRequest

BUG= chromium:844079 
TEST=none

Change-Id: Id7a17e807857e88407a7e04d0ca7441ae4bc803e
Reviewed-on: https://chromium-review.googlesource.com/1096895
Commit-Ready: Stephen Barber <smbarber@chromium.org>
Tested-by: Stephen Barber <smbarber@chromium.org>
Reviewed-by: Chirantan Ekbote <chirantan@chromium.org>

[modify] https://crrev.com/48a215ef7df3b9b93569e4ac3361b4ad8b842235/dbus/vm_cicerone/cicerone_service.proto

Comment 4 by bugdroid1@chromium.org, Jun 15 2018

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/tremplin/+/85ec2f75c6bebef31b13ad1ae3bd56f4e1bda4ec

commit 85ec2f75c6bebef31b13ad1ae3bd56f4e1bda4ec
Author: Stephen Barber <smbarber@chromium.org>
Date: Fri Jun 15 22:26:34 2018

tremplin: add initial README

Add a simple README to start things off.

BUG= chromium:844079 
TEST=none

Change-Id: I0ed28edc29c6ffe3ce9032d17bb496f6838686b6
Reviewed-on: https://chromium-review.googlesource.com/1100679
Commit-Ready: Stephen Barber <smbarber@chromium.org>
Tested-by: Stephen Barber <smbarber@chromium.org>
Reviewed-by: Chirantan Ekbote <chirantan@chromium.org>

[add] https://crrev.com/85ec2f75c6bebef31b13ad1ae3bd56f4e1bda4ec/README.md

Comment 5 by bugdroid1@chromium.org, Jun 18 2018

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/09ff35bf0115fd53b6b0ac834dd724bd0ccca3dd

commit 09ff35bf0115fd53b6b0ac834dd724bd0ccca3dd
Author: Stephen Barber <smbarber@chromium.org>
Date: Mon Jun 18 09:12:57 2018

common-mk: add protoc rule to generate go grpc

BUG= chromium:844079 
TEST=emerge-tatl tremplin-protos

Change-Id: I68080f7d401aa98bb3c4402c7d697cfb1283d6b9
Reviewed-on: https://chromium-review.googlesource.com/1096899
Commit-Ready: Stephen Barber <smbarber@chromium.org>
Tested-by: Stephen Barber <smbarber@chromium.org>
Reviewed-by: Chirantan Ekbote <chirantan@chromium.org>

[modify] https://crrev.com/09ff35bf0115fd53b6b0ac834dd724bd0ccca3dd/common-mk/protoc.gypi

Comment 6 by bugdroid1@chromium.org, Jun 19 2018

Project Member

Comment 7 by bugdroid1@chromium.org, Jun 21 2018

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/3d0fd6ed71928cba512deb6ee8b9b1bdd7ec46c0

commit 3d0fd6ed71928cba512deb6ee8b9b1bdd7ec46c0
Author: Stephen Barber <smbarber@chromium.org>
Date: Thu Jun 21 11:45:55 2018

app-emulation/lxd: install client/shared go packages

Install the go packages necessary to use the LXD client library.

Also fix up inheriting epatch, which prevented the UNPRIVILEGED_ONLY
patch from applying.

BUG= chromium:844079 
TEST=tremplin builds

Change-Id: I9b96509edc3b0b2eea1fa0c5656c9e0284478e6d
Reviewed-on: https://chromium-review.googlesource.com/1103613
Commit-Ready: Stephen Barber <smbarber@chromium.org>
Tested-by: Stephen Barber <smbarber@chromium.org>
Reviewed-by: Chirantan Ekbote <chirantan@chromium.org>

[modify] https://crrev.com/3d0fd6ed71928cba512deb6ee8b9b1bdd7ec46c0/app-emulation/lxd/lxd-2.21.ebuild
[rename] https://crrev.com/3d0fd6ed71928cba512deb6ee8b9b1bdd7ec46c0/app-emulation/lxd/lxd-2.21-r2.ebuild

Comment 8 by bugdroid1@chromium.org, Jun 21 2018

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/6cd942dddba77499a3ab704765d54f244934917c

commit 6cd942dddba77499a3ab704765d54f244934917c
Author: Stephen Barber <smbarber@chromium.org>
Date: Thu Jun 21 23:31:07 2018

vm_tools: add tremplin proto and constants

BUG= chromium:844079 
TEST=none

Change-Id: I347feafcaa61e79d39f8ceeae8f23614ce19960e
Reviewed-on: https://chromium-review.googlesource.com/1096901
Commit-Ready: Stephen Barber <smbarber@chromium.org>
Tested-by: Stephen Barber <smbarber@chromium.org>
Reviewed-by: Stephen Barber <smbarber@chromium.org>

[add] https://crrev.com/6cd942dddba77499a3ab704765d54f244934917c/vm_tools/proto/tremplin.proto
[modify] https://crrev.com/6cd942dddba77499a3ab704765d54f244934917c/vm_tools/common/constants.h

Comment 9 by bugdroid1@chromium.org, Jun 21 2018

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/23e9212caae17f47ca093ad760e68ae2abd322d5

commit 23e9212caae17f47ca093ad760e68ae2abd322d5
Author: Stephen Barber <smbarber@chromium.org>
Date: Thu Jun 21 23:31:08 2018

vm_tools: init: add iptables rules for tremplin

Also move these rules from vm_concierge to vm_cicerone's
upstart file.

BUG= chromium:844079 
TEST=start vm_concierge; iptables INPUT chain shows rules added

Change-Id: I729b531e0ec652ce850999bf80c76b66af8da109
Reviewed-on: https://chromium-review.googlesource.com/1103667
Commit-Ready: Stephen Barber <smbarber@chromium.org>
Tested-by: Stephen Barber <smbarber@chromium.org>
Reviewed-by: Chirantan Ekbote <chirantan@chromium.org>
Reviewed-by: Jeffrey Kardatzke <jkardatzke@google.com>

[modify] https://crrev.com/23e9212caae17f47ca093ad760e68ae2abd322d5/vm_tools/init/vm_cicerone.conf
[modify] https://crrev.com/23e9212caae17f47ca093ad760e68ae2abd322d5/vm_tools/init/vm_concierge.conf

Comment 10 by bugdroid1@chromium.org, Jun 28 2018

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/system_api/+/c7ccbd708eb8becfda81ffc4dde169f992e42162

commit c7ccbd708eb8becfda81ffc4dde169f992e42162
Author: Stephen Barber <smbarber@chromium.org>
Date: Thu Jun 28 05:07:01 2018

vm_cicerone: add LXD container methods and signals

Add the initial supported methods and signals for
direct control of LXD via tremplin.

BUG= chromium:844079 
TEST=none

Change-Id: I6cd48124d290821762913f0b5daf8995067e9d44
Reviewed-on: https://chromium-review.googlesource.com/1096896
Commit-Ready: Stephen Barber <smbarber@chromium.org>
Tested-by: Stephen Barber <smbarber@chromium.org>
Reviewed-by: Stephen Barber <smbarber@chromium.org>

[modify] https://crrev.com/c7ccbd708eb8becfda81ffc4dde169f992e42162/dbus/vm_cicerone/cicerone_service.proto
[modify] https://crrev.com/c7ccbd708eb8becfda81ffc4dde169f992e42162/dbus/vm_cicerone/dbus-constants.h

Comment 11 by bugdroid1@chromium.org, Jun 28 2018

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/tremplin/+/09a4c8b4b0184b04928c681eeb23b0522507ae18

commit 09a4c8b4b0184b04928c681eeb23b0522507ae18
Author: Stephen Barber <smbarber@chromium.org>
Date: Thu Jun 28 05:07:04 2018

tremplin: initial commit

Add an initial version of tremplin that implements CreateContainer,
StartContainer, SetUpUser and GetContainerUsername RPCs.

BUG= chromium:844079 
TEST=manual, start tremplin in a VM and use cicerone_client

Change-Id: Ie6ca23a97d9fd81eb952cee6d6812dd3d2396120
Reviewed-on: https://chromium-review.googlesource.com/1100693
Commit-Ready: Stephen Barber <smbarber@chromium.org>
Tested-by: Stephen Barber <smbarber@chromium.org>
Reviewed-by: Chirantan Ekbote <chirantan@chromium.org>

[add] https://crrev.com/09a4c8b4b0184b04928c681eeb23b0522507ae18/src/chromiumos/tremplin/main.go
[add] https://crrev.com/09a4c8b4b0184b04928c681eeb23b0522507ae18/src/chromiumos/tremplin/tremplin.go
[add] https://crrev.com/09a4c8b4b0184b04928c681eeb23b0522507ae18/src/chromiumos/tremplin/stdio_sink.go

Comment 12 by bugdroid1@chromium.org, Jun 28 2018

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/tremplin/+/77443eac4650399eb120be231aebbd85a60b0093

commit 77443eac4650399eb120be231aebbd85a60b0093
Author: Stephen Barber <smbarber@chromium.org>
Date: Thu Jun 28 05:07:05 2018

tremplin: use command-line flags for arguments

Add support for two command line flags, one for the host IP
to connect to, and a second for the IPv4 subnet to assign to LXD.

Also log to syslog by default, which is necessary to surface logs to
the host.

BUG= chromium:844079 
TEST=tremplin starts via maitred

Change-Id: Ia598494aa8713ad54ba0dd6fa39560383a3c6d18
Reviewed-on: https://chromium-review.googlesource.com/1111104
Commit-Ready: Stephen Barber <smbarber@chromium.org>
Tested-by: Stephen Barber <smbarber@chromium.org>
Reviewed-by: Dan Erat <derat@chromium.org>

[modify] https://crrev.com/77443eac4650399eb120be231aebbd85a60b0093/src/chromiumos/tremplin/main.go

Comment 13 by bugdroid1@chromium.org, Jun 28 2018

Project Member

Comment 14 by bugdroid1@chromium.org, Jun 28 2018

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/203755a42ca99304616e040b8c7fac70c09ba90f

commit 203755a42ca99304616e040b8c7fac70c09ba90f
Author: Stephen Barber <smbarber@chromium.org>
Date: Thu Jun 28 05:07:01 2018

vm_tools: cicerone: add cicerone_client

cicerone_client allows D-Bus calls for manipulating LXD containers via
tremplin, as well launching applications and getting icons from the guest
container.

BUG= chromium:844079 
TEST=cicerone_client with each command line option

Change-Id: Icc14a1da385d520e665626a7bc248f7a172bd968
Reviewed-on: https://chromium-review.googlesource.com/1096904
Commit-Ready: Stephen Barber <smbarber@chromium.org>
Tested-by: Stephen Barber <smbarber@chromium.org>
Reviewed-by: Chirantan Ekbote <chirantan@chromium.org>

[add] https://crrev.com/203755a42ca99304616e040b8c7fac70c09ba90f/vm_tools/cicerone/client.cc
[modify] https://crrev.com/203755a42ca99304616e040b8c7fac70c09ba90f/vm_tools/host.gypi

Comment 15 by bugdroid1@chromium.org, Jun 29 2018

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/23389211621ea9da146345df0ded0f6608b08921

commit 23389211621ea9da146345df0ded0f6608b08921
Author: Stephen Barber <smbarber@chromium.org>
Date: Fri Jun 29 12:21:36 2018

vm_guest_tools: install goprotos for tremplin

BUG= chromium:844079 
TEST=tremplin_proto is installed in GOPATH
CQ-DEPEND=CL:1096901

Change-Id: I678832bcf99f638f2e406766af7e0599b5a5a876
Reviewed-on: https://chromium-review.googlesource.com/1096907
Commit-Ready: Stephen Barber <smbarber@chromium.org>
Tested-by: Stephen Barber <smbarber@chromium.org>
Reviewed-by: Chirantan Ekbote <chirantan@chromium.org>

[modify] https://crrev.com/23389211621ea9da146345df0ded0f6608b08921/chromeos-base/vm_guest_tools/vm_guest_tools-9999.ebuild

Comment 16 by bugdroid1@chromium.org, Jun 29 2018

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/139dd7cbb9304c98aafdbf3fdade3afe253169c9

commit 139dd7cbb9304c98aafdbf3fdade3afe253169c9
Author: Stephen Barber <smbarber@chromium.org>
Date: Fri Jun 29 18:38:52 2018

chromeos-base/tremplin: add initial ebuild

BUG= chromium:844079 
TEST=emerge-tatl tremplin
CQ-DEPEND=CL:1100693

Change-Id: Ibb929b3f7069ccd1497f45153dd5b56bc69f927d
Reviewed-on: https://chromium-review.googlesource.com/1096906
Commit-Ready: Stephen Barber <smbarber@chromium.org>
Tested-by: Stephen Barber <smbarber@chromium.org>
Reviewed-by: Chirantan Ekbote <chirantan@chromium.org>

[add] https://crrev.com/139dd7cbb9304c98aafdbf3fdade3afe253169c9/chromeos-base/tremplin/tremplin-9999.ebuild

Comment 17 by bugdroid1@chromium.org, Jun 29 2018

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/52825534ae9d985e60a46a2a81d233f0d0cb20f5

commit 52825534ae9d985e60a46a2a81d233f0d0cb20f5
Author: Stephen Barber <smbarber@chromium.org>
Date: Fri Jun 29 21:16:39 2018

vm_host_tools: install cicerone_client

BUG= chromium:844079 
TEST=cicerone_client is on rootfs
CQ-DEPEND=CL:1096904

Change-Id: I1284cd50e962c0b6fb8e26549816ff0f05ac9cfe
Reviewed-on: https://chromium-review.googlesource.com/1096908
Commit-Ready: Stephen Barber <smbarber@chromium.org>
Tested-by: Stephen Barber <smbarber@chromium.org>
Reviewed-by: Chirantan Ekbote <chirantan@chromium.org>

[modify] https://crrev.com/52825534ae9d985e60a46a2a81d233f0d0cb20f5/chromeos-base/vm_host_tools/vm_host_tools-9999.ebuild

Comment 18 by bugdroid1@chromium.org, Jun 30 2018

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/board-overlays/+/76d303c6799c74abcc6fe75572ec10553606f9e0

commit 76d303c6799c74abcc6fe75572ec10553606f9e0
Author: Stephen Barber <smbarber@chromium.org>
Date: Sat Jun 30 05:00:55 2018

termina: lxd: remove obsolete LXD config options

/opt/google/garcon is no longer used, and neither is the wayland socket.

BUG= chromium:844079 
TEST=tatl starts up with either run_container.sh or tremplin

Change-Id: Ic33d9bd2b6d377fa8833aa28ca64088b7a800d82
Reviewed-on: https://chromium-review.googlesource.com/1121238
Commit-Ready: Stephen Barber <smbarber@chromium.org>
Tested-by: Stephen Barber <smbarber@chromium.org>
Reviewed-by: Chirantan Ekbote <chirantan@chromium.org>

[rename] https://crrev.com/76d303c6799c74abcc6fe75572ec10553606f9e0/project-termina/chromeos-base/termina-lxd-scripts/termina-lxd-scripts-0.0.1-r23.ebuild
[modify] https://crrev.com/76d303c6799c74abcc6fe75572ec10553606f9e0/project-termina/chromeos-base/termina-lxd-scripts/files/lxd_setup.sh

Comment 19 by bugdroid1@chromium.org, Jul 10 2018

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/board-overlays/+/0356348037f35a5b459d13d6e7416c02c0da72b2

commit 0356348037f35a5b459d13d6e7416c02c0da72b2
Author: Stephen Barber <smbarber@chromium.org>
Date: Tue Jul 10 10:16:03 2018

termina: add tremplin as target-termina-os dependency

BUG= chromium:844079 
TEST=build tatl
CQ-DEPEND=CL:1125345

Change-Id: I71a9ffe7a7a1c65e6e31c4ca9bd21134f5630215
Reviewed-on: https://chromium-review.googlesource.com/1096897
Commit-Ready: Stephen Barber <smbarber@chromium.org>
Tested-by: Stephen Barber <smbarber@chromium.org>
Reviewed-by: Stephen Barber <smbarber@chromium.org>

[rename] https://crrev.com/0356348037f35a5b459d13d6e7416c02c0da72b2/project-termina/virtual/target-termina-os/target-termina-os-1.5-r18.ebuild
[modify] https://crrev.com/0356348037f35a5b459d13d6e7416c02c0da72b2/project-termina/virtual/target-termina-os/target-termina-os-1.5.ebuild

Comment 20 by bugdroid1@chromium.org, Jul 10 2018

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/e427cd86eb47b97568fa11241bb1062bf3e5b11a

commit e427cd86eb47b97568fa11241bb1062bf3e5b11a
Author: Stephen Barber <smbarber@chromium.org>
Date: Tue Jul 10 10:16:04 2018

vm_tools: maitred: add and implement StartTermina RPC

In preparation for tremplin, create a StartTermina RPC that will
encapsulate any setup required to start containers.

For now, this moves the LaunchProcess calls from StartTermina in concierge
down into maitred.

BUG= chromium:844079 
TEST=StartTerminaVM and StartContainer D-Bus calls still work
CQ-DEPEND=CL:1096897

Change-Id: I7ec3a38662ac3a15155299a952d3eb6059ecb1fc
Reviewed-on: https://chromium-review.googlesource.com/1103005
Commit-Ready: Stephen Barber <smbarber@chromium.org>
Tested-by: Stephen Barber <smbarber@chromium.org>
Reviewed-by: Chirantan Ekbote (OOO 07/03 - 07/09) <chirantan@chromium.org>

[modify] https://crrev.com/e427cd86eb47b97568fa11241bb1062bf3e5b11a/vm_tools/maitred/service_impl.h
[modify] https://crrev.com/e427cd86eb47b97568fa11241bb1062bf3e5b11a/vm_tools/proto/vm_guest.proto
[modify] https://crrev.com/e427cd86eb47b97568fa11241bb1062bf3e5b11a/vm_tools/maitred/service_impl.cc

Comment 21 by bugdroid1@chromium.org, Jul 11 2018

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/tremplin/+/fd83e6de4f2db9008bb08e89b42cdc78e5a845b6

commit fd83e6de4f2db9008bb08e89b42cdc78e5a845b6
Author: Stephen Barber <smbarber@chromium.org>
Date: Wed Jul 11 12:24:13 2018

tremplin: fix setup and container creation

lxd.GetContainer will return an error of "not found" if the container doesn't
exist. We're only doing this as an optimization anyway, so just check that
the Container returned is non-nil.

Also set up the lxd_conf directory, which is required for feature-parity with
the current setup scripts.

BUG= chromium:844079 
TEST=CreateContainer RPC works; `lxc list` in VM shell works

Change-Id: Ifa1fb5897cc8cc44bad4178c784d61e0a7a49e6b
Reviewed-on: https://chromium-review.googlesource.com/1132599
Commit-Ready: Stephen Barber <smbarber@chromium.org>
Tested-by: Stephen Barber <smbarber@chromium.org>
Reviewed-by: Dan Erat <derat@chromium.org>

[modify] https://crrev.com/fd83e6de4f2db9008bb08e89b42cdc78e5a845b6/src/chromiumos/tremplin/main.go
[modify] https://crrev.com/fd83e6de4f2db9008bb08e89b42cdc78e5a845b6/src/chromiumos/tremplin/tremplin.go

Comment 22 by smbar...@chromium.org, Jul 20 2018

Labels: M-69
Status: Started (was: Assigned)
This is a prereq for ssh port forwarding.

Comment 23 by smbar...@chromium.org, Jul 20 2018

Blocking: 854923

Comment 24 by smbar...@chromium.org, Jul 20 2018

Blocking: 863578

Comment 25 by bugdroid1@chromium.org, Jul 26 2018

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/a0d17cf7f64b00f116b7453347eca4fa2ddadfd1

commit a0d17cf7f64b00f116b7453347eca4fa2ddadfd1
Author: Stephen Barber <smbarber@chromium.org>
Date: Thu Jul 26 11:07:28 2018

vm_tools: concierge: use StartTermina API

BUG= chromium:844079 
TEST=concierge_client --start_termina_vm

Change-Id: Ie4eb3aea328f03d7e4064da638bdde0d6775f7f3
Reviewed-on: https://chromium-review.googlesource.com/1103006
Commit-Ready: Stephen Barber <smbarber@chromium.org>
Tested-by: Stephen Barber <smbarber@chromium.org>
Reviewed-by: Chirantan Ekbote <chirantan@chromium.org>

[modify] https://crrev.com/a0d17cf7f64b00f116b7453347eca4fa2ddadfd1/vm_tools/concierge/virtual_machine.cc
[modify] https://crrev.com/a0d17cf7f64b00f116b7453347eca4fa2ddadfd1/vm_tools/concierge/virtual_machine.h
[modify] https://crrev.com/a0d17cf7f64b00f116b7453347eca4fa2ddadfd1/vm_tools/concierge/service.cc

Comment 26 by tbuck...@chromium.org, Jul 27 2018

Labels: ReleaseBlock-Beta

Comment 27 by cindyb@chromium.org, Jul 30 2018

What is that status of this bug? There are a number of changes in this one bug and marked as RBB, I do not see why this is the case.  Were they completed and included at branch point?

Comment 28 by smbar...@chromium.org, Jul 30 2018

Labels: Merge-Request-69
The change in #25 needs to be cherry-picked to M69. We've been blocked on a Chrome uprev on ToT that prevented us from verifying.

Comment 29 by sheriffbot@chromium.org, Jul 31 2018

Project Member
Labels: -Merge-Request-69 Hotlist-Merge-Approved Merge-Approved-69
Your change meets the bar and is auto-approved for M69. Please go ahead and merge the CL to branch 3497 manually. Please contact milestone owner if you have questions.
Owners: amineer@(Android), kariahda@(iOS), cindyb@(ChromeOS), govind@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 30 by smbar...@chromium.org, Aug 1

Blockedon: 869962
Need to merge the CL for  issue 869962  at the same time or crostini setup will be broken.

Comment 31 by sheriffbot@chromium.org, Aug 6

Project Member
This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible!

If all merges have been completed, please remove any remaining Merge-Approved labels from this issue.

Thanks for your time! To disable nags, add the Disable-Nags label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 32 by bugdroid1@chromium.org, Aug 6

Project Member
Labels: merge-merged-release-R69-10895.B
The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/2f21eab84f67bf15cf569f47c62fae5e96822480

commit 2f21eab84f67bf15cf569f47c62fae5e96822480
Author: Stephen Barber <smbarber@chromium.org>
Date: Mon Aug 06 19:07:51 2018

vm_tools: concierge: use StartTermina API

BUG= chromium:844079 
TEST=concierge_client --start_termina_vm

Change-Id: Ie4eb3aea328f03d7e4064da638bdde0d6775f7f3
Reviewed-on: https://chromium-review.googlesource.com/1103006
Commit-Ready: Stephen Barber <smbarber@chromium.org>
Tested-by: Stephen Barber <smbarber@chromium.org>
Reviewed-by: Chirantan Ekbote <chirantan@chromium.org>
(cherry picked from commit a0d17cf7f64b00f116b7453347eca4fa2ddadfd1)
Reviewed-on: https://chromium-review.googlesource.com/1164084
Reviewed-by: Stephen Barber <smbarber@chromium.org>
Commit-Queue: Stephen Barber <smbarber@chromium.org>

[modify] https://crrev.com/2f21eab84f67bf15cf569f47c62fae5e96822480/vm_tools/concierge/virtual_machine.cc
[modify] https://crrev.com/2f21eab84f67bf15cf569f47c62fae5e96822480/vm_tools/concierge/virtual_machine.h
[modify] https://crrev.com/2f21eab84f67bf15cf569f47c62fae5e96822480/vm_tools/concierge/service.cc

Comment 33 by smbar...@chromium.org, Aug 6

Labels: -Merge-Approved-69
Status: Fixed (was: Started)

Sign in to add a comment