PasswordGenerationInteractiveTest.PopupShownAndPasswordSelected failing on Mojo Linux bot |
||
Issue descriptionFirst failure: https://ci.chromium.org/buildbot/chromium.fyi/Mojo%20Linux/13451 Stack Trace: ``` ../../chrome/browser/password_manager/password_generation_interactive_uitest.cc:159: Failure Value of: EditingPopupShowing() Actual: false Expected: true Stack trace: #0 0x00000232b84c testing::internal::UnitTestImpl::CurrentOsStackTraceExceptTop() #1 0x00000232b229 testing::internal::AssertHelper::operator=() #2 0x0000020ad062 PasswordGenerationInteractiveTest_PopupShownAndPasswordSelected_Test::RunTestOnMainThread() #3 0x000004be351e content::BrowserTestBase::ProxyRunTestOnMainThreadLoop() #4 0x00000478b0b9 ChromeBrowserMainParts::PreMainMessageLoopRunImpl() #5 0x000004789d7a ChromeBrowserMainParts::PreMainMessageLoopRun() #6 0x0000030068e1 content::BrowserMainLoop::PreMainMessageLoopRun() #7 0x0000034b29a5 content::StartupTaskRunner::RunAllTasksNow() #8 0x000003005385 content::BrowserMainLoop::CreateStartupTasks() #9 0x000003009633 content::BrowserMainRunnerImpl::Initialize() #10 0x000003002c22 content::BrowserMain() #11 0x000004736ebb content::RunNamedProcessTypeMain() #12 0x0000047382b2 content::ContentMainRunnerImpl::Run() #13 0x00000657a4fb service_manager::Main() #14 0x000004735aa4 content::ContentMain() #15 0x000004be3082 content::BrowserTestBase::SetUp() #16 0x000004758180 InProcessBrowserTest::SetUp() [2357:2366:0517/084955.724757:WARNING:discardable_shared_memory_manager.cc(431)] Some MojoDiscardableSharedMemoryManagerImpls are still alive. They will be leaked. [2357:2473:0517/084955.727819:WARNING:internal_linux.cc(64)] Failed to read /proc/2386/stat [2357:2474:0517/084955.728113:WARNING:internal_linux.cc(64)] Failed to read /proc/2391/stat [2357:2357:0517/084955.737973:WARNING:url_request_context_getter.cc(43)] URLRequestContextGetter leaking due to no owning thread. [2357:2357:0517/084955.739141:WARNING:pref_notifier_impl.cc(23)] Pref observer found at shutdown. [2357:2357:0517/084955.739160:WARNING:pref_notifier_impl.cc(23)] Pref observer found at shutdown. [ FAILED ] PasswordGenerationInteractiveTest.PopupShownAndPasswordSelected, where TypeParam = and GetParam() = (573 ms) ``` Suspecting 47d67ced179788afbbf6e1cd106194b5ba67c8ae: `Update PasswordManager when a relevant credential is removed by the user.` Going to disable the test. vasilii@ Can you take a look if it's related? Thanks!
,
May 17 2018
Actually it's flaky on lots of places even without Network Service: http://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9taXVtLXRyeS1mbGFrZXNySgsSBUZsYWtlIj9QYXNzd29yZEdlbmVyYXRpb25JbnRlcmFjdGl2ZVRlc3QuUG9wdXBTaG93bkFuZFBhc3N3b3JkU2VsZWN0ZWQM We should probably revert the CL.
,
May 17 2018
OK, revert.
,
May 17 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/3a59c3eb8a2b87cfda23a6642de915c99bd3905f commit 3a59c3eb8a2b87cfda23a6642de915c99bd3905f Author: Chong Zhang <chongz@chromium.org> Date: Thu May 17 17:28:17 2018 Revert "Update PasswordManager when a relevant credential is removed by the user." This reverts commit 47d67ced179788afbbf6e1cd106194b5ba67c8ae. Reason for revert: Seems to cause flakiness on interactive_ui_tests http://chromium-try-flakes.appspot.com/search?q=PasswordGenerationInteractiveTest.PopupShownAndPasswordSelected Original change's description: > Update PasswordManager when a relevant credential is removed by the user. > > Before this CL this behavior is possible: > - a credential is autofilled. > - user removes the credential via settings or "Manage passwords" bubble. > - user clicks "Login" or reloads the page. In other words makes an action that we consider a successful form submission. > - password manager updates the credential in the store by reviving it. > > After this CL the password manager is informed as soon as the password is removed. Thus, the copy of the credential in the memory should go away. > > Bug: 821763 , 841853 > Change-Id: If6c371312a9ed55217f5998989dd0457296a538a > Reviewed-on: https://chromium-review.googlesource.com/1064118 > Reviewed-by: Vadym Doroshenko <dvadym@chromium.org> > Commit-Queue: Vasilii Sukhanov <vasilii@chromium.org> > Cr-Commit-Position: refs/heads/master@{#559539} TBR=vasilii@chromium.org,dvadym@chromium.org Change-Id: Ifbd0b85fd68399e01b58a8faaad29f677fb7ffe6 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 821763 , 841853 , 844077 Reviewed-on: https://chromium-review.googlesource.com/1064473 Reviewed-by: Chong Zhang <chongz@chromium.org> Commit-Queue: Chong Zhang <chongz@chromium.org> Cr-Commit-Position: refs/heads/master@{#559590} [modify] https://crrev.com/3a59c3eb8a2b87cfda23a6642de915c99bd3905f/chrome/browser/password_manager/password_manager_browsertest.cc [modify] https://crrev.com/3a59c3eb8a2b87cfda23a6642de915c99bd3905f/chrome/browser/ui/passwords/manage_passwords_state.cc [modify] https://crrev.com/3a59c3eb8a2b87cfda23a6642de915c99bd3905f/chrome/browser/ui/passwords/manage_passwords_state.h
,
May 17 2018
this is a flaky test. Happens outside of network services as well.
,
May 17 2018
Issue 844165 has been merged into this issue.
,
May 18 2018
Fixed by the revert. Now relanding https://chromium-review.googlesource.com/c/chromium/src/+/1065971 |
||
►
Sign in to add a comment |
||
Comment 1 by vasi...@chromium.org
, May 17 2018