New issue
Advanced search Search tips

Issue 844076 link

Starred by 2 users

Issue metadata

Status: Started
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

Add integration test using WindowService hosted by ash

Project Member Reported by sky@chromium.org, May 17 2018

Issue description

This should simulate what the apps will do. Namely create a widget, get events, and exit.
 
Project Member

Comment 1 by bugdroid1@chromium.org, May 18 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/92310cbab544a1a3ed2b1b0623155e2fe8c2c859

commit 92310cbab544a1a3ed2b1b0623155e2fe8c2c859
Author: Scott Violet <sky@chromium.org>
Date: Fri May 18 00:02:57 2018

Adds switch to enable ServiceProcessLauncher

This is useful for tests. Additionally made it so that catalog set via
SetDefaultCatalogManifest() is loaded in addition to the
static_manifest. Lastly, adds a scoped-allow-blocking in
ServiceProcessLauncher. This needs to be fixed, but as this code isn't
yet used in production the scoped-allow-blocking is ok.

Also, made catalog a lib so that other code can call static functions
and not end up with it's own copy.

BUG=844076
TEST=test coming shortly

Change-Id: I724a3cb63c425d2b5298d8c049fca9ac449745c3
Reviewed-on: https://chromium-review.googlesource.com/1064694
Commit-Queue: Scott Violet <sky@chromium.org>
Reviewed-by: Ken Rockot <rockot@chromium.org>
Cr-Commit-Position: refs/heads/master@{#559743}
[modify] https://crrev.com/92310cbab544a1a3ed2b1b0623155e2fe8c2c859/base/threading/thread_restrictions.h
[modify] https://crrev.com/92310cbab544a1a3ed2b1b0623155e2fe8c2c859/content/browser/service_manager/service_manager_context.cc
[modify] https://crrev.com/92310cbab544a1a3ed2b1b0623155e2fe8c2c859/content/public/common/content_switches.cc
[modify] https://crrev.com/92310cbab544a1a3ed2b1b0623155e2fe8c2c859/content/public/common/content_switches.h
[modify] https://crrev.com/92310cbab544a1a3ed2b1b0623155e2fe8c2c859/services/catalog/BUILD.gn
[modify] https://crrev.com/92310cbab544a1a3ed2b1b0623155e2fe8c2c859/services/catalog/catalog.h
[modify] https://crrev.com/92310cbab544a1a3ed2b1b0623155e2fe8c2c859/services/catalog/constants.h
[modify] https://crrev.com/92310cbab544a1a3ed2b1b0623155e2fe8c2c859/services/catalog/entry.h
[modify] https://crrev.com/92310cbab544a1a3ed2b1b0623155e2fe8c2c859/services/catalog/entry_cache.h
[modify] https://crrev.com/92310cbab544a1a3ed2b1b0623155e2fe8c2c859/services/catalog/instance.h
[modify] https://crrev.com/92310cbab544a1a3ed2b1b0623155e2fe8c2c859/services/catalog/manifest_provider.h
[modify] https://crrev.com/92310cbab544a1a3ed2b1b0623155e2fe8c2c859/services/service_manager/runner/host/service_process_launcher.cc

Sign in to add a comment