New issue
Advanced search Search tips

Issue 844068 link

Starred by 1 user
Status: Fixed
Owner:
jayhlee@google.com
Closed: May 2018
Cc:
vapier@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Update list of hostnames for network_diag --hosts

Project Member Reported by jayhlee@google.com, May 17 2018 
Chrome Version: 66

The list of hostnames that "network_diag --hosts" CroSH command uses is a bit stale. The help article (which serves as source of truth) has added a few more over time:

https://support.google.com/chrome/a/answer/6334001?hl=en&ref_topic=3504941

Need to add a few more hosts to the list. Note not every host on the list is included as some do not use HTTPS (such as mtalk.google.com which is XMPP actually).
Project Member

Comment 1 by bugdroid1@chromium.org, May 20 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/d12a813e5c80e0ae8fc7e281483c477905d27b60

commit d12a813e5c80e0ae8fc7e281483c477905d27b60
Author: Jay Lee <jayhlee@google.com>
Date: Sun May 20 01:35:54 2018

crosh: Update list of hostnames

Add new hostnames to network_diag --hosts check.

BUG= chromium:844068 
TEST=run crosh network_diag --hosts command and confirm new hosts are
tested

Change-Id: I67f565e6c56905c61a66e36b1bd1ff1cc64a065f
Reviewed-on: https://chromium-review.googlesource.com/1064497
Commit-Ready: Jay Lee <jayhlee@chromium.org>
Tested-by: Jay Lee <jayhlee@chromium.org>
Reviewed-by: Mike Frysinger <vapier@chromium.org>

[modify] https://crrev.com/d12a813e5c80e0ae8fc7e281483c477905d27b60/crosh/network_diag

Comment 2 by jayhlee@google.com, May 21 2018

Status: Fixed (was: Untriaged)
►

Sign in to add a comment