Issue metadata
Sign in to add a comment
|
Investigate why on resume from suspend sometimes we fail to set the CRTC CTM |
||||||||||||||||||||||
Issue descriptionIssue 843750 fixed the side effect of this bug (which was that the Night Light color matrix was applied twice). We need to investigate why we could end up in such a state. The two theories are: - In this state display_id is not present in the configurator's cached displays [1]. - `has_color_correction_matrix()` is false, which could mean that reading the "CTM" property in the drm device failed for some reason [2]. [1]: https://cs.chromium.org/chromium/src/ash/display/display_color_manager.cc?type=cs&q=DisplayColorManager::SetDisplayColorMatrix&l=206 [2]: https://cs.chromium.org/chromium/src/ui/ozone/platform/drm/common/drm_util.cc?type=cs&q=CreateDisplaySnapshot&l=418 [2] is only likely if we're closing and reopening the drm device.
,
Jun 12 2018
Oh, this bug was to investigate the root cause.
,
Jun 13 2018
[2] should not be the case on builds that include https://chromium-review.googlesource.com/c/chromium/src/+/1089858 since we should not be trying to set CTM via DRM. Is there a log dump for this issue? Perhaps there's a hint in there ... I'm wondering what the DRM error is. |
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by afakhry@chromium.org
, Jun 12 2018